Okay, I can be convinced. :)
Diff and RFC updated.
And I agree on the slight sense of unease at adding a third encoding
converter, but ICU is so far ahead of the other two that I really feel
we should encourage its use over iconv and mbstring.
-Sara
On Wed, Oct 31, 2012 at 6:40 PM, Adam Harvey
On 31 October 2012 06:18, Sara Golemon wrote:
> With the exception of renaming the UConverter::UCNV_* constants to
> remove the UCNV_ prefix, I believe I've addressed the concerns thus
> far. ((Waiting to hear if anyone else wants to weigh in on the
> contants)) The RFC has been updated accordin
After the updates it looks really good, very handy functionality to have.
On Tue, Oct 30, 2012 at 6:18 PM, Sara Golemon wrote:
> With the exception of renaming the UConverter::UCNV_* constants to
> remove the UCNV_ prefix, I believe I've addressed the concerns thus
> far. ((Waiting to hear if an
With the exception of renaming the UConverter::UCNV_* constants to
remove the UCNV_ prefix, I believe I've addressed the concerns thus
far. ((Waiting to hear if anyone else wants to weigh in on the
contants)) The RFC has been updated accordingly.+
--
PHP Internals - PHP Runtime Development Mail
> 1. transcode() accepts options, but there's no comparable way to set
> options to the object. I think these APIs should be synchronized.
> Imagine code keeping options in array/config object - it's be really
> annoying to have two separate procedures to feed these to object and to
> transcode().
Hi!
> http://wiki.php.net/rfc/uconverter
>
> Discuss!
Looks nice. Some points:
1. transcode() accepts options, but there's no comparable way to set
options to the object. I think these APIs should be synchronized.
Imagine code keeping options in array/config object - it's be really
annoying to
> - the UCNV prefix is not necessary, we are in the UConverter class
> already, I would simply use LATIN_1, or ILLEGAL for exampe.
> - I would add ERROR_ to the error related constants (UNASSIGNED & co), or?
>
For the UConverterType enum I could maybe get behind that. For
UConverterCallbackReason
Em 2012-10-30 2:57, Sara Golemon escreveu:
http://wiki.php.net/rfc/uconverter
Discuss!
Good work. I do, however, have some concerns:
* Error handling is done in a different way from the rest of the
extension.
Error handling in ext/intl is, admittedly, a little strange. Errors are
both sto
Very nice work.
Bravo!
On 30/10/12 02:57, Sara Golemon wrote:
http://wiki.php.net/rfc/uconverter
Discuss!
--
Ivan Enderlin
Developer of Hoa
http://hoa.42/ or http://hoa-project.net/
PhD. student at DISC/Femto-ST (Vesontio) and INRIA (Cassis)
http://disc.univ-fcomte.fr/ and http://www.inria
btw, can you add the changes to config.w32 too pls? Pretty much the
same than in .m4, so I can add it to our CI and valid the RFC patch
in a more handy manner :)
On Tue, Oct 30, 2012 at 2:57 AM, Sara Golemon wrote:
> http://wiki.php.net/rfc/uconverter
>
> Discuss!
>
> --
> PHP Internals - PHP Ru
hi Sara!
On Tue, Oct 30, 2012 at 2:57 AM, Sara Golemon wrote:
> http://wiki.php.net/rfc/uconverter
>
> Discuss!
Nice job!
Some comments, raw :) :
- the UCNV prefix is not necessary, we are in the UConverter class
already, I would simply use LATIN_1, or ILLEGAL for exampe.
- It is OO, we should
http://wiki.php.net/rfc/uconverter
Discuss!
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
12 matches
Mail list logo
