Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-02 Thread Bob Weinand
> Am 02.06.2016 um 14:11 schrieb Dmitry Stogov : > > > > On 06/02/2016 03:01 PM, Bob Weinand wrote: >>> Am 01.06.2016 um 12:55 schrieb Dmitry Stogov : >>> >>> hi, >>> >>> >>> Please take a look into the proposal. >>> >>> >>>

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-02 Thread Dmitry Stogov
On 06/02/2016 03:01 PM, Bob Weinand wrote: Am 01.06.2016 um 12:55 schrieb Dmitry Stogov : hi, Please take a look into the proposal. https://wiki.php.net/rfc/too_few_args The RFC is extremely simple (both proposal and implementation) and almost completely described by

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-02 Thread Dmitry Stogov
On 06/02/2016 02:42 PM, Benjamin Eberlei wrote: On Wed, Jun 1, 2016 at 12:55 PM, Dmitry Stogov > wrote: hi, Please take a look into the proposal. https://wiki.php.net/rfc/too_few_args The RFC is extremely simple (both proposal

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-02 Thread Bob Weinand
> Am 01.06.2016 um 12:55 schrieb Dmitry Stogov : > > hi, > > > Please take a look into the proposal. > > > https://wiki.php.net/rfc/too_few_args > > > The RFC is extremely simple (both proposal and implementation) and almost > completely described by the email subject. >

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-02 Thread Benjamin Eberlei
On Wed, Jun 1, 2016 at 12:55 PM, Dmitry Stogov wrote: > hi, > > > Please take a look into the proposal. > > > https://wiki.php.net/rfc/too_few_args > > > The RFC is extremely simple (both proposal and implementation) and almost > completely described by the email subject. > > I

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-02 Thread Rowan Collins
On 02/06/2016 00:19, Aaron Piotrowski wrote: On Jun 1, 2016, at 3:56 PM, Rowan Collins wrote: On 01/06/2016 19:36, Aaron Piotrowski wrote: While this might be considered a BC break, I can't imagine there's an actual code out there relying on suppressing the warning

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Stanislav Malyshev
Hi! > Please take a look into the proposal. > > > https://wiki.php.net/rfc/too_few_args > > > The RFC is extremely simple (both proposal and implementation) and almost > completely described by the email subject. Looks fine to me. I don't think having undef function parameters is a very

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Aaron Piotrowski
> On Jun 1, 2016, at 3:56 PM, Rowan Collins wrote: > > On 01/06/2016 19:36, Aaron Piotrowski wrote: >> While this might be considered a BC break, I can't imagine there's an actual >> code out there relying on suppressing the warning just to call a function >> without

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Stanislav Malyshev
Hi! > Note that func_get_args() should die too since we have variadic > arguments now. It should not. There is nothing wrong with this function, the fact that some of it's functionality is covered by variadic args notwithstanding. -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Rowan Collins
On 01/06/2016 19:36, Aaron Piotrowski wrote: While this might be considered a BC break, I can't imagine there's an actual code out there relying on suppressing the warning just to call a function without enough arguments. I see no problem putting this change in 7.1. I think you're

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Nikita Popov
On Wed, Jun 1, 2016 at 8:24 PM, Dmitry Stogov wrote: > In the SSA optimisation framework (part of opcache), we predict and > propagate types of variables. > > We also may detect situations when some variables may be undefined. > > If variable can't be "undefined", we may avoid

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Aaron Piotrowski
> > On Jun 1, 2016, at 5:55 AM, Dmitry Stogov wrote: > > hi, > > > Please take a look into the proposal. > > > https://wiki.php.net/rfc/too_few_args > > > The RFC is extremely simple (both proposal and implementation) and almost > completely described by the email

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Dmitry Stogov
lt;pthre...@pthreads.org> Sent: Wednesday, June 1, 2016 8:42:49 PM To: Dmitry Stogov Cc: PHP internals; Nikita Popov Subject: Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception Evening, Could you expand on the "obvious optimization o

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Joe Watkins
Evening, Could you expand on the "obvious optimization opportunities" in the document ? They are not obvious to me, and even if they were, this document is part of the history of this change, so a little more detail would be nice. Cheers Joe On Wed, Jun 1, 2016 at 11:55 AM, Dmitry

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Fleshgrinder
On 6/1/2016 1:33 PM, Rowan Collins wrote: > I like the concept behind this, but I worry it might have a rather large > BC impact. Like removing call-time pass-by-reference, there may be a lot > of long-untouched code that needs fixing to work within this constraint. > I'm not even sure how easy it

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Rowan Collins
On 01/06/2016 11:55, Dmitry Stogov wrote: hi, Please take a look into the proposal. https://wiki.php.net/rfc/too_few_args The RFC is extremely simple (both proposal and implementation) and almost completely described by the email subject. I think, this mini-RFC doesn't need 2-weeks

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Dmitry Stogov
Popov Subject: Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception On 06/01/2016 12:55 PM, Dmitry Stogov wrote: > hi, > Please take a look into the proposal. > > https://wiki.php.net/rfc/too_few_args My first thought

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Florian Anderiasch
On 06/01/2016 12:55 PM, Dmitry Stogov wrote: > hi, > Please take a look into the proposal. > > https://wiki.php.net/rfc/too_few_args My first thought went into how people use func_get_args() as this is (in a sense) the opposite thereof. That said I couldn't think of a good reason to disagree,

[PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Dmitry Stogov
hi, Please take a look into the proposal. https://wiki.php.net/rfc/too_few_args The RFC is extremely simple (both proposal and implementation) and almost completely described by the email subject. I think, this mini-RFC doesn't need 2-weeks discussion period, so I'm going to start the