Re: [PHP-DEV] Issues with readonly classes

2022-09-21 Thread Yasuo Ohgaki
2022ๅนด9ๆœˆ3ๆ—ฅ(ๅœŸ) 2:31 Nicolas Grekas : > Hello everybody, hi Mate > > I played with readonly classes recently, to add support for them to > lazy-loading proxy generation and I struggled upon what I see as serious > issues. > > As noted in the RFC, and because the readonly flag must be set on child > c

Re: [PHP-DEV] Issues with readonly classes

2022-09-05 Thread Robert Landers
On Mon, Sep 5, 2022 at 9:57 AM Nicolas Grekas wrote: > > >Hi Marco, > > > > > >IMO good as-is: can be relaxed later (8.3 or later), if anybody believes > > >> it's a show-stopper. > > >> > > >Readonly classes don't really need to be lazy. > > >> > > > > > >"Break things and move slow" doesn't feel

Re: [PHP-DEV] Issues with readonly classes

2022-09-05 Thread Nicolas Grekas
>Hi Marco, > > > >IMO good as-is: can be relaxed later (8.3 or later), if anybody believes > >> it's a show-stopper. > >> > >Readonly classes don't really need to be lazy. > >> > > > >"Break things and move slow" doesn't feel right to me for the language. > > It's a new keyword that you have to opt

Re: [PHP-DEV] Issues with readonly classes

2022-09-04 Thread Derick Rethans
On 4 September 2022 11:46:18 BST, Nicolas Grekas wrote: >Hi Marco, > >IMO good as-is: can be relaxed later (8.3 or later), if anybody believes >> it's a show-stopper. >> >Readonly classes don't really need to be lazy. >> > >"Break things and move slow" doesn't feel right to me for the language.

Re: [PHP-DEV] Issues with readonly classes

2022-09-04 Thread Marco Pivetta
It doesn't break anything: we have a new limitation, we observe if it is problematic, we remove that limitation if that is the case. That already happened for PHP 8.1, although I can't remember the exact feature. Let the side wheels attached for now ๐Ÿ‘ On Sun, 4 Sep 2022, 12:46 Nicolas Grekas, w

Re: [PHP-DEV] Issues with readonly classes

2022-09-04 Thread Nicolas Grekas
Hi Marco, IMO good as-is: can be relaxed later (8.3 or later), if anybody believes > it's a show-stopper. > Readonly classes don't really need to be lazy. > "Break things and move slow" doesn't feel right to me for the language. Maybe you don't see the need for lazy readonly classes, but that's n

Re: [PHP-DEV] Issues with readonly classes

2022-09-02 Thread Marco Pivetta
IMO good as-is: can be relaxed later (8.3 or later), if anybody believes it's a show-stopper. Readonly classes don't really need to be lazy. Marco Pivetta https://twitter.com/Ocramius https://ocramius.github.io/ On Fri, 2 Sept 2022 at 19:31, Nicolas Grekas wrote: > Hello everybody, hi Mate

[PHP-DEV] Issues with readonly classes

2022-09-02 Thread Nicolas Grekas
Hello everybody, hi Mate I played with readonly classes recently, to add support for them to lazy-loading proxy generation and I struggled upon what I see as serious issues. As noted in the RFC, and because the readonly flag must be set on child classes, those cannot: 1. Declare a new non-rea