Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-17 Thread Ferenc Kovacs
I agree that this feature should be avoided in userland, but I think that it would be terrible, if this bugfix would stay this way, because this breaks backward compatibility -without notification- with a minor version update both in 5.3 and 5.2 branch. Tyrael On Thu, Dec 17, 2009 at 7:37 AM,

Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-17 Thread Stefan Esser
Hi, because this breaks backward compatibility -without notification- with a minor version update both in 5.3 and 5.2 branch. well actually the bug was that call_user_func_array() did not trigger the what you do is deprecated warning. Calling the function directly would have resulted in a this

Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-17 Thread Ferenc Kovacs
As tsarling stated in the bugreport: http://bugs.php.net/bug.php?id=50394 I'm not complaining about the warning, which I just added to demonstrate the problem. I'm not complaining about the new behaviour of zend_call_function() as of PHP 5.3.0, I'm complaining about the lost reference in __call

Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-17 Thread Stanislav Malyshev
Hi! Test cases can be found here:http://bugs.php.net/bug.php?id=50394. It seems to me that a special case would be needed to restore the behaviour seen in PHP 5.3.0. I'll check it out, seems to be valid use case, we should find some solution for that. There seems to have been no progress

Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-17 Thread Tim Starling
Stanislav Malyshev wrote: Tim, could you check if the attached patch solves your problem? Yes, it works for me, in both the isolated test case and the original MW bug. MW's parser test suite shows 4 failing tests in 5.3.1, all fixed with this patch and no new regressions. Stefan Esser

Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-17 Thread Stanislav Malyshev
Hi! Yes, it works for me, in both the isolated test case and the original MW bug. MW's parser test suite shows 4 failing tests in 5.3.1, all fixed with this patch and no new regressions. Great, will commit the patch tomorrow then to all branches. The underlying functions are declared with

Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-16 Thread Tim Starling
Stanislav Malyshev wrote: Hi! Test cases can be found here:http://bugs.php.net/bug.php?id=50394. It seems to me that a special case would be needed to restore the behaviour seen in PHP 5.3.0. I'll check it out, seems to be valid use case, we should find some solution for that. There

Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-16 Thread Stefan Esser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Tim, There seems to have been no progress on this. Is there anything I can do to help? just for the record: why does MediaWiki rely on a feature Call-Time-Pass-By-Reference that is deprecated since PHP 4.0.0 - Yes exactly 4.0.0 What happened

Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-12 Thread Keisial
Tim Starling wrote: Since 5.3.1 it's impossible to have a reference parameter passed to a __call() function. This change causes bugs in MediaWiki, where an attempt by a proxy object to pass a call through to a function that accepts reference parameters will always fail, due to the

[PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-09 Thread Tim Starling
Since 5.3.1 it's impossible to have a reference parameter passed to a __call() function. This is apparently due to the bugfix committed by stas as shown here: http://svn.php.net/viewvc/php/php-src/branches/PHP_5_2/Zend/zend_execute_API.c?r1=287466r2=287465pathrev=287466 Test cases can be found

Re: [PHP-DEV] PHP 5.3.1 reference parameter regression

2009-12-09 Thread Stanislav Malyshev
Hi! Test cases can be found here:http://bugs.php.net/bug.php?id=50394. It seems to me that a special case would be needed to restore the behaviour seen in PHP 5.3.0. I'll check it out, seems to be valid use case, we should find some solution for that. I've tried emailing stas but I didn't