Re: [PHP-DEV] Proposal: $options argument for SimpleXMLElement::asXML

2023-09-10 Thread Rowan Tommins
On 9 September 2023 21:05:37 BST, Niels Dossche wrote: >Hi internals > >I came across https://bugs.php.net/bug.php?id=67387. >Passing the option in via the constructor doesn't work because the constructor >only allows parser options. >We can implement support for options (such as

[PHP-DEV] Proposal: $options argument for SimpleXMLElement::asXML

2023-09-09 Thread Niels Dossche
Hi internals I came across https://bugs.php.net/bug.php?id=67387. Passing the option in via the constructor doesn't work because the constructor only allows parser options. We can implement support for options (such as LIBXML_NOXMLDECL, LIBXML_SAVE_NOEMPTYTAG) by adding an (optional) argument