[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 10:45 AM, Stas Malyshev wrote: Hi! On 9/6/11 1:24 AM, Andrey Hristov wrote: no, it's about consistency, which you want. mysqlnd should behave like libmysql, and it is a test that can test it. What libmysql returns in filtered in mysqli, mysqli_num_rows() is a direct wrapper

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! Have you actually checked what libmysql returns??!? If _you_ just have tried to do it, you might actually find that libmysql does what mysqlnd did long ago, but mysqli was hiding it. Here is output from what libmysql does, after removing the following check from mysqli_api.c: I checked

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 11:16 AM, Stas Malyshev wrote: Hi! Have you actually checked what libmysql returns??!? If _you_ just have tried to do it, you might actually find that libmysql does what mysqlnd did long ago, but mysqli was hiding it. Here is output from what libmysql does, after removing the

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 2:46 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)-handle (r)-handle-status == MYSQL_STATUS_USE_RESULT) || ((r)-data == NULL)) When I step through your code, r-data

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
Stas, On 09/06/2011 06:55 PM, Stas Malyshev wrote: Hi! On 9/6/11 2:46 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)-handle (r)-handle-status == MYSQL_STATUS_USE_RESULT) || ((r)-data ==

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)-handle (r)-handle-status == MYSQL_STATUS_USE_RESULT) || ((r)-data == NULL)) When I step through your code, r-data

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 09:08 PM, Stas Malyshev wrote: Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)-handle (r)-handle-status == MYSQL_STATUS_USE_RESULT) || ((r)-data ==

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 09:54 PM, Andrey Hristov wrote: On 09/06/2011 09:08 PM, Stas Malyshev wrote: Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)-handle (r)-handle-status