Re: [PHP-DEV] Sync CODEOWNERS

2024-07-18 Thread Christoph M. Becker
Hi Niels! On 18.07.2024 at 14:44, Niels Dossche wrote: > I believe they should be synced indeed, although we should be careful > with extensions that are dropped from PHP (e.g. imap). Those entries > should remain only in 8.2 and 8.3 but not in master. Oh, right! My idea was to handle this

Re: [PHP-DEV] Sync CODEOWNERS

2024-07-18 Thread Peter Kokot
On Thu, 18 Jul 2024, 16:32 Ilija Tovilo, wrote: > Hi Christoph > > On Thu, Jul 18, 2024 at 2:09 PM Christoph M. Becker > wrote: > > > > So I suggest to sync CODEOWNERS for all active branches (and maybe even > > security branches). > > > > What do you think? > > I think back when it was

Re: [PHP-DEV] Sync CODEOWNERS

2024-07-18 Thread Ilija Tovilo
Hi Christoph On Thu, Jul 18, 2024 at 2:09 PM Christoph M. Becker wrote: > > So I suggest to sync CODEOWNERS for all active branches (and maybe even > security branches). > > What do you think? I think back when it was introduced it wasn't clear (at least to me) that PRs would request reviews

Re: [PHP-DEV] Sync CODEOWNERS

2024-07-18 Thread Niels Dossche
On 18/07/2024 14:08, Christoph M. Becker wrote: > Hi all! > > I have noticed that the CODEOWNERS of php-src are apparently not synced > for all active branches[1][2]. However, it seems to me that this > doesn't make sense; if someone provides a PR against some lower branch, > the most recent

Re: [PHP-DEV] Sync CODEOWNERS

2024-07-18 Thread Saki Takamachi
Hi Christoph, > Hi all! > > I have noticed that the CODEOWNERS of php-src are apparently not synced > for all active branches[1][2]. However, it seems to me that this > doesn't make sense; if someone provides a PR against some lower branch, > the most recent CODEOWNERS may not be notified, and

[PHP-DEV] Sync CODEOWNERS

2024-07-18 Thread Christoph M. Becker
Hi all! I have noticed that the CODEOWNERS of php-src are apparently not synced for all active branches[1][2]. However, it seems to me that this doesn't make sense; if someone provides a PR against some lower branch, the most recent CODEOWNERS may not be notified, and modifications might be send