Re: [PHP-DEV] exception policy for core

2007-10-22 Thread Marcus Boerger
Hello Lukas, I think all pecl modules should follow the core rules and that means CODINT_STYLE should apply to pecl as much as it does to core. We should hence provide an easy to read (as in html or pdf or whatever) version that is accessible online easier and in a more prominent space than the

Re: [PHP-DEV] exception policy for core

2007-10-22 Thread Lukas Kahwe Smith
On 22.10.2007, at 17:31, Marcus Boerger wrote: Hello Lukas, I think all pecl modules should follow the core rules and that means CODINT_STYLE should apply to pecl as much as it does to core. We should hence provide an easy to read (as in html or pdf or whatever) version that is

Re: [PHP-DEV] exception policy for core

2007-10-21 Thread Lukas Kahwe Smith
On 17.10.2007, at 22:11, Marcus Boerger wrote: Hello Derick, right, maybe we need writen down rules easy to read for pecl and core other then the CODING_STYLES bile. So how do you propose to proceed? What is not easy to read in the current CS? Should the note about not throwing

Re: [PHP-DEV] exception policy for core

2007-10-19 Thread Larry Garfield
On Friday 19 October 2007, Lukas Kahwe Smith wrote: I've actually had issues in the past with PDO and non-exception error-mode handling. I had queries that were running fine but when I checked the error value it gave a non-OK value. (I forget what off hand.) As soon as I switched

Re: [PHP-DEV] exception policy for core

2007-10-19 Thread Lukas Kahwe Smith
On 19.10.2007, at 02:20, Larry Garfield wrote: On Thursday 18 October 2007, Lukas Kahwe Smith wrote: The possibility of changing the error mode at run-time makes it quite hard to read code. Since you always have to check the error mode of the object you're currently looking at. Therefore I

Re: [PHP-DEV] exception policy for core

2007-10-18 Thread Antony Dovgal
On 17.10.2007 20:09, Lukas Kahwe Smith wrote: Hi, I remember that we discussed the question of exception throwing from core in the very early days of php 5, when the suggestion of turning all errors into exceptions first came up. I remember that we decided that exceptions should only

Re: [PHP-DEV] exception policy for core

2007-10-18 Thread Johannes Schlüter
Hi, On Thu, 2007-10-18 at 11:45 +0400, Antony Dovgal wrote: On 17.10.2007 20:09, Lukas Kahwe Smith wrote: Hi, I remember that we discussed the question of exception throwing from core in the very early days of php 5, when the suggestion of turning all errors into exceptions first

Re: [PHP-DEV] exception policy for core

2007-10-18 Thread Marcus Boerger
Hello Derick, right, maybe we need writen down rules easy to read for pecl and core other then the CODING_STYLES bile. marcus Wednesday, October 17, 2007, 7:38:56 PM, you wrote: On Wed, 17 Oct 2007, Lukas Kahwe Smith wrote: Hi, I remember that we discussed the question of exception

Re: [PHP-DEV] exception policy for core

2007-10-18 Thread Lukas Kahwe Smith
On 18.10.2007, at 12:29, Johannes Schlüter wrote: Hi, On Thu, 2007-10-18 at 11:45 +0400, Antony Dovgal wrote: On 17.10.2007 20:09, Lukas Kahwe Smith wrote: Hi, I remember that we discussed the question of exception throwing from core in the very early days of php 5, when the suggestion of

[PHP-DEV] exception policy for core

2007-10-17 Thread Lukas Kahwe Smith
Hi, I remember that we discussed the question of exception throwing from core in the very early days of php 5, when the suggestion of turning all errors into exceptions first came up. I remember that we decided that exceptions should only be thrown from core on constructor errors by

Re: [PHP-DEV] exception policy for core

2007-10-17 Thread Derick Rethans
On Wed, 17 Oct 2007, Lukas Kahwe Smith wrote: Hi, I remember that we discussed the question of exception throwing from core in the very early days of php 5, when the suggestion of turning all errors into exceptions first came up. I remember that we decided that exceptions should only be