Re: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2015-01-01 Thread Dmitry Stogov
Thanks for analizing. did you say 8.5 more instructions? in my test I saw less. It's really an intermedie step, and we probably will check if other optimizations are reaaly benefitable before committing this. But yes, this patch doesn't make any degradation, except for slight increase of memory

RE: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2015-01-01 Thread Dmitry Stogov
Hi François, this is not a proposal yet, this is just an initial request to the most experinced PHP developers to think about possible consequnces. Thanks. Dmitry. On Dec 31, 2014 9:50 PM, François Laupretre franc...@tekwire.net wrote: De : Dmitry Stogov [mailto:dmi...@zend.com] Please

Re: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2015-01-01 Thread Anatol Belski
Hi, On Thu, January 1, 2015 13:30, Dmitry Stogov wrote: Thanks for analizing. did you say 8.5 more instructions? in my test I saw less. It's really an intermedie step, and we probably will check if other optimizations are reaaly benefitable before committing this. But yes, this patch

RE: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2014-12-31 Thread François Laupretre
De : Dmitry Stogov [mailto:dmi...@zend.com] Please take a look into the patch https://github.com/php/php-src/pull/970/files This real changes are in zend_types.h, the rest is renaming that in most cases makes code cleaner. zend_array didn't change its binary representation, but now

Re: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2014-12-31 Thread Andrea Faulds
Hey François, On 31 Dec 2014, at 17:50, François Laupretre franc...@tekwire.net wrote: Showing 46 changed files with 193 additions and 204 deletions. I am sorry but I can't analyze the impacts of your change, just from the patch. Did you write an RFC that would explain the impact,

Re: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2014-12-31 Thread Anatol Belski
Hi Dmitry, On Wed, December 31, 2014 11:19, Dmitry Stogov wrote: Hi, Please take a look into the patch https://github.com/php/php-src/pull/970/files This real changes are in zend_types.h, the rest is renaming that in most cases makes code cleaner. zend_array didn't change its binary

Re: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2014-12-31 Thread Pierre Joye
On Jan 1, 2015 2:00 AM, Andrea Faulds a...@ajf.me wrote: Hey François, On 31 Dec 2014, at 17:50, François Laupretre franc...@tekwire.net wrote: Showing 46 changed files with 193 additions and 204 deletions. I am sorry but I can't analyze the impacts of your change, just from the patch.