Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Mark Brown
On Wed, Apr 25, 2012 at 12:41:47PM +0200, Thierry Reding wrote: > After taking a closer look I don't think Rhyland's patch is very useful for > this driver. I need to lookup the platform ID by regulator name anyway so > using the new code is actually more work and requires a second table that > li

Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Mark Brown
On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote: > This commit adds device tree support for the TPS6586x regulator. > > Signed-off-by: Thierry Reding This looks basically good from a quick scan through but the pattern of looking up regulator nodes by name is very common so should

Re: [RFC v2 3/5] i2c: Add of_i2c_get_adapter() function

2012-04-25 Thread Thierry Reding
* Stephen Warren wrote: > On 04/25/2012 03:45 AM, Thierry Reding wrote: > > This function resolves an OF device node to an I2C adapter registered > > with the I2C core. > > I think this is doing the same thing as a patch I posted recently: > http://www.spinics.net/lists/linux-i2c/msg07808.html I

Re: [RFC v2 3/5] i2c: Add of_i2c_get_adapter() function

2012-04-25 Thread Stephen Warren
On 04/25/2012 03:45 AM, Thierry Reding wrote: > This function resolves an OF device node to an I2C adapter registered > with the I2C core. I think this is doing the same thing as a patch I posted recently: http://www.spinics.net/lists/linux-i2c/msg07808.html What's the advantage of one way over t

Re: [RFC v2 0/5] Add NVIDIA Tegra DRM support

2012-04-25 Thread Thierry Reding
* Thierry Reding wrote: > This series adds a basic DRM driver for NVIDIA Tegra 2 processors. It > currently only supports the RGB output and I've successfully tested it > against the fbcon kernel module and the xf86-video-modesetting driver. > The code uses the Tegra's IOMMU/GART to remap non-conti

Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Thierry Reding
* Mark Brown wrote: > On Wed, Apr 25, 2012 at 12:41:47PM +0200, Thierry Reding wrote: > > > After taking a closer look I don't think Rhyland's patch is very useful for > > this driver. I need to lookup the platform ID by regulator name anyway so > > using the new code is actually more work and req

Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Thierry Reding
* Thierry Reding wrote: > * Mark Brown wrote: > > On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote: > > > This commit adds device tree support for the TPS6586x regulator. > > > > > > Signed-off-by: Thierry Reding > > > > This looks basically good from a quick scan through but the p

Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Thierry Reding
* Mark Brown wrote: > On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote: > > This commit adds device tree support for the TPS6586x regulator. > > > > Signed-off-by: Thierry Reding > > This looks basically good from a quick scan through but the pattern of > looking up regulator nodes

[RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Thierry Reding
This commit adds device tree support for the TPS6586x regulator. Signed-off-by: Thierry Reding --- .../devicetree/bindings/regulator/tps6586x.txt | 97 ++ drivers/mfd/tps6586x.c | 105 drivers/regulator/tps6586x-regulator.c

[RFC v2 1/5] iommu: Include linux/types.h

2012-04-25 Thread Thierry Reding
The linux/iommu.h header uses types defined in linux/types.h but doesn't include it. Signed-off-by: Thierry Reding --- include/linux/iommu.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index d937580..2b2fcdb 100644 --- a/include/linux/iomm

[RFC v2 0/5] Add NVIDIA Tegra DRM support

2012-04-25 Thread Thierry Reding
This series adds a basic DRM driver for NVIDIA Tegra 2 processors. It currently only supports the RGB output and I've successfully tested it against the fbcon kernel module and the xf86-video-modesetting driver. The code uses the Tegra's IOMMU/GART to remap non-contiguous memory. This means that cu

[RFC v2 4/5] drm: fixed: Add dfixed_frac

2012-04-25 Thread Thierry Reding
From: Robert Morell This helper macro retrieves the fractional part of a fixed20_12 20.12 fixed-point number. Signed-off-by: Robert Morell Signed-off-by: Olof Johansson Signed-off-by: Thierry Reding --- include/drm/drm_fixed.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/dr

[RFC v2 3/5] i2c: Add of_i2c_get_adapter() function

2012-04-25 Thread Thierry Reding
This function resolves an OF device node to an I2C adapter registered with the I2C core. Signed-off-by: Thierry Reding --- drivers/i2c/i2c-core.c | 34 ++ include/linux/of_i2c.h |7 +++ 2 files changed, 41 insertions(+) diff --git a/drivers/i2c/i2c-core