Re: [PATCH 1/2] dt-bindings: iommu: Add binding for MediaTek MT8167 IOMMU

2020-01-08 Thread Rob Herring
On Fri, 3 Jan 2020 17:26:31 +0100, Fabien Parent wrote: > This commit adds IOMMU binding documentation for the MT8167 SoC. > > Signed-off-by: Fabien Parent > --- > Documentation/devicetree/bindings/iommu/mediatek,iommu.txt | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v2 01/19] dt-bindings: mediatek: Add bindings for MT6779

2020-01-06 Thread Rob Herring
On Sun, 5 Jan 2020 18:45:05 +0800, Chao Hao wrote: > This patch adds description for MT6779 IOMMU. > > MT6779 has two iommus, they are MM_IOMMU and APU_IOMMU which > use ARM Short-Descriptor translation format. > > The MT6779 IOMMU hardware diagram is as below, it is only a brief > diagram about

Re: [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant

2019-12-03 Thread Rob Herring
mmu/arm,smmu.yaml | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v4 8/8] linux/log2.h: Use roundup/dow_pow_two() on 64bit calculations

2019-12-03 Thread Rob Herring
drivers/acpi/arm64/iort.c| 2 +- > drivers/net/ethernet/mellanox/mlx4/en_clock.c| 3 ++- > drivers/of/device.c | 3 ++- In any case, Acked-by: Rob Herring > drivers/pci/controller/cadence/pcie-cadence-ep.c | 3 ++- > drivers/pci/con

Re: [PATCH] of: property: Add device link support for "iommu-map"

2019-11-22 Thread Rob Herring
On Fri, Nov 22, 2019 at 10:13 AM Ard Biesheuvel wrote: > > On Fri, 22 Nov 2019 at 17:01, Rob Herring wrote: > > > > On Fri, Nov 22, 2019 at 8:55 AM Will Deacon wrote: > > > > > > [+Ard] > > > > > > Hi Rob, > > > > > > On

Re: [PATCH] of: property: Add device link support for "iommu-map"

2019-11-22 Thread Rob Herring
On Fri, Nov 22, 2019 at 8:55 AM Will Deacon wrote: > > [+Ard] > > Hi Rob, > > On Fri, Nov 22, 2019 at 08:47:46AM -0600, Rob Herring wrote: > > On Wed, Nov 20, 2019 at 1:00 PM Will Deacon wrote: > > > > > > Commit 8e12257dead7 ("of: property: A

Re: [PATCH] of: property: Add device link support for "iommu-map"

2019-11-22 Thread Rob Herring
I devices can be deferred until after the IOMMU is > available. > > Cc: Greg Kroah-Hartman > Cc: Rob Herring > Cc: Saravana Kannan > Cc: Robin Murphy > Signed-off-by: Will Deacon > --- > > Applies against driver-core/driver-core-next. > Tested on AMD Seattle

Re: [RESEND,PATCH 01/13] dt-bindings: mediatek: Add bindings for MT6779

2019-11-06 Thread Rob Herring
d-off-by: Chao Hao > --- > .../bindings/iommu/mediatek,iommu.txt | 2 + > include/dt-bindings/memory/mt6779-larb-port.h | 217 ++ > 2 files changed, 219 insertions(+) > create mode 100644 include/dt-bindings/memory/mt6779-larb-port.h > Reviewed-by

Re: [PATCH v2] dt-bindings: iommu: Convert Arm SMMUv3 to DT schema

2019-11-01 Thread Rob Herring
On Fri, Nov 1, 2019 at 12:08 PM Will Deacon wrote: > > Hi Rob, > > On Mon, Oct 14, 2019 at 02:12:56PM -0500, Rob Herring wrote: > > Convert the Arm SMMv3 binding to the DT schema format. > > > > Cc: Joerg Roedel > > Cc: Mark Rutland > > Cc: Will D

Re: [PATCH 7/7] iommu/arm-smmu: Allow building as a module

2019-10-30 Thread Rob Herring
On Wed, Oct 30, 2019 at 02:51:12PM +, Will Deacon wrote: > By conditionally dropping support for the legacy binding and exporting > the newly introduced 'arm_smmu_impl_init()' function we can allow the > ARM SMMU driver to be built as a module. > > Signed-off-by: Will Deacon > --- >

Re: [PATCH v2] dt-bindings: iommu: Convert Arm SMMUv3 to DT schema

2019-10-22 Thread Rob Herring
On Tue, Oct 22, 2019 at 11:54 AM Robin Murphy wrote: > > On 14/10/2019 20:12, Rob Herring wrote: > > Convert the Arm SMMv3 binding to the DT schema format. > > > > Cc: Joerg Roedel > > Cc: Mark Rutland > > Cc: Will Deacon > > Cc: Robin Murphy

[PATCH v2] dt-bindings: iommu: Convert Arm SMMUv3 to DT schema

2019-10-14 Thread Rob Herring
Convert the Arm SMMv3 binding to the DT schema format. Cc: Joerg Roedel Cc: Mark Rutland Cc: Will Deacon Cc: Robin Murphy Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- v2: - Refine interrupt definition based on Robin's comments .../devicetree/bindings/iommu/arm,smmu

Re: [PATCH] dt-bindings: iommu: ipmmu-vmsa: Add r8a774b1 support

2019-10-02 Thread Rob Herring
On Tue, 24 Sep 2019 08:40:54 +0100, Biju Das wrote: > Document RZ/G2N (R8A774B1) SoC bindings. > > Signed-off-by: Biju Das > --- > Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

Re: [PATCH v2 3/3] iommu/io-pgtable-arm: Allow coherent walks for Mali

2019-09-30 Thread Rob Herring
--- > drivers/iommu/io-pgtable-arm.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 2/3] iommu/io-pgtable-arm: Support all Mali configurations

2019-09-30 Thread Rob Herring
Neil Armstrong > Reviewed-by: Steven Price > Signed-off-by: Robin Murphy > --- > drivers/iommu/io-pgtable-arm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 1/3] iommu/io-pgtable-arm: Correct Mali attributes

2019-09-30 Thread Rob Herring
+++- > 1 file changed, 40 insertions(+), 13 deletions(-) Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 2/2] dt-bindings: iommu: Convert Arm SMMUv3 to DT schema

2019-09-20 Thread Rob Herring
On Fri, Sep 20, 2019 at 9:17 AM Robin Murphy wrote: > > On 20/09/2019 14:48, Rob Herring wrote: > > Convert the Arm SMMv3 binding to the DT schema format. > > > > Cc: Joerg Roedel > > Cc: Mark Rutland > > Cc: Will Deacon > > Cc: Robin Murphy > >

[PATCH 1/2] dt-bindings: iommu: Convert Arm SMMU to DT schema

2019-09-20 Thread Rob Herring
This issue remains. Cc: Joerg Roedel Cc: Mark Rutland Cc: Will Deacon Cc: Robin Murphy Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- .../devicetree/bindings/iommu/arm,smmu.txt| 182 -- .../devicetree/bindings/iommu/arm,smmu.yaml | 229 +

[PATCH 2/2] dt-bindings: iommu: Convert Arm SMMUv3 to DT schema

2019-09-20 Thread Rob Herring
Convert the Arm SMMv3 binding to the DT schema format. Cc: Joerg Roedel Cc: Mark Rutland Cc: Will Deacon Cc: Robin Murphy Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- .../devicetree/bindings/iommu/arm,smmu-v3.txt | 77 - .../bindings/iommu/arm,smmu-v3

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

2019-09-13 Thread Rob Herring
On Sat, 24 Aug 2019 15:28:46 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= wrote: > Referencing device tree nodes from a property allows to pass arguments. > This is for example used for referencing gpios. This looks as follows: > > gpio_ctrl: gpio-controller { >

Re: [PATCH v2] PCI: Remove unused includes and superfluous struct declaration

2019-09-03 Thread Rob Herring
| 1 + > include/linux/of_pci.h| 5 ++--- > 9 files changed, 11 insertions(+), 3 deletions(-) Reviewed-by: Rob Herring

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

2019-09-02 Thread Rob Herring
On Sat, Aug 24, 2019 at 03:28:46PM +0200, Uwe Kleine-König wrote: > Referencing device tree nodes from a property allows to pass arguments. > This is for example used for referencing gpios. This looks as follows: > > gpio_ctrl: gpio-controller { > #gpio-cells = <2> >

Re: [PATCH] PCI: Remove unused includes and superfluous struct declaration

2019-09-02 Thread Rob Herring
| 1 + > drivers/pci/pci.c | 1 + > drivers/pci/probe.c | 1 + > include/linux/of_pci.h| 4 +--- > 6 files changed, 7 insertions(+), 3 deletions(-) > Acked-by: Rob Herring __

Re: [PATCH 1/2] iommu: Implement of_iommu_get_resv_regions()

2019-09-02 Thread Rob Herring
a given device. These > regions will be used to create 1:1 mappings in the IOMMU domain that > the devices will be attached to. > > Cc: Rob Herring > Cc: Frank Rowand > Cc: devicet...@vger.kernel.org > Signed-off-by: Thierry Reding &g

Re: [PATCH 2/7] dt-bindings: arm-smmu: Add Adreno GPU variant

2019-08-27 Thread Rob Herring
.txt | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 03/11] of/fdt: add of_fdt_machine_is_compatible function

2019-08-20 Thread Rob Herring
tic const int __init of_fdt_machine_is_compatible(char *name) No point in const return (though name could possibly be const), and the return could be bool instead. With that, Reviewed-by: Rob Herring > +{ > + unsigned long dt_root = of_get_flat_dt_r

Re: [PATCH v2 04/11] of/fdt: add early_init_dt_get_dma_zone_size()

2019-08-20 Thread Rob Herring
te.h" > > @@ -1195,6 +1196,12 @@ void __init early_init_dt_scan_nodes(void) > of_scan_flat_dt(early_init_dt_scan_memory, NULL); > } > > +void __init early_init_dt_get_dma_zone_size(void) static With that, Reviewed-by: Rob Herring > +{ > + if (of_fdt_machine_is

Re: [PATCH 3/8] of/fdt: add function to get the SoC wide DMA addressable memory size

2019-08-08 Thread Rob Herring
On Tue, Aug 6, 2019 at 12:12 PM Nicolas Saenz Julienne wrote: > > Hi Rob, > > On Mon, 2019-08-05 at 13:23 -0600, Rob Herring wrote: > > On Mon, Aug 5, 2019 at 10:03 AM Nicolas Saenz Julienne > > wrote: > > > Hi Rob, > > > Thanks for the review! > >

Re: [PATCH 3/8] of/fdt: add function to get the SoC wide DMA addressable memory size

2019-08-05 Thread Rob Herring
On Mon, Aug 5, 2019 at 10:03 AM Nicolas Saenz Julienne wrote: > > Hi Rob, > Thanks for the review! > > On Fri, 2019-08-02 at 11:17 -0600, Rob Herring wrote: > > On Wed, Jul 31, 2019 at 9:48 AM Nicolas Saenz Julienne > > wrote: > > > Some SoCs might have multip

Re: [PATCH 3/8] of/fdt: add function to get the SoC wide DMA addressable memory size

2019-08-02 Thread Rob Herring
On Wed, Jul 31, 2019 at 9:48 AM Nicolas Saenz Julienne wrote: > > Some SoCs might have multiple interconnects each with their own DMA > addressing limitations. This function parses the 'dma-ranges' on each of > them and tries to guess the maximum SoC wide DMA addressable memory > size. > > This

Re: [PATCH v2 3/4] dt-bindings: iommu/arm,smmu: add compatible string for Marvell

2019-07-24 Thread Rob Herring
ementation of Marvell, this compatible is used for errata only. > > Signed-off-by: Hanna Hawa > Signed-off-by: Gregory CLEMENT > --- > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring

Re: [RFC PATCH] iommu: io-pgtable: Drop WARN for empty PTEs on unmap

2019-07-11 Thread Rob Herring
On Thu, Jul 11, 2019 at 4:23 AM Will Deacon wrote: > > On Wed, Jul 10, 2019 at 04:31:19PM -0600, Rob Herring wrote: > > If a region has been mapped sparsely (such as on page faults), the user > > has to keep track of what was mapped or not in order to avoid warnings > > w

[RFC PATCH] iommu: io-pgtable: Drop WARN for empty PTEs on unmap

2019-07-10 Thread Rob Herring
Roedel Cc: linux-arm-ker...@lists.infradead.org Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- This is needed for large (up to 1GB AIUI) scratch buffers on panfrost which are mapped on demand on GPU page faults and can be unmapped on memory pressure. Alternatively, I'd need

Re: [PATCH v1 01/22] docs: Documentation/*.txt: rename all ReST files to *.rst

2019-07-09 Thread Rob Herring
gt; crc32.rst}| 2 + > Documentation/{dcdbas.txt => dcdbas.rst} | 2 + > ...ging-modules.txt => debugging-modules.rst} | 2 + > ...hci1394.txt => debugging-via-ohci1394.rst} | 2 + > Documentation/{dell_rbu.txt => dell_rbu.rst} | 3 +- > Docum

Re: [PATCH v2] driver: core: Allow subsystems to continue deferring probe

2019-06-13 Thread Rob Herring
| 19 ++- > drivers/base/power/domain.c | 2 +- > drivers/iommu/of_iommu.c | 2 +- > drivers/pinctrl/devicetree.c | 9 +---- > include/linux/device.h | 18 +- > 5 files changed, 38 insertions(+), 12 deletions(-) Acked-by: Rob Herring

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-05-22 Thread Rob Herring
On Wed, May 22, 2019 at 2:41 PM Clément Péron wrote: > > Hi Rob, > > On Wed, 22 May 2019 at 21:27, Rob Herring wrote: > > > > On Tue, May 21, 2019 at 11:11 AM Clément Péron wrote: > > > > > > Hi, > > > > > > The Allwinner H6 ha

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-05-22 Thread Rob Herring
G. > > I'm pushing it in case someone want to continue the work. > > This has been tested with Mesa3D 19.1.0-RC2 and a GPU bitness patch[1]. > > One patch is from Icenowy Zheng where I changed the order as required > by Rob Herring[2]. > > Thanks, > Clement > &

Re: [PATCH v5 1/6] drm: panfrost: add optional bus_clock

2019-05-17 Thread Rob Herring
On Fri, May 17, 2019 at 5:08 PM Clément Péron wrote: > > Hi Rob, > > On Fri, 17 May 2019 at 22:07, Rob Herring wrote: > > > > On Fri, May 17, 2019 at 1:47 PM Clément Péron wrote: > > > > > > Allwinner H6 has an ARM Mali-T720 MP2 which required a bus_cl

Re: [RFC/PATCH 1/4] of: Export of_phandle_iterator_args() to modules

2019-05-17 Thread Rob Herring
On Fri, May 17, 2019 at 1:48 PM Isaac J. Manjarres wrote: > > Kernel modules may want to use of_phandle_iterator_args(), > so export it. > > Signed-off-by: Isaac J. Manjarres > --- > drivers/of/base.c | 1 + > 1 file changed, 1 insertion(+

Re: [PATCH v5 1/6] drm: panfrost: add optional bus_clock

2019-05-17 Thread Rob Herring
On Fri, May 17, 2019 at 1:47 PM Clément Péron wrote: > > Allwinner H6 has an ARM Mali-T720 MP2 which required a bus_clock. > > Add an optional bus_clock at the init of the panfrost driver. > > Signed-off-by: Clément Péron > --- > drivers/gpu/drm/panfrost/panfrost_device.c | 25

[PATCH v3 1/3] iommu: io-pgtable: Add ARM Mali midgard MMU page table format

2019-04-09 Thread Rob Herring
Acked-by: Alyssa Rosenzweig Signed-off-by: Rob Herring --- This is really v4 of the patch. v3 is the series version. Joerg, please ack so we can take this via the drm tree. v3: - Incorporated refactoring from Robin drivers/iommu/io-pgtable-arm.c | 91 ++ drivers

[PATCH v3 0/3] Initial Panfrost driver

2019-04-09 Thread Rob Herring
. A git branch is here[1]. Rob [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git panfrost-rebase-v3 Rob Herring (3): iommu: io-pgtable: Add ARM Mali midgard MMU page table format drm: Add a drm_gem_objects_lookup helper drm/panfrost: Add initial panfrost driver MAINTAINERS

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-09 Thread Rob Herring
On Tue, Apr 9, 2019 at 10:56 AM Tomeu Vizoso wrote: > > On Mon, 8 Apr 2019 at 23:04, Rob Herring wrote: > > > > On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > > > > > > On 01/04/2019 08:47, Rob Herring wrote: > > > > This adds the ini

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-08 Thread Rob Herring
On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > > On 01/04/2019 08:47, Rob Herring wrote: > > This adds the initial driver for panfrost which supports Arm Mali > > Midgard and Bifrost family of GPUs. Currently, only the T860 and > > T760 Midgard GPUs have been tested

Re: [PATCH v2 2/3] drm: Add a drm_gem_objects_lookup helper

2019-04-08 Thread Rob Herring
On Mon, Apr 1, 2019 at 10:43 AM Eric Anholt wrote: > > Chris Wilson writes: > > > Quoting Daniel Vetter (2019-04-01 14:06:48) > >> On Mon, Apr 1, 2019 at 9:47 AM Rob Herring wrote: > >> > +{ > >> > + int i, re

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-02 Thread Rob Herring
On Mon, Apr 1, 2019 at 2:12 PM Robin Murphy wrote: > > On 01/04/2019 08:47, Rob Herring wrote: > > This adds the initial driver for panfrost which supports Arm Mali > > Midgard and Bifrost family of GPUs. Currently, only the T860 and > > T760 Midgard GPUs have been tested.

Re: [PATCH v2 2/3] drm: Add a drm_gem_objects_lookup helper

2019-04-01 Thread Rob Herring
On Mon, Apr 1, 2019 at 8:07 AM Daniel Vetter wrote: > > On Mon, Apr 1, 2019 at 9:47 AM Rob Herring wrote: > > > > Similar to the single handle drm_gem_object_lookup(), > > drm_gem_objects_lookup() takes an array of handles and returns an array > > of GEM objects.

[PATCH v3 1/3] iommu: io-pgtable: Add ARM Mali midgard MMU page table format

2019-04-01 Thread Rob Herring
-off-by: Rob Herring --- Please ack this as I need to apply it to the drm-misc tree. Or we need a stable branch with this patch. v3: - Rework arm_lpae_prot_to_pte as written by Robin - Fill in complete register values for TRANSTAB and MEMATTR registers drivers/iommu/io-pgtable-arm.c | 93

[PATCH v2 0/3] Initial Panfrost driver

2019-04-01 Thread Rob Herring
drm-misc or we need a stable branch. A git branch is here[1]. Rob [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git panfrost-rebase-v2 Rob Herring (3): iommu: io-pgtable: Add ARM Mali midgard MMU page table format drm: Add a drm_gem_objects_lookup helper drm/panfrost: Add

[PATCH v2 2/3] drm: Add a drm_gem_objects_lookup helper

2019-04-01 Thread Rob Herring
Similar to the single handle drm_gem_object_lookup(), drm_gem_objects_lookup() takes an array of handles and returns an array of GEM objects. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Rob Herring --- drivers/gpu/drm/drm_gem.c

Re: [PATCH v2] iommu: io-pgtable: Add ARM Mali midgard MMU page table format

2019-03-04 Thread Rob Herring
On Mon, Mar 4, 2019 at 11:31 AM Robin Murphy wrote: > > On 04/03/2019 15:32, Rob Herring wrote: > > On Fri, Mar 1, 2019 at 10:28 AM Robin Murphy wrote: > >> > >> On 27/02/2019 23:22, Rob Herring wrote: > >>> ARM Mali midgard GPU page tables are sim

Re: [PATCH v2] iommu: io-pgtable: Add ARM Mali midgard MMU page table format

2019-03-04 Thread Rob Herring
On Fri, Mar 1, 2019 at 10:28 AM Robin Murphy wrote: > > On 27/02/2019 23:22, Rob Herring wrote: > > ARM Mali midgard GPU page tables are similar to standard 64-bit stage 1 > > page tables, but have a few differences. Add a new format type to > > represent the format. The

[PATCH v2] iommu: io-pgtable: Add ARM Mali midgard MMU page table format

2019-02-27 Thread Rob Herring
-foundation.org Signed-off-by: Rob Herring --- Robin, Hopefully this is what you had in mind. drivers/iommu/io-pgtable-arm.c | 70 +++--- drivers/iommu/io-pgtable.c | 1 + include/linux/io-pgtable.h | 2 + 3 files changed, 59 insertions(+), 14 deletions(-) diff --git

Re: [PATCH] iommu: Add a quirk for ARM Mali midgard MMU

2019-02-26 Thread Rob Herring
On Tue, Feb 26, 2019 at 1:25 PM Robin Murphy wrote: > > Hi Rob, > > On 26/02/2019 18:17, Rob Herring wrote: > > ARM Mali midgard GPUs have a few differences from standard 64-bit > > stage 1 page tables. > > > > The 3rd level page entry bits are

Re: [PATCH v6 01/22] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI

2019-02-18 Thread Rob Herring
diatek,iommu.txt | 30 - > .../memory-controllers/mediatek,smi-common.txt | 12 +- > .../memory-controllers/mediatek,smi-larb.txt | 4 + > include/dt-bindings/memory/mt8183-larb-port.h | 130 > + > 4 files changed, 170 insertions(+), 6 deletions(-) > create mode 100644 include/dt-bindings/memory/mt8183-larb-port.h > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability

2019-02-13 Thread Rob Herring
On Wed, Feb 13, 2019 at 12:24 PM Christoph Hellwig wrote: > > On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote: > > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > index 3607fd2810e4..f8c66a9472a4 100644 > > > --- a/drivers/of/Kconf

Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability

2019-02-12 Thread Rob Herring
On Mon, Feb 11, 2019 at 7:37 AM Christoph Hellwig wrote: > > This API is primarily used through DT entries, but two architectures > and two drivers call it directly. So instead of selecting the config > symbol for random architectures pull it in implicitly for the actual > users. Also rename

Re: [PATCH 03/12] of: mark early_init_dt_alloc_reserved_memory_arch static

2019-02-12 Thread Rob Herring
d_mem.h | 7 --- > 2 files changed, 1 insertion(+), 8 deletions(-) Reviewed-by: Rob Herring Looks like this one isn't a dependency, so I can take it if you want. Rob ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoun

Re: [PATCH 04/12] of: select OF_RESERVED_MEM automatically

2019-02-12 Thread Rob Herring
rpc/Kconfig | 1 - > arch/xtensa/Kconfig | 1 - > drivers/of/Kconfig | 5 ++--- > 7 files changed, 2 insertions(+), 9 deletions(-) Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] iommu: Allow io-pgtable to be used outside of drivers/iommu/

2019-02-05 Thread Rob Herring
On Tue, Feb 5, 2019 at 10:55 AM Christoph Hellwig wrote: > > On Tue, Feb 05, 2019 at 10:37:31AM -0600, Rob Herring wrote: > > Move io-pgtable.h to include/linux/ and export alloc_io_pgtable_ops > > and free_io_pgtable_ops. This enables drivers outside drivers/iommu/ to > >

[PATCH] iommu: Allow io-pgtable to be used outside of drivers/iommu/

2019-02-05 Thread Rob Herring
: Matthias Brugger Cc: Rob Clark Cc: linux-arm-ker...@lists.infradead.org Cc: iommu@lists.linux-foundation.org Cc: linux-media...@lists.infradead.org Cc: linux-arm-...@vger.kernel.org Signed-off-by: Rob Herring --- This will be needed for an in-progress Mali GPU DRM driver. It's using the page table

Re: [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW

2019-01-11 Thread Rob Herring
ediatek-mdp.txt | 8 > Documentation/devicetree/bindings/media/mediatek-vcodec.txt | 4 ---- > 4 files changed, 25 deletions(-) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-04 Thread Rob Herring
On Sat, Dec 1, 2018 at 10:54 AM Rob Clark wrote: > > This solves a problem we see with drm/msm, caused by getting > iommu_dma_ops while we attach our own domain and manage it directly at > the iommu API level: > > [0038] user address but active_mm is swapper > Internal error:

Re: [PATCH v4 3/7] of: Allow the iommu-map property to omit untranslated devices

2018-11-16 Thread Rob Herring
> pci_msi_setup_msi_irqs() will return an error when attempting to find the > device's MSI domain. > > Signed-off-by: Jean-Philippe Brucker > --- > drivers/of/base.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring __

Re: [PATCH v2] of/device: Really only set bus DMA mask when appropriate

2018-11-07 Thread Rob Herring
On Wed, Nov 07, 2018 at 04:30:32PM +, Robin Murphy wrote: > of_dma_configure() was *supposed* to be following the same logic as > acpi_dma_configure() and only setting bus_dma_mask if some range was > specified by the firmware. However, it seems that subtlety got lost in > the process of

Re: [PATCH] of/device: Really only set bus DMA mask when appropriate

2018-11-07 Thread Rob Herring
On Wed, Nov 07, 2018 at 12:56:49PM +, Robin Murphy wrote: > On 2018-11-07 8:03 am, Christoph Hellwig wrote: > > On Tue, Nov 06, 2018 at 11:54:15AM +, Robin Murphy wrote: > > > of_dma_configure() was *supposed* to be following the same logic as > > > acpi_dma_configure() and only setting

Re: [PATCH 3/4] dt-bindings: iommu/arm, smmu: add compatible string for Marvell

2018-10-18 Thread Rob Herring
On Mon, Oct 15, 2018 at 02:11:52PM +0100, Robin Murphy wrote: > On 15/10/18 13:00, han...@marvell.com wrote: > > From: Hanna Hawa > > > > Add specific compatible string for Marvell usage due errata of > > accessing 64bit registers of ARM SMMU, in AP806. > > > > AP806 SOC use the generic

Re: [PATCH v3 2/7] dt-bindings: virtio: Add virtio-pci-iommu node

2018-10-17 Thread Rob Herring
reate mode 100644 Documentation/devicetree/bindings/virtio/iommu.txt > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v3 1/7] dt-bindings: virtio-mmio: Add IOMMU description

2018-10-17 Thread Rob Herring
n. > > Signed-off-by: Jean-Philippe Brucker > --- > .../devicetree/bindings/virtio/mmio.txt | 30 +++ > 1 file changed, 30 insertions(+) One nit, otherwise, Reviewed-by: Rob Herring > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.txt > b/Do

Re: [PATCH v4 1/2] dt-bindings: arm-smmu: Add binding doc for Qcom smmu-500

2018-10-11 Thread Rob Herring
; --- > > Changes since v3: > - Refined language more to state things directly for the bindings >description. > > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring __

Re: [PATCH v4 06/20] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc

2018-09-27 Thread Rob Herring
- > .../memory-controllers/nvidia,tegra20-mc.txt | 27 +-- > 2 files changed, 19 insertions(+), 22 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/iommu/nvidia,tegra20-gart.txt > Reviewed-by: Rob Herring ___

Re: [PATCH v4 06/20] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc

2018-09-27 Thread Rob Herring
On Mon, Sep 24, 2018 at 11:55:30AM +0200, Thierry Reding wrote: > On Mon, Sep 24, 2018 at 03:41:39AM +0300, Dmitry Osipenko wrote: > > Splitting GART and Memory Controller wasn't a good decision that was made > > back in the day. Given that the GART driver wasn't ever been used by > > anything in

Re: [PATCH 13/13] iommu/mediatek: Switch to SPDX license identifier

2018-09-16 Thread Rob Herring
--- > include/soc/mediatek/smi.h| 10 +- > 7 files changed, 7 insertions(+), 63 deletions(-) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 01/13] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI

2018-09-16 Thread Rob Herring
u > --- > .../devicetree/bindings/iommu/mediatek,iommu.txt | 15 ++- > .../memory-controllers/mediatek,smi-common.txt | 11 +- > .../memory-controllers/mediatek,smi-larb.txt | 3 + > include/dt-bindings/memory/mt8183-larb-port.h | 130 > + &

Re: [PATCH v16 4/5] dt-bindings: arm-smmu: Add bindings for qcom,smmu-v2

2018-09-10 Thread Rob Herring
smmu.txt | 39 > ++ > 1 file changed, 39 insertions(+) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 00/21] DT cpu node iterator

2018-09-07 Thread Rob Herring
On Fri, Sep 7, 2018 at 7:54 AM Michal Simek wrote: > > Hi Rob, > > 2018-09-05 21:37 GMT+02:00 Rob Herring : >> >> This series adds an iterator for cpu nodes and converts users over to use >> it or of_get_cpu_node in some cases. This allows us to remove the >>

[PATCH 19/21] iommu: fsl_pamu: use for_each_of_cpu_node iterator

2018-09-05 Thread Rob Herring
Use the for_each_of_cpu_node iterator to iterate over cpu nodes. This has the side effect of defaulting to iterating using "cpu" node names in preference to the deprecated (for FDT) device_type == "cpu". Cc: Joerg Roedel Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob

[PATCH 00/21] DT cpu node iterator

2018-09-05 Thread Rob Herring
more strict by only looking in /cpus child nodes rather than any node with the device_type == cpu. The iterator also honors the status property which is often forgotten. I've only tested on ARM under QEMU and compiled powerpc. Rob Rob Herring (21): of: Add cpu node iterator for_each_of_cpu_node

Re: [Patch v15 4/5] dt-bindings: arm-smmu: Add bindings for qcom, smmu-v2

2018-08-29 Thread Rob Herring
On Wed, Aug 29, 2018 at 6:23 AM Vivek Gautam wrote: > > On Wed, Aug 29, 2018 at 2:05 PM Vivek Gautam > wrote: > > > > Hi Rob, > > > > > > On 8/29/2018 2:04 AM, Rob Herring wrote: > > > On Mon, Aug 27, 2018 at 04:25:50PM +0530, Vivek Gautam w

Re: [Patch v15 4/5] dt-bindings: arm-smmu: Add bindings for qcom,smmu-v2

2018-08-28 Thread Rob Herring
On Mon, Aug 27, 2018 at 04:25:50PM +0530, Vivek Gautam wrote: > Add bindings doc for Qcom's smmu-v2 implementation. > > Signed-off-by: Vivek Gautam > Reviewed-by: Tomasz Figa > Tested-by: Srinivas Kandagatla > --- > > Changes since v14: > - This is a new patch added in v15 after noticing the

Re: [PATCH 2/2] dt-bindings: iommu: ipmmu-vmsa: Add r8a774a1 support

2018-08-20 Thread Rob Herring
pmmu-vmsa.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v3 06/19] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc

2018-08-20 Thread Rob Herring
On Sat, Aug 18, 2018 at 06:54:17PM +0300, Dmitry Osipenko wrote: > Splitting GART and Memory Controller wasn't a good decision that was made > back in the day. Given that the GART driver hasn't ever been used by > anything in the kernel, we decided that it will be better to correct the > mistakes

Re: [PATCH v2 3/3] dts: arm64/sdm845: Add node for qcom,smmu-v2

2018-08-14 Thread Rob Herring
On Wed, Aug 15, 2018 at 01:09:43AM +0530, Vivek Gautam wrote: > Adding Jordan here. > > On Tue, Aug 14, 2018 at 4:19 PM, Robin Murphy wrote: > > Hi Vivek, > > > > On 14/08/18 11:27, Vivek Gautam wrote: > >> > >> Add device node for qcom,smmu-v2 available on sdm845. > >> This smmu is available

Re: [PATCH 1/2] arm64: dts: stratix10: Add Stratix10 SMMU support

2018-08-07 Thread Rob Herring
; arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 30 > ++++++ > 2 files changed, 55 insertions(+) Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC PATCH v1 0/6] Resolve unwanted DMA backing with IOMMU

2018-07-27 Thread Rob Herring
On Fri, Jul 27, 2018 at 8:20 AM Joerg Roedel wrote: > > On Fri, Jul 27, 2018 at 05:10:22PM +0300, Dmitry Osipenko wrote: > > I'm not sure what you guys are meaning by the "firmware", could you > > elaborate > > please? Do you mean the Open Firmware and hence the devicetree or what? > > Yes, I

Re: [PATCH] of/platform: Initialise default DMA masks

2018-07-27 Thread Rob Herring
the dma-mapping tree, and in fact > > move it before the bus_dma_mask changes just to keep a bisectable > > tree. > > Sure, if Rob and Frank are OK with that I don't mind either way. NP. Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 1/3] Docs: dt: arm-smmu: Add optional clock parameter

2018-07-20 Thread Rob Herring
On Fri, Jul 13, 2018 at 11:27:56AM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > Add a clock to the SMMU node bindings. > > Signed-off-by: Thor Thayer > --- > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 16 > 1 file changed, 16 insertions(+) >

Re: [PATCH 1/3] dts: arm64/sdm845: Add node for arm,mmu-500

2018-07-19 Thread Rob Herring
On Thu, Jul 19, 2018 at 11:54 AM Vivek Gautam wrote: > > Add device node for arm,mmu-500 available on sdm845. > This MMU-500 with single TCU and multiple TBU architecture > is shared among all the peripherals except gpu on sdm845. > > Signed-off-by: Vivek Gautam > --- >

Re: [RFC PATCH 0/4] Stop losing firmware-set DMA masks

2018-07-11 Thread Rob Herring
On Tue, Jul 10, 2018 at 12:43 PM Robin Murphy wrote: > > Whilst the common firmware code invoked by dma_configure() initialises > devices' DMA masks according to limitations described by the respective > properties ("dma-ranges" for OF and _DMA/IORT for ACPI), the nature of > the dma_set_mask()

[PATCH v4 5/6] iommu: Remove IOMMU_OF_DECLARE

2018-07-09 Thread Rob Herring
: linux-samsung-...@vger.kernel.org Cc: linux-arm-...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org Cc: devicet...@vger.kernel.org Acked-by: Will Deacon Acked-by: Marek Szyprowski Acked-by: Joerg Roedel Signed-off-by: Rob Herring --- drivers/iommu/arm-smmu-v3.c | 2 -- drivers/iommu

[PATCH v4 4/6] iommu: Stop deferring probe at end of initcalls

2018-07-09 Thread Rob Herring
: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- drivers/iommu/of_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 5c36a8b7656a..78ddf47dd67a 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu

[PATCH v3 5/6] iommu: Remove IOMMU_OF_DECLARE

2018-06-28 Thread Rob Herring
: linux-samsung-...@vger.kernel.org Cc: linux-arm-...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org Cc: devicet...@vger.kernel.org Acked-by: Will Deacon Acked-by: Marek Szyprowski Acked-by: Joerg Roedel Signed-off-by: Rob Herring --- v3: - Also remove linker sections from vmlinux.lds.h

[PATCH v3 4/6] iommu: Stop deferring probe at end of initcalls

2018-06-28 Thread Rob Herring
: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- v3: - Update to new function name drivers/iommu/of_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 5c36a8b7656a..78ddf47dd67a 100644 --- a/drivers

Re: [PATCH v2 1/5] dt-bindings: virtio: Specify #iommu-cells value for a virtio-iommu

2018-06-27 Thread Rob Herring
On Tue, Jun 26, 2018 at 11:59 AM Jean-Philippe Brucker wrote: > > On 25/06/18 20:27, Rob Herring wrote: > > On Thu, Jun 21, 2018 at 08:06:51PM +0100, Jean-Philippe Brucker wrote: > >> A virtio-mmio node may represent a virtio-iommu device. This is discovered > >>

Re: [PATCH v2 1/5] dt-bindings: virtio: Specify #iommu-cells value for a virtio-iommu

2018-06-25 Thread Rob Herring
On Thu, Jun 21, 2018 at 08:06:51PM +0100, Jean-Philippe Brucker wrote: > A virtio-mmio node may represent a virtio-iommu device. This is discovered > by the virtio driver at probe time, but the DMA topology isn't > discoverable and must be described by firmware. For DT the standard IOMMU >

[PATCH v2 7/8] iommu: Remove IOMMU_OF_DECLARE

2018-05-24 Thread Rob Herring
rg Cc: linux-samsung-...@vger.kernel.org Cc: linux-arm-...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org Cc: devicet...@vger.kernel.org Signed-off-by: Rob Herring <r...@kernel.org> --- drivers/iommu/arm-smmu-v3.c| 2 -- drivers/iommu/arm-smmu.c | 7 --- drivers/iommu/exynos-iommu.c

[PATCH v2 6/8] iommu: Stop deferring probe at end of initcalls

2018-05-24 Thread Rob Herring
t;j...@8bytes.org> Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring <r...@kernel.org> --- drivers/iommu/of_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 5c36a8b7656a..2aac8387717c 100644 --- a/d

Re: [PATCH] iommu/ipmmu-vmsa: Document R-Car V3H and E3 IPMMU DT bindings

2018-05-23 Thread Rob Herring
: Magnus Damm <damm+rene...@opensource.se> > --- > > Developed on top of renesas-drivers-2018-05-15-v4.17-rc5 > > Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt |2 ++ > 1 file changed, 2 insertions(+) Acked-by: Rob Herring <r...@kernel.org> ___

Re: [PATCH v4 2/6] iommu: of: make of_pci_map_rid() available for other devices too

2018-05-01 Thread Rob Herring
| 5 +-- > drivers/pci/of.c | 101 -- > include/linux/of.h | 11 + > include/linux/of_pci.h | 10 - > 6 files changed, 117 insertions(+), 117 deletions(-) Reviewed-by: Rob Herring <r...@kernel.org> _

Re: [PATCH v4 2/2] drivers: remove force dma flag from buses

2018-05-01 Thread Rob Herring
; include/linux/device.h| 4 > include/linux/of_device.h | 8 ++-- > 10 files changed, 17 insertions(+), 19 deletions(-) Reviewed-by: Rob Herring <r...@kernel.org> ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

<    1   2   3   4   5   >