On Thu, Jan 25, 2018 at 4:58 PM, Dave Thaler wrote:
> Well if it’s really unfixable then we deprecate the old broken API and add
> a new API that’s not broken.
>
> If this is a recent regression then there may be apps both ways.
>
>
>
OK, so just a JIRA ticket for now? I may be able to figure out
Well if it’s really unfixable then we deprecate the old broken API and add a
new API that’s not broken.
If this is a recent regression then there may be apps both ways.
From: Gregg Reynolds [mailto:d...@mobileink.com]
Sent: Thursday, January 25, 2018 2:55 PM
To: Dave Thaler
Cc: kishen.mal...@int
On Thu, Jan 25, 2018 at 4:48 PM, Dave Thaler wrote:
> Ok, after groveling through a bunch of code to refresh my memory,
> eps->addr should be an IP literal string, not a URL authority component
> string.
>
> So yes it is a bug and the “%25” should be “%” in
> OCMapZoneIdToLinkLocalEndpoint.
>
Al
Ok, after groveling through a bunch of code to refresh my memory, eps->addr
should be an IP literal string, not a URL authority component string.
So yes it is a bug and the “%25” should be “%” in
OCMapZoneIdToLinkLocalEndpoint.
The following places in the code confirm that eps->addr is an IP lit
On Thu, Jan 25, 2018 at 3:37 PM, Dave Thaler wrote:
> Ok I read this thread through again and checked the code and now I
> understand your point.
>
> You’re saying that
>
> OICStrcat(eps->addr, OC_MAX_ADDR_STR_SIZE, "%25");
>
> should be
>
> OICStrcat(eps->addr, OC_MAX_ADDR_STR_SIZE, "%");
>
> in
Ok I read this thread through again and checked the code and now I understand
your point.
You’re saying that
OICStrcat(eps->addr, OC_MAX_ADDR_STR_SIZE, "%25");
should be
OICStrcat(eps->addr, OC_MAX_ADDR_STR_SIZE, "%");
in OCMapZoneIdToLinkLocalEndpoint() because eps->addr should be an IP literal
Instead of reopening IOT-2539 I chose to open a new ticket to move the -Werror
option to the CCFLAGS
https://jira.iotivity.org/browse/IOT-2972 Remove C++ compiler warnings Linux
I have assigned it to myself but anyone interested can try and work on it.
I want to work on it but it may be a while
On Jan 25, 2018 3:11 PM, "Dave Thaler" wrote:
...
So, I get a response to a discovery request. I use one of the eps to
construct a request. This fails, because the EP is percent-encoding. This
is technically wrong, because percent-encoding only applies to literal ipv6
addresses *within* a URL. Th
From: Gregg Reynolds [mailto:d...@mobileink.com]
Sent: Thursday, January 25, 2018 12:39 PM
To: Dave Thaler
Cc: iotivity-dev
Subject: RE: [dev] percent encoding IPv6 endpoints
Further info:
This is a literal ipv6 adsress:
FEDC:BA98:7654:3210:FEDC:BA98:7654:3210
Same embedded *within* a URL:
From: Gregg Reynolds [mailto:d...@mobileink.com]
Sent: Thursday, January 25, 2018 12:27 PM
To: Dave Thaler
Cc: iotivity-dev
Subject: RE: [dev] percent encoding IPv6 endpoints
Hi Dave,
Thanks for taking the time to respond. Comments/questions below.
On Jan 22, 2018 3:51 PM, "Dave Thaler"
ma
Further info:
This is a literal ipv6 adsress:
FEDC:BA98:7654:3210:FEDC:BA98:7654:3210
Same embedded *within* a URL:
http://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80/index.html
If you add zone to the literal, you use %. Add it to the URL and you
must use %25. No?
Anyway the point is that
Hi Dave,
Thanks for taking the time to respond. Comments/questions below.
On Jan 22, 2018 3:51 PM, "Dave Thaler" wrote:
Below
*From:* iotivity-dev-boun...@lists.iotivity.org [mailto:
iotivity-dev-boun...@lists.iotivity.org] *On Behalf Of *Gregg Reynolds
*Sent:* Monday, January 22, 2018 11:3
> So I'd propose for this one file adding a comment to this effect, and them
> adding:
> #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
> That will work for gcc; will there be a problem on rather different compilers
> like Windows when they hit the new deprecation stuff?
I have bee
Welcome Aleksy,
You or Randeep may want to looking to removing Randeep from the ”Security
Maintainers (group)” in gerrit and getting Yourself added to that group. I know
many developers when they are doing anything security related use the “Security
Maintainers (group)” to add reviewers.
Georg
On 01/23/2018 05:01 PM, Nash, George wrote:
> See comments [geo]
thanks, George.
> A. as described in (2), -Werror applies currently only to C code.
> Should this flag be moved to CCFLAGS so it applies to both languages?
>
>
> [geo] I thought the -Werror flag in CFLAGS was also being applied to
15 matches
Mail list logo
