Re: [Ipmitool-devel] missing break at lib/ipmi_sdr.c

2013-01-07 Thread Liebig, Holger
> > Hi, > > The lib/ipmi_sdr.c above comment "/* SR2300, non-redundant, PSx present */" > The missing break is intentional due to redundancy, right? [Liebig, Holger] I would say no, but who knows for sure without Intel documentation about the OEM SDR's in this particular quite old system from

Re: [Ipmitool-devel] code analysis

2013-01-07 Thread Ales Ledvinka
I am not sure where is the misinterpretation on this thread. Could it be the one incorrect word translation when asking for the membership combined with the first post on this thread? The sf hides emails. So sending to the sf mail unless I can see the non-sf email as recognized by active develope

Re: [Ipmitool-devel] missing break at lib/ipmi_sdr.c

2013-01-07 Thread Zdenek Styblik
On Mon, Jan 7, 2013 at 3:02 PM, Ales Ledvinka wrote: > Hi, > > The lib/ipmi_sdr.c above comment "/* SR2300, non-redundant, PSx present */" > The missing break is intentional due to redundancy, right? > Hello, yes, it seems like it(= it is not a bug). One line of comment wouldn't hurt, I'd say(I

[Ipmitool-devel] missing break at lib/ipmi_sdr.c

2013-01-07 Thread Ales Ledvinka
Hi, The lib/ipmi_sdr.c above comment "/* SR2300, non-redundant, PSx present */" The missing break is intentional due to redundancy, right? -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windo

Re: [Ipmitool-devel] code analysis

2013-01-07 Thread Zdenek Styblik
On Mon, Jan 7, 2013 at 12:25 PM, Ales Ledvinka wrote: [...] >> > Then it's about effort to generate the report, >> > effort to check the reported item >> > whether it's security issue or not and effort to fix it. These are >> > not the same thing. >> >> Right. And if you want to do it all behind t

Re: [Ipmitool-devel] code analysis

2013-01-07 Thread Ales Ledvinka
- Original Message - > From: "Zdenek Styblik" > To: "Ales Ledvinka" > Cc: "ipmitool-devel" > Sent: Saturday, January 5, 2013 1:23:03 PM > Subject: Re: [Ipmitool-devel] code analysis > > On Fri, Jan 4, 2013 at 8:10 PM, Ales Ledvinka > wrote: > [...] > > Per issue, file or defect type gr