Re: [Ipmitool-devel] Series 1

2013-04-03 Thread Dan Gora
On Wed, Apr 3, 2013 at 6:40 AM, Zdenek Styblik wrote: > On Tue, Apr 2, 2013 at 9:04 PM, Dan Gora wrote: >> Actually I just remembered another reason why I hate the stdint.h types: >> >> When compiling on Ubuntu 12.10: >> >> ../../lib/ipmi_delloem.c: In function 'ipmi_print_power_consmpt_history':

Re: [Ipmitool-devel] Series 1

2013-04-03 Thread Zdenek Styblik
On Tue, Apr 2, 2013 at 9:04 PM, Dan Gora wrote: > Actually I just remembered another reason why I hate the stdint.h types: > > When compiling on Ubuntu 12.10: > > ../../lib/ipmi_delloem.c: In function 'ipmi_print_power_consmpt_history': > ../../lib/ipmi_delloem.c:4006:13: warning: format '%lld' ex

Re: [Ipmitool-devel] Series 1

2013-04-02 Thread Dan Gora
Actually I just remembered another reason why I hate the stdint.h types: When compiling on Ubuntu 12.10: ../../lib/ipmi_delloem.c: In function 'ipmi_print_power_consmpt_history': ../../lib/ipmi_delloem.c:4006:13: warning: format '%lld' expects argument of type 'long long int', but argument 2 has

Re: [Ipmitool-devel] Series 1

2013-04-01 Thread Zdenek Styblik
On Mon, Apr 1, 2013 at 8:08 PM, Dan Gora wrote: > On Mon, Apr 1, 2013 at 3:04 PM, Zdenek Styblik > wrote: >> On Mon, Apr 1, 2013 at 7:52 PM, Dan Gora wrote: >>> yes because the structure is only 3 bytes long. Recall that a long is >>> 8 bytes on 64 bit machines. An unsigned int is always 4 by

Re: [Ipmitool-devel] Series 1

2013-04-01 Thread Dan Gora
On Mon, Apr 1, 2013 at 3:04 PM, Zdenek Styblik wrote: > On Mon, Apr 1, 2013 at 7:52 PM, Dan Gora wrote: >> yes because the structure is only 3 bytes long. Recall that a long is >> 8 bytes on 64 bit machines. An unsigned int is always 4 bytes (unless >> we're talking about 16 or 8 bit processors

Re: [Ipmitool-devel] Series 1

2013-04-01 Thread Zdenek Styblik
On Mon, Apr 1, 2013 at 7:52 PM, Dan Gora wrote: [...] >> I only noticed this because you changed data from unsigned long to unsigned >> int. > > yes because the structure is only 3 bytes long. Recall that a long is > 8 bytes on 64 bit machines. An unsigned int is always 4 bytes (unless > we're

Re: [Ipmitool-devel] Series 1

2013-04-01 Thread Dan Gora
Hi Jim, (I'm going to cc the ipmitool-devel list so that other people can see your review and we don't have duplicate your work) On Mon, Apr 1, 2013 at 2:24 PM, Jim Mankovich wrote: > Dan, > > Here are a couple of comments/questions on your code changes in this patch > set. I did > not seen an

[Ipmitool-devel] Series 1

2013-03-21 Thread Dan Gora
Here are the patches for the first series. dan -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar ___