[ipxe-devel] [ipxe] Reverts changes to src/net/udp/tftp.c made in commit 76675365271291beb9d... (#33)

2015-01-07 Thread Brandon Penglase
...daeec10da14f4faa55ecc on 02/27/14. This allows tftp to load from a Windows/Microsoft TFTP server. This should also fix pull request #31: https://github.com/ipxe/ipxe/pull/31 Without this, when you try to load from a Windows/Microsoft TFTP server, you get error 3d1260 "Inappropriate I/O control

Re: [ipxe-devel] [ipxe] Reverts changes to src/net/udp/tftp.c made in commit 76675365271291beb9d... (#33)

2015-01-07 Thread Brandon Penglase
For reference, as I didn't noticed it at first, #19 from terryburton also reverts this as well. --- Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/33#issuecomment-69025020___ ipxe-devel mailing list ipxe-devel@lists

Re: [ipxe-devel] [ipxe] Reverts changes to src/net/udp/tftp.c made in commit 76675365271291beb9d... (#33)

2015-01-07 Thread Ben Hildred
> size_t len; > struct io_buffer *iobuf; > size_t blksize; > > + /* Strip initial '/' if present. If we were opened via the > + * URI interface, then there will be an initial '/', since a > + * full tftp:// URI provides no way to specify a non-absolute > + * path

Re: [ipxe-devel] [ipxe] Reverts changes to src/net/udp/tftp.c made in commit 76675365271291beb9d... (#33)

2015-01-07 Thread Christian Nilsson
I think #19 is the more correct revert of 76675365 just as @hildred notes. One must also ask what kind of issues this causes @mcb30 must have had some reason for the change more then just refactoring? And does the URI tests (added in the same commit) still succeed after this is applied? --- Rep

Re: [ipxe-devel] [ipxe] Reverts changes to src/net/udp/tftp.c made in commit 76675365271291beb9d... (#33)

2015-01-07 Thread Brandon Penglase
Closed #33. --- Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/33#event-215467223___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel

Re: [ipxe-devel] [ipxe] Reverts changes to src/net/udp/tftp.c made in commit 76675365271291beb9d... (#33)

2015-01-07 Thread Brandon Penglase
@hildred Good catch, all that is needed is the if statement, as #19 does. Closing this pull request in favor of @terryburton 's #19. Not sure if you meant the comment in the file, or on the commit, but the one in the file is not mine, and was on the original code prior to it being removed. @NiK

Re: [ipxe-devel] [ipxe] Reverts changes to src/net/udp/tftp.c made in commit 76675365271291beb9d... (#33)

2015-01-07 Thread Ben Hildred
We should also close #31 in favor of #19. --- Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/33#issuecomment-69086477___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/i