lerouxrgd commented on PR #1900:
URL: https://github.com/apache/avro/pull/1900#issuecomment-2231224516
I had a quick look at this, is there more to it than simply using
`serde_bytes` on struct fields ?
Something like this patch
```diff
diff --git
martin-g commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2230145022
Thank you, @Gerrit0 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Gerrit0 commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1678646094
##
lang/c++/include/avro/Validator.hh:
##
@@ -35,7 +35,7 @@ public:
explicit NullValidator(const ValidSchema &) {}
Review Comment:
I created
martin-g commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677768902
##
lang/c++/include/avro/Validator.hh:
##
@@ -35,7 +35,7 @@ public:
explicit NullValidator(const ValidSchema &) {}
Review Comment:
1.12 is really close to be
martin-g commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677766834
##
lang/c++/include/avro/buffer/BufferStreambuf.hh:
##
@@ -135,7 +135,11 @@ protected:
memcpy(c, gptr(), toCopy);
c += toCopy;
mkmkme commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677727192
##
lang/c++/include/avro/Validator.hh:
##
@@ -35,7 +35,7 @@ public:
explicit NullValidator(const ValidSchema &) {}
Review Comment:
I think yes. Also let's hear
Gerrit0 commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677724144
##
lang/c++/include/avro/Validator.hh:
##
@@ -35,7 +35,7 @@ public:
explicit NullValidator(const ValidSchema &) {}
Review Comment:
True, I believe the new type
mkmkme commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677721963
##
lang/c++/include/avro/Reader.hh:
##
@@ -176,15 +176,15 @@ private:
return encoded;
}
-int64_t readSize() {
+size_t readSize() {
Review Comment:
Gerrit0 commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677721124
##
lang/c++/include/avro/Reader.hh:
##
@@ -176,15 +176,15 @@ private:
return encoded;
}
-int64_t readSize() {
+size_t readSize() {
Review
mkmkme commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677718795
##
lang/c++/include/avro/buffer/BufferStreambuf.hh:
##
@@ -135,7 +135,11 @@ protected:
memcpy(c, gptr(), toCopy);
c += toCopy;
Gerrit0 commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677716799
##
lang/c++/include/avro/buffer/BufferStreambuf.hh:
##
@@ -135,7 +135,11 @@ protected:
memcpy(c, gptr(), toCopy);
c += toCopy;
Gerrit0 commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677714491
##
lang/c++/test/buffertest.cc:
##
@@ -34,19 +34,18 @@ using detail::kMinBlockSize;
using std::cout;
using std::endl;
+// Make a string of repeating
Fokko commented on PR #3012:
URL: https://github.com/apache/avro/pull/3012#issuecomment-2228310907
@Gerrit0 Thank you, you popped up first, sorry for that. Thanks @Astralidea
much appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message,
Gerrit0 commented on PR #3012:
URL: https://github.com/apache/avro/pull/3012#issuecomment-2228285316
Wasn't me this time - all credit to @Astralidea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mkmkme commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677524359
##
lang/c++/impl/Node.cc:
##
@@ -146,7 +146,7 @@ void Node::setLogicalType(LogicalType logicalType) {
if (type_ == AVRO_FIXED) {
// Max
mkmkme commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677519290
##
lang/c++/impl/Compiler.cc:
##
@@ -395,12 +396,12 @@ static NodePtr makeEnumNode(const Entity ,
static NodePtr makeFixedNode(const Entity ,
mkmkme commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2228003979
> @mkmkme Do you have time to review this PR ?
Yup, thanks for pinging me! I'll do this promptly
--
This is an automated message from the Apache Git Service.
To respond to the
martin-g commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2228002206
@mkmkme Do you have time to review this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fokko commented on PR #3012:
URL: https://github.com/apache/avro/pull/3012#issuecomment-2227851688
Thanks @Gerrit0 for fixing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Gerrit0 commented on code in PR #3012:
URL: https://github.com/apache/avro/pull/3012#discussion_r1677176308
##
lang/java/ipc/src/main/velocity/org/apache/avro/ipc/stats/templates/statsview.vm:
##
@@ -51,7 +51,7 @@
$title
-
Review Comment:
IMO, no.
Gerrit0 commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2227424289
Well, at this point my theory is that the GCC 9.4 used on ARM (vs 11.4 in
the other job and 14.1 on my box) doesn't have a properly constexpr'd
`std::numeric_limits`... for `makeString`
Fokko commented on code in PR #3012:
URL: https://github.com/apache/avro/pull/3012#discussion_r1676940337
##
lang/java/ipc/src/main/velocity/org/apache/avro/ipc/stats/templates/statsview.vm:
##
@@ -51,7 +51,7 @@
$title
-
Review Comment:
Shouldn't we pull these
martin-g commented on code in PR #2976:
URL: https://github.com/apache/avro/pull/2976#discussion_r1675995198
##
lang/rust/avro/src/schema.rs:
##
@@ -3415,16 +3431,16 @@ mod tests {
let schema = Schema::parse_str(raw_schema)?;
assert_eq!(
-
KalleOlaviNiemitalo commented on code in PR #2976:
URL: https://github.com/apache/avro/pull/2976#discussion_r1675986417
##
lang/rust/avro/src/schema.rs:
##
@@ -3415,16 +3431,16 @@ mod tests {
let schema = Schema::parse_str(raw_schema)?;
assert_eq!(
-
jbonofre commented on PR #3017:
URL: https://github.com/apache/avro/pull/3017#issuecomment-146797
@martin-g it's not Mac `sed -i` : `sed -i` is running on Ubuntu inside a
container. The problem is https://github.com/docker/for-mac/issues/6239
Without changing anything, just
martin-g commented on PR #3017:
URL: https://github.com/apache/avro/pull/3017#issuecomment-141534
Could you please try with `sed -i.bak ...` ?
Mac OSX's `sed -i` behaves differently than GNU's `sed -i` when backup
extension is not provided.
--
This is an automated message from the
Gerrit0 commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2221802494
I really wish I understood why different versions of gcc detect different
things... I tried setting up a docker container with the same version used by
CI, but ran into issues getting stuff
martin-g commented on PR #3007:
URL: https://github.com/apache/avro/pull/3007#issuecomment-2221076523
Thank you for the contribution, @CodingAnarchy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
CodingAnarchy commented on PR #3007:
URL: https://github.com/apache/avro/pull/3007#issuecomment-2220842223
@martin-g All makes sense to me. Thanks for your help cleaning it up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jinxidoru commented on PR #3008:
URL: https://github.com/apache/avro/pull/3008#issuecomment-2220705989
> @Gerrit0 I can look into it if you want (I am also the author of PR
introducing fmt)
I spent a little time trying to get it working with format last night but I
was running into
martin-g commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2220619635
The build on linux aarch64 still fails ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Gerrit0 commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2220455660
Hopefully all fixed now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Fokko commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2220403259
Almost there:
```
[ 63%] Building CXX object CMakeFiles/CodecTests.dir/test/CodecTests.cc.o
/home/runner/work/avro/avro/lang/c++/test/CodecTests.cc: In function
‘avro::ValidSchema
Gerrit0 commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2220381084
make has a `-k` flag to do that, unfortunately CMake doesn't have a wrapper
to delegate to the correct one per platform. Since the CI uses makefiles, I've
tried adding `-k` to build.sh,
martin-g commented on PR #3007:
URL: https://github.com/apache/avro/pull/3007#issuecomment-2220337764
@CodingAnarchy Please review
https://github.com/apache/avro/pull/3007/commits/a6fbfe2744a335a7c6cae44ea6f4486c63a18921
--
This is an automated message from the Apache Git Service.
To
martin-g commented on PR #3008:
URL: https://github.com/apache/avro/pull/3008#issuecomment-2220275067
Thank you, @jinxidoru !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
martin-g commented on PR #3008:
URL: https://github.com/apache/avro/pull/3008#issuecomment-2220273571
Actually both @mkmkme and @Gerrit0 approved it! Sorry, I had to scroll ...
:-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
martin-g commented on PR #3008:
URL: https://github.com/apache/avro/pull/3008#issuecomment-2220272199
What should we do with this PR ?
Please use Github UI's `Approve` functionality so we (non-C++ devs) know
that it is good to be merged! Thanks!
--
This is an automated message from
Gerrit0 commented on PR #3008:
URL: https://github.com/apache/avro/pull/3008#issuecomment-2220267426
That'd be awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Fokko commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2219891723
New errors seem to pop up all the time. I'm not too familiar with the C++
build, but it would be good to list all the warnings before exiting the build.
It looks like it is failing on the
mkmkme commented on PR #3008:
URL: https://github.com/apache/avro/pull/3008#issuecomment-2219673463
@Gerrit0 I can look into it if you want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Gerrit0 commented on PR #3008:
URL: https://github.com/apache/avro/pull/3008#issuecomment-2219355666
Before libfmt, avro used boost's format. I've been meaning to look at trying
to use C++20's `` first, and falling back to libfmt if not available,
but haven't gotten around to it yet.
--
jinxidoru commented on PR #3008:
URL: https://github.com/apache/avro/pull/3008#issuecomment-2218302999
@Gerrit0 - Would it be possible to wise to add a cmake option to determine
whether or not to include libfmt? Though I'll admit that I'm a bit unclear how
you could be using the library
CodingAnarchy commented on PR #3007:
URL: https://github.com/apache/avro/pull/3007#issuecomment-2217987034
@martin-g Unfortunately, that log doesn't get fired because `src/writer.rs`
uses `Value#validate_internal` itself in the code that is raising the error I
see:
Gerrit0 commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2217465036
@Fokko hopefully fixed this time! Still can't seem to reproduce this
locally... if this still doesn't fix it, I'll propose a change to the CI
pipeline to print out the GCC version used so I
martin-g commented on PR #3007:
URL: https://github.com/apache/avro/pull/3007#issuecomment-2216805489
Please see
https://github.com/apache/avro/blob/bb5b8429b7bec86a972f2f1f5ae5f18eeef332a7/lang/rust/avro/src/types.rs#L381-L392
--
This is an automated message from the Apache Git Service.
martin-g commented on PR #3008:
URL: https://github.com/apache/avro/pull/3008#issuecomment-2216795737
I like the renaming of `api/` to `include/avro/` !
But I am not sure how much breaking this change is.
// CC @Gerrit0 @mkmkme
--
This is an automated message from the Apache Git
jbonofre commented on PR #3004:
URL: https://github.com/apache/avro/pull/3004#issuecomment-2216544207
@martin-g thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
martin-g commented on PR #3004:
URL: https://github.com/apache/avro/pull/3004#issuecomment-2216542891
Thanks, @jbonofre !
I've just removed them!
Actually the config.yaml was named config.yaml.disabled, so it was not
problematic. Anyway, it is removed now!
--
This is an automated
jbonofre commented on PR #3004:
URL: https://github.com/apache/avro/pull/3004#issuecomment-2216491953
@martin-g thanks ! Indeed I was surprised to see these files on the 1.11
branch but not on main. Let me know if you want me to create a PR to delete
those files.
--
This is an
martin-g commented on PR #3004:
URL: https://github.com/apache/avro/pull/3004#issuecomment-2215305452
Actually those files shouldn't have been committed at all!
I am not sure when and how I added them without noticing.
I'll remove them as soon as I am in front of my dev machine!
Fokko commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2214551217
@Gerrit0 same error, different line:
```
/home/runner/work/avro/avro/lang/c++/impl/Resolver.cc: In member function
‘virtual void avro::EnumParser::parse(avro::Reader&, uint8_t*) const’:
Fokko commented on PR #2816:
URL: https://github.com/apache/avro/pull/2816#issuecomment-2212519051
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
henryf1991 commented on code in PR #2887:
URL: https://github.com/apache/avro/pull/2887#discussion_r1667657527
##
lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectData.java:
##
@@ -802,6 +800,21 @@ private String simpleName(Class c) {
return simpleName;
}
+
ex-ratt commented on code in PR #2887:
URL: https://github.com/apache/avro/pull/2887#discussion_r1667628999
##
lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectData.java:
##
@@ -802,6 +800,21 @@ private String simpleName(Class c) {
return simpleName;
}
+
jbonofre commented on PR #2996:
URL: https://github.com/apache/avro/pull/2996#issuecomment-2211679434
@Fokko do you mind to take a look and merge if it's OK for you ? I'm blocked
due to that on `branch-1.11`.
--
This is an automated message from the Apache Git Service.
To respond to the
jbonofre commented on PR #2998:
URL: https://github.com/apache/avro/pull/2998#issuecomment-2210556087
I found another issue on `main`: the PHP version installed by default now is
8.1 (not 7.4 anymore). I'm doing another PR. Sorry about that.
--
This is an automated message from the
martin-g commented on PR #2954:
URL: https://github.com/apache/avro/pull/2954#issuecomment-2208969749
Thank you, @Johnabell !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
martin-g commented on code in PR #2954:
URL: https://github.com/apache/avro/pull/2954#discussion_r1665674276
##
lang/rust/avro_derive/src/lib.rs:
##
@@ -281,6 +286,29 @@ fn type_to_schema_expr(ty: ) -> Result> {
}
}
+fn default_enum_variant(
+data_enum: ::DataEnum,
martin-g commented on PR #2954:
URL: https://github.com/apache/avro/pull/2954#issuecomment-2208922507
Let me try to address those ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
martin-g commented on PR #2995:
URL: https://github.com/apache/avro/pull/2995#issuecomment-2206257281
Thank you, @spektom !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
martin-g commented on PR #2995:
URL: https://github.com/apache/avro/pull/2995#issuecomment-2206093834
Please don't force push! It is hard to see what change you did to fix the
broken build since the last time.
At the end we do "Squash and merge" anyway so there is only one commit per
spektom commented on PR #2995:
URL: https://github.com/apache/avro/pull/2995#issuecomment-2206083719
@martin-g Can you please review this performance improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Gerrit0 commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1659426311
##
lang/c++/api/LogicalType.hh:
##
@@ -47,17 +47,17 @@ public:
// Precision must be positive and scale must be either positive or zero.
The
// setters will
Gerrit0 commented on PR #2966:
URL: https://github.com/apache/avro/pull/2966#issuecomment-2197837040
Out of curiosity I looked at the other open PRs, I believe this supersedes
#1852 and #2300.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
opwvhk commented on code in PR #2984:
URL: https://github.com/apache/avro/pull/2984#discussion_r1657115871
##
lang/java/avro/src/main/java/org/apache/avro/file/SeekableByteArrayInput.java:
##
@@ -34,8 +35,12 @@ public long length() throws IOException {
@Override
public
rtyley commented on PR #2758:
URL: https://github.com/apache/avro/pull/2758#issuecomment-2189499143
Could this be change be released in a new release of `avro`?
CVE-2024-25710 affects `commons-compress` from version 1.3 through 1.25.0,
so this upgrade to 1.26.0 would be useful!
--
opwvhk commented on code in PR #2967:
URL: https://github.com/apache/avro/pull/2967#discussion_r1651136792
##
lang/java/avro/src/main/java/org/apache/avro/file/DataFileReader.java:
##
@@ -170,7 +171,7 @@ public void seek(long position) throws IOException {
vin =
opwvhk commented on code in PR #2967:
URL: https://github.com/apache/avro/pull/2967#discussion_r1651134309
##
lang/java/avro/src/test/java/org/apache/avro/TestDataFile.java:
##
@@ -221,6 +228,37 @@ private void testSyncDiscovery(CodecFactory codec) throws
IOException {
opwvhk commented on code in PR #2967:
URL: https://github.com/apache/avro/pull/2967#discussion_r1651131137
##
lang/java/avro/src/test/java/org/apache/avro/TestDataFile.java:
##
@@ -221,6 +228,37 @@ private void testSyncDiscovery(CodecFactory codec) throws
IOException {
opwvhk commented on code in PR #2967:
URL: https://github.com/apache/avro/pull/2967#discussion_r1651129635
##
doc/themes/docsy:
##
Review Comment:
Hrm... this was not intended
--
This is an automated message from the Apache Git Service.
To respond to the message,
martin-g commented on PR #2965:
URL: https://github.com/apache/avro/pull/2965#issuecomment-2186397669
Thank you, @jjatria !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
JohnEmhoff commented on PR #2961:
URL: https://github.com/apache/avro/pull/2961#issuecomment-2186368097
Thank you very much @martin-g ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jjatria commented on PR #2965:
URL: https://github.com/apache/avro/pull/2965#issuecomment-2186325634
@martin-g: I've rebased this on main and force pushed without the conflict
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
martin-g commented on PR #2965:
URL: https://github.com/apache/avro/pull/2965#issuecomment-2185881840
There are conflicts in the CHANGES file but I cannot resolve them because we
(the maintainers) do not have permissions to push to your branch.
--
This is an automated message from
martin-g commented on PR #2961:
URL: https://github.com/apache/avro/pull/2961#issuecomment-2185869327
Thank you, @JohnEmhoff !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
martin-g commented on PR #2961:
URL: https://github.com/apache/avro/pull/2961#issuecomment-2185868769
I've approved your account a few days ago but to be able to merge your
improvement I also created AVRO-4007 for you!
--
This is an automated message from the Apache Git Service.
To
martin-g commented on PR #2962:
URL: https://github.com/apache/avro/pull/2962#issuecomment-2185859079
Thank you, @jjatria !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
martin-g commented on code in PR #2961:
URL: https://github.com/apache/avro/pull/2961#discussion_r1648503709
##
lang/rust/avro/src/schema.rs:
##
@@ -902,7 +902,10 @@ impl UnionSchema {
/// Returns true if the any of the variants of this `UnionSchema` is
`Null`.
pub
Fokko commented on code in PR #2955:
URL: https://github.com/apache/avro/pull/2955#discussion_r1642714743
##
pom.xml:
##
@@ -47,23 +47,19 @@
build/avro-doc-${project.version}/api
-0.16.1
Review Comment:
Are these renames required? People might be overriding
martin-g commented on PR #2954:
URL: https://github.com/apache/avro/pull/2954#issuecomment-2173174918
> Looks like the CI failure is related to [this
issue](https://github.com/TedDriggs/darling/issues/293).
Please rebase to latest `main`
--
This is an automated message from the
Johnabell commented on PR #2954:
URL: https://github.com/apache/avro/pull/2954#issuecomment-2173146631
Looks like the CI failure is related to [this
issue](https://github.com/TedDriggs/darling/issues/293).
--
This is an automated message from the Apache Git Service.
To respond to the
Johnabell commented on PR #2954:
URL: https://github.com/apache/avro/pull/2954#issuecomment-2173138221
> > since avro supports both default values on fields and enums
>
> Someone else said the opposite ... I am not sure what to do here.
Based on the [avro
martin-g commented on PR #2954:
URL: https://github.com/apache/avro/pull/2954#issuecomment-2173106032
> since avro supports both default values on fields and enums
Someone else said the opposite ...
I am not sure what to do here.
--
This is an automated message from the Apache
dependabot[bot] commented on PR #2865:
URL: https://github.com/apache/avro/pull/2865#issuecomment-2171047957
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
slachiewicz commented on PR #2865:
URL: https://github.com/apache/avro/pull/2865#issuecomment-2170932442
Superseded by #2955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
martin-g commented on PR #2930:
URL: https://github.com/apache/avro/pull/2930#issuecomment-2167647065
Thank you, @Gerrit0 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
martin-g commented on code in PR #2934:
URL: https://github.com/apache/avro/pull/2934#discussion_r1639547573
##
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java:
##
@@ -101,12 +115,43 @@ private Class getPropAsClass(Schema schema, String prop) {
KalleOlaviNiemitalo commented on code in PR #2934:
URL: https://github.com/apache/avro/pull/2934#discussion_r1639546634
##
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java:
##
@@ -101,12 +115,43 @@ private Class getPropAsClass(Schema schema, String
KalleOlaviNiemitalo commented on code in PR #2934:
URL: https://github.com/apache/avro/pull/2934#discussion_r1639540926
##
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java:
##
@@ -101,12 +115,43 @@ private Class getPropAsClass(Schema schema, String
KalleOlaviNiemitalo commented on code in PR #2934:
URL: https://github.com/apache/avro/pull/2934#discussion_r1639540926
##
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java:
##
@@ -101,12 +115,43 @@ private Class getPropAsClass(Schema schema, String
martin-g commented on code in PR #2934:
URL: https://github.com/apache/avro/pull/2934#discussion_r1639482701
##
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java:
##
@@ -24,12 +24,25 @@
import org.apache.avro.io.ResolvingDecoder;
import
jbonofre commented on PR #2934:
URL: https://github.com/apache/avro/pull/2934#issuecomment-2165884762
@Fokko @martin-g @KalleOlaviNiemitalo I updated the PR. Can you guys please
take a look ? Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message,
martin-g commented on PR #2949:
URL: https://github.com/apache/avro/pull/2949#issuecomment-2165017455
Thank you, @Gerrit0 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mkmkme commented on code in PR #2949:
URL: https://github.com/apache/avro/pull/2949#discussion_r1637755772
##
lang/c++/impl/avrogencpp.cc:
##
@@ -728,28 +719,15 @@ void CodeGen::generate(const ValidSchema ) {
os_ << "#ifndef " << h << "\n";
os_ << "#define " << h <<
martin-g commented on code in PR #2949:
URL: https://github.com/apache/avro/pull/2949#discussion_r1637606433
##
lang/c++/impl/avrogencpp.cc:
##
@@ -728,28 +719,15 @@ void CodeGen::generate(const ValidSchema ) {
os_ << "#ifndef " << h << "\n";
os_ << "#define " << h <<
Gerrit0 commented on PR #2949:
URL: https://github.com/apache/avro/pull/2949#issuecomment-2164211263
@Fokko done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
martin-g commented on PR #2953:
URL: https://github.com/apache/avro/pull/2953#issuecomment-2163035060
Thank you, @jjatria !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Fokko commented on PR #2949:
URL: https://github.com/apache/avro/pull/2949#issuecomment-2162896451
@Gerrit0 Can you rebase now https://github.com/apache/avro/pull/2931 is in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Fokko commented on PR #2919:
URL: https://github.com/apache/avro/pull/2919#issuecomment-2162894537
Thanks again for the review @slachiewicz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
1 - 100 of 1682 matches
Mail list logo
