[jira] [Commented] (CALCITE-3987) Allow addition and subtraction operations between DATE and NUMERIC types.

2020-05-15 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108806#comment-17108806 ] Danny Chen commented on CALCITE-3987: - I thought of 2 ways to solve the problem: 1

[jira] [Commented] (CALCITE-4003) In MaterializationTest, FilterProjectTransposeRule matches with logical and physical convention

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108793#comment-17108793 ] Haisheng Yuan commented on CALCITE-4003: Ah, by the way, to be clear, I was not

[jira] [Commented] (CALCITE-3987) Allow addition and subtraction operations between DATE and NUMERIC types.

2020-05-15 Thread Drew Schmitt (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108777#comment-17108777 ] Drew Schmitt commented on CALCITE-3987: --- Thanks Julian. I like the idea of going

[jira] [Commented] (CALCITE-4003) In MaterializationTest, FilterProjectTransposeRule matches with logical and physical convention

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108738#comment-17108738 ] Haisheng Yuan commented on CALCITE-4003: I am not objecting multiple-convention

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Jinpeng Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108725#comment-17108725 ] Jinpeng Wu commented on CALCITE-3997: - [~rubenql] I also think that physical transf

[jira] [Commented] (CALCITE-4003) In MaterializationTest, FilterProjectTransposeRule matches with logical and physical convention

2020-05-15 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108707#comment-17108707 ] Stamatis Zampetakis commented on CALCITE-4003: -- I'm totally with you [~hyu

[jira] [Commented] (CALCITE-3994) RexSimplify reduce concat calls with constant arguments

2020-05-15 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108699#comment-17108699 ] Stamatis Zampetakis commented on CALCITE-3994: -- [~jbal...@gmail.com] There

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108688#comment-17108688 ] Haisheng Yuan commented on CALCITE-3997: This is not a big issue, we can come u

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108681#comment-17108681 ] Ruben Q L commented on CALCITE-3997: [~hyuan], unfortunately, it is not that simple

[jira] [Updated] (CALCITE-3974) Convert some existing private data fields of AST nodes to be public

2020-05-15 Thread Drew Schmitt (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Drew Schmitt updated CALCITE-3974: -- Summary: Convert some existing private data fields of AST nodes to be public (was: Add some

[jira] [Commented] (CALCITE-3946) Add parser support for MULTISET/SET and VOLATILE modifiers in CREATE TABLE statements

2020-05-15 Thread Drew Schmitt (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108675#comment-17108675 ] Drew Schmitt commented on CALCITE-3946: --- Thanks for the feedback! - I'm intereste

[jira] [Commented] (CALCITE-3946) Add parser support for MULTISET/SET and VOLATILE modifiers in CREATE TABLE statements

2020-05-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108641#comment-17108641 ] Julian Hyde commented on CALCITE-3946: -- Reviewing the PR: * I see you made "babel"

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108613#comment-17108613 ] Xiening Dai commented on CALCITE-3997: -- There's an downside with my approach (than

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108612#comment-17108612 ] Haisheng Yuan commented on CALCITE-3997: [~rubenql] How difficult is it for you

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108581#comment-17108581 ] Ruben Q L commented on CALCITE-3997: Yes, [~xndai], I have the impression that, in

[jira] [Commented] (CALCITE-3994) RexSimplify reduce concat calls with constant arguments

2020-05-15 Thread Jess Balint (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108568#comment-17108568 ] Jess Balint commented on CALCITE-3994: -- that fixes it indeed. however it seems inc

[jira] [Comment Edited] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108529#comment-17108529 ] Xiening Dai edited comment on CALCITE-3997 at 5/15/20, 6:21 PM: -

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108529#comment-17108529 ] Xiening Dai commented on CALCITE-3997: -- I think [~rubenql] has a good point. If Tr

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108433#comment-17108433 ] Haisheng Yuan commented on CALCITE-3997: [~anha] Would you mind testing latest

[jira] [Comment Edited] (CALCITE-3999) Simplify DialectPool implementation using Guava cache

2020-05-15 Thread Jesus Camacho Rodriguez (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108395#comment-17108395 ] Jesus Camacho Rodriguez edited comment on CALCITE-3999 at 5/15/20, 3:40 PM: -

[jira] [Commented] (CALCITE-3999) Simplify DialectPool implementation using Guava cache

2020-05-15 Thread Jesus Camacho Rodriguez (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108395#comment-17108395 ] Jesus Camacho Rodriguez commented on CALCITE-3999: -- Thanks for looking

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108286#comment-17108286 ] Ruben Q L commented on CALCITE-3997: Ok, thanks for the clarification, [~hyuan]. >

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108283#comment-17108283 ] Haisheng Yuan commented on CALCITE-3997: And this only affect subclass of Physi

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108281#comment-17108281 ] Haisheng Yuan commented on CALCITE-3997: Yes, this is expected. I will mark it

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108274#comment-17108274 ] Ruben Q L commented on CALCITE-3997: However, I am bit worried that the introductio

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108262#comment-17108262 ] Ruben Q L commented on CALCITE-3997: Thanks [~hyuan], the quickfix should work fine

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108256#comment-17108256 ] Haisheng Yuan commented on CALCITE-3997: Thanks for confirming, [~rubenql]. As

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108253#comment-17108253 ] Ruben Q L commented on CALCITE-3997: [~hyuan] changing ProjectMergeRule did not wor

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108207#comment-17108207 ] Ruben Q L commented on CALCITE-3997: Thanks for the quick reply [~hyuan], I'll chec

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108201#comment-17108201 ] Haisheng Yuan commented on CALCITE-3997: The can be removed. Can you check? >

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108199#comment-17108199 ] Haisheng Yuan commented on CALCITE-3997: I guess because I add the following to

[jira] [Comment Edited] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108191#comment-17108191 ] Ruben Q L edited comment on CALCITE-3997 at 5/15/20, 11:41 AM: --

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108191#comment-17108191 ] Ruben Q L commented on CALCITE-3997: I observe a potential regression after this ch

[jira] [Commented] (CALCITE-3999) Simplify DialectPool implementation using Guava cache

2020-05-15 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108183#comment-17108183 ] Stamatis Zampetakis commented on CALCITE-3999: -- Adding a Guava cache is al

[jira] [Commented] (CALCITE-3997) Problem with MERGE JOIN: java.lang.AssertionError: cannot merge join: left input is not sorted on left keys

2020-05-15 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108053#comment-17108053 ] Enrico Olivelli commented on CALCITE-3997: -- [~hyuan] I confirm that on current

[jira] [Commented] (CALCITE-3977) RelDecorrelator does not resolve correlation variable with field accesses

2020-05-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108022#comment-17108022 ] Ruben Q L commented on CALCITE-3977: Thanks [~julianhyde], I'll consider your sugge