[
https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189838#comment-17189838
]
Liya Fan commented on CALCITE-4197:
---
[~julianhyde][~danny0405] Thanks for your feedback.
Your
[
https://issues.apache.org/jira/browse/CALCITE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189821#comment-17189821
]
Danny Chen commented on CALCITE-4206:
-
I'm going to merge the PR if there are no more comments in
[
https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189806#comment-17189806
]
Danny Chen commented on CALCITE-4197:
-
+1 to "LogicalProject JOB=$2 SAL=$5", and we can add newline
[
https://issues.apache.org/jira/browse/CALCITE-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189798#comment-17189798
]
Danny Chen commented on CALCITE-4215:
-
I want to share the case of row count from the Flink side,
[
https://issues.apache.org/jira/browse/CALCITE-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189794#comment-17189794
]
Danny Chen commented on CALCITE-4215:
-
Just like you said
"At the end of the day, if the collation
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhishui updated CALCITE-4211:
-
Issue Type: New Feature (was: Bug)
Priority: Major (was: Critical)
> QueryOnOrderByView could
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189754#comment-17189754
]
zhishui commented on CALCITE-4211:
--
yeah, thanks for your idea, I will fix it as a feature.
>
[
https://issues.apache.org/jira/browse/CALCITE-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189748#comment-17189748
]
Vladimir Sitnikov commented on CALCITE-4215:
In other words: I understand how "unknown
[
https://issues.apache.org/jira/browse/CALCITE-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189745#comment-17189745
]
Vladimir Sitnikov commented on CALCITE-4215:
[~julianhyde], I've prepared a PR that makes
[
https://issues.apache.org/jira/browse/CALCITE-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde reassigned CALCITE-4220:
Assignee: Julian Hyde
> In SqlToRelConverter, use RelBuilder for creating Aggregate
>
Julian Hyde created CALCITE-4220:
Summary: In SqlToRelConverter, use RelBuilder for creating
Aggregate
Key: CALCITE-4220
URL: https://issues.apache.org/jira/browse/CALCITE-4220
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-4215:
Labels: pull-request-available (was: )
> Ensure org.apache.calcite.schema.Statistic
[
https://issues.apache.org/jira/browse/CALCITE-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189692#comment-17189692
]
Vladimir Sitnikov commented on CALCITE-4214:
Just a note: I think I would keep the existing
[
https://issues.apache.org/jira/browse/CALCITE-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-4214:
Labels: pull-request-available (was: )
> Make RelDataType.getSqlTypeName non-nullable
>
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-4217:
Labels: pull-request-available (was: )
> Unlock RelCrossType#getFieldCount()
>
[
https://issues.apache.org/jira/browse/CALCITE-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-2040:
Labels: pull-request-available (was: )
> Create adapter for Apache Arrow
>
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Sitnikov updated CALCITE-4217:
---
Description:
Currently RelCrossType#getFieldCount throws an assertion error
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Sitnikov updated CALCITE-4217:
---
Summary: Unlock RelCrossType#getFieldCount() (was: RelCrossType#isStruct
should
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189670#comment-17189670
]
Vladimir Sitnikov edited comment on CALCITE-4217 at 9/2/20, 7:57 PM:
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189683#comment-17189683
]
Vladimir Sitnikov commented on CALCITE-4217:
I fail to realize why is it important that
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189674#comment-17189674
]
Julian Hyde commented on CALCITE-4217:
--
People shouldn't be calling getFieldList on a CrossType.
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189670#comment-17189670
]
Vladimir Sitnikov commented on CALCITE-4217:
{quote}People who are trying to treat a cross
[
https://issues.apache.org/jira/browse/CALCITE-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189672#comment-17189672
]
Julian Hyde commented on CALCITE-4219:
--
Your mistake is trying to use a verification framework.
[
https://issues.apache.org/jira/browse/CALCITE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189669#comment-17189669
]
Vladimir Sitnikov commented on CALCITE-4218:
Ok, let me see what happens if I specify
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189667#comment-17189667
]
Julian Hyde commented on CALCITE-4217:
--
Yes it will do harm. People who are trying to treat a
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189665#comment-17189665
]
Vladimir Sitnikov commented on CALCITE-4217:
Well, field names and field count information
[
https://issues.apache.org/jira/browse/CALCITE-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189654#comment-17189654
]
Vladimir Sitnikov edited comment on CALCITE-4219 at 9/2/20, 7:33 PM:
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189653#comment-17189653
]
Julian Hyde commented on CALCITE-4217:
--
I don't know. It's working, it's not widely used, don't
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189651#comment-17189651
]
Vladimir Sitnikov commented on CALCITE-4217:
An alternative option is to remove {{assert
[
https://issues.apache.org/jira/browse/CALCITE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189649#comment-17189649
]
Julian Hyde commented on CALCITE-4218:
--
All {{RelMetadataQuery}} methods are allowed to return
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189650#comment-17189650
]
Vladimir Sitnikov commented on CALCITE-4217:
Should {{RelCrossType}} override
[
https://issues.apache.org/jira/browse/CALCITE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189648#comment-17189648
]
Vladimir Sitnikov commented on CALCITE-4218:
I mean methods like
[
https://issues.apache.org/jira/browse/CALCITE-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189646#comment-17189646
]
Julian Hyde commented on CALCITE-4219:
--
I propose that we return lists of nullable values, and
[
https://issues.apache.org/jira/browse/CALCITE-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189643#comment-17189643
]
Vladimir Sitnikov commented on CALCITE-4219:
{quote} The other option is to accept that the
[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189641#comment-17189641
]
Julian Hyde commented on CALCITE-4217:
--
No, a cross type is not a struct.
> RelCrossType#isStruct
[
https://issues.apache.org/jira/browse/CALCITE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189640#comment-17189640
]
Julian Hyde commented on CALCITE-4218:
--
You can't make a class non-nullable. I guess you mean a
[
https://issues.apache.org/jira/browse/CALCITE-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189639#comment-17189639
]
Julian Hyde commented on CALCITE-4219:
--
The other option is to accept that the rules are different
Vladimir Sitnikov created CALCITE-4219:
--
Summary: Clarify SqlCall#getOperandList() nullability
Key: CALCITE-4219
URL: https://issues.apache.org/jira/browse/CALCITE-4219
Project: Calcite
Vladimir Sitnikov created CALCITE-4218:
--
Summary: Clarify RelMetadataQuery#RelDistribution nullability
Key: CALCITE-4218
URL: https://issues.apache.org/jira/browse/CALCITE-4218
Project: Calcite
Vladimir Sitnikov created CALCITE-4217:
--
Summary: RelCrossType#isStruct should be true rather than false
Key: CALCITE-4217
URL: https://issues.apache.org/jira/browse/CALCITE-4217
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Sitnikov updated CALCITE-4216:
---
Description: {{getFamily}} is almost always non-nullable, so we should make
that
[
https://issues.apache.org/jira/browse/CALCITE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Sitnikov updated CALCITE-4216:
---
Description: It looks like
> Make
[
https://issues.apache.org/jira/browse/CALCITE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Sitnikov updated CALCITE-4216:
---
Summary: Make org.apache.calcite.rel.type.RelDataType#getFamily
non-nullable
[
https://issues.apache.org/jira/browse/CALCITE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Sitnikov updated CALCITE-4216:
---
Description: (was: Existing code treats RelDataType#getSqlTypeName as
[
https://issues.apache.org/jira/browse/CALCITE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Sitnikov updated CALCITE-4216:
---
Summary: TBD: will be updated later (was: Ensure
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189623#comment-17189623
]
Julian Hyde commented on CALCITE-4211:
--
bq. I have an idea to resolve it if this is quite a
Vladimir Sitnikov created CALCITE-4216:
--
Summary: Ensure
org.apache.calcite.rel.type.RelDataType#getSqlTypeName is non-null
Key: CALCITE-4216
URL: https://issues.apache.org/jira/browse/CALCITE-4216
Vladimir Sitnikov created CALCITE-4215:
--
Summary: Ensure org.apache.calcite.schema.Statistic uses null vs
emptyList appropriately
Key: CALCITE-4215
URL: https://issues.apache.org/jira/browse/CALCITE-4215
[
https://issues.apache.org/jira/browse/CALCITE-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189586#comment-17189586
]
Julian Hyde commented on CALCITE-4214:
--
Makes sense.
> Make RelDataType.getSqlTypeName
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189585#comment-17189585
]
Julian Hyde commented on CALCITE-4211:
--
Your bug implies that there has been a regression. There
[
https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189576#comment-17189576
]
Julian Hyde commented on CALCITE-4197:
--
Looks good. How about reversing the arrows, so that they
Vladimir Sitnikov created CALCITE-4214:
--
Summary: Make RelDataType.getSqlTypeName non-nullable
Key: CALCITE-4214
URL: https://issues.apache.org/jira/browse/CALCITE-4214
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189374#comment-17189374
]
Julian Hyde commented on CALCITE-4199:
--
Yes, we should update the javadoc for
[
https://issues.apache.org/jira/browse/CALCITE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189331#comment-17189331
]
zhishui commented on CALCITE-4198:
--
I have resolve this problem in
[
https://issues.apache.org/jira/browse/CALCITE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-4198:
Labels: pull-request-available (was: )
> Query contains AVG function, materialized view
[
https://issues.apache.org/jira/browse/CALCITE-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ruben Q L updated CALCITE-3920:
---
Fix Version/s: 1.26.0
> Improve ORDER BY computation in Enumerable convention by exploiting LIMIT
[
https://issues.apache.org/jira/browse/CALCITE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ruben Q L updated CALCITE-4208:
---
Fix Version/s: 1.26.0
> Improve metadata row count for Join
> ---
[
https://issues.apache.org/jira/browse/CALCITE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-4199:
Labels: pull-request-available (was: )
> Add nullability annotations to the methods and
[
https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liya Fan updated CALCITE-4197:
--
Attachment: screenshot-5.png
> Provide utility to visualize RelNode plans
>
[
https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189151#comment-17189151
]
Liya Fan commented on CALCITE-4197:
---
New screen shots after accepting [~danny0405] and [~Chunwei
[
https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liya Fan updated CALCITE-4197:
--
Attachment: screenshot-4.png
> Provide utility to visualize RelNode plans
>
[
https://issues.apache.org/jira/browse/CALCITE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189143#comment-17189143
]
Stamatis Zampetakis commented on CALCITE-4213:
--
>From a quick look it seems again a result
Stamatis Zampetakis created CALCITE-4213:
Summary: Druid plans with small intervals should be chosen over
full interval scan plus filter
Key: CALCITE-4213
URL:
[
https://issues.apache.org/jira/browse/CALCITE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ruben Q L reassigned CALCITE-4208:
--
Assignee: Ruben Q L
> Improve metadata row count for Join
>
[
https://issues.apache.org/jira/browse/CALCITE-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189115#comment-17189115
]
Igor Guzenko commented on CALCITE-4207:
---
[~julianhyde] I've updated the test case here and in
[
https://issues.apache.org/jira/browse/CALCITE-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Guzenko updated CALCITE-4207:
--
Description:
*Steps to reproduce: *
Add test to SqlValidatorTest.java
{code:java}
@Test
Stamatis Zampetakis created CALCITE-4212:
Summary: Revisit cost-model to break ties between Enumerable and
Bindable expressions
Key: CALCITE-4212
URL: https://issues.apache.org/jira/browse/CALCITE-4212
[
https://issues.apache.org/jira/browse/CALCITE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189089#comment-17189089
]
Vladimir Sitnikov commented on CALCITE-4199:
{quote}Statistic is an SPI. Users can provide
[
https://issues.apache.org/jira/browse/CALCITE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-4208:
Labels: pull-request-available (was: )
> Improve metadata row count for Join
>
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhishui reassigned CALCITE-4211:
Assignee: zhishui
> QueryOnOrderByView could not pass test
>
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189072#comment-17189072
]
Julian Hyde commented on CALCITE-4211:
--
Sorry I have no time to investigate this.
>
[
https://issues.apache.org/jira/browse/CALCITE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189069#comment-17189069
]
Julian Hyde commented on CALCITE-4199:
--
Please don't change anything without review.
Statistic is
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189065#comment-17189065
]
zhishui commented on CALCITE-4211:
--
I hope to get your confirm and I have an idea to resolve it if
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189062#comment-17189062
]
zhishui commented on CALCITE-4211:
--
when I run this test, it's failing, I this there is no rule about
[
https://issues.apache.org/jira/browse/CALCITE-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189063#comment-17189063
]
Igor Guzenko commented on CALCITE-4207:
---
In one place CURRENT_DATE was represented as
[
https://issues.apache.org/jira/browse/CALCITE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189061#comment-17189061
]
Julian Hyde commented on CALCITE-4209:
--
See comments in {{RelBuilder.empty()}}. We thought of this
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189058#comment-17189058
]
Julian Hyde commented on CALCITE-4211:
--
Is CI failing?
> QueryOnOrderByView could not pass test
>
[
https://issues.apache.org/jira/browse/CALCITE-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189053#comment-17189053
]
Julian Hyde commented on CALCITE-4207:
--
Can you devise a minimal test case? I doubt that
[
https://issues.apache.org/jira/browse/CALCITE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189054#comment-17189054
]
Ruben Q L commented on CALCITE-4208:
I have this new proposal:
{code:java}
selectivity =
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189056#comment-17189056
]
zhishui commented on CALCITE-4211:
--
yeah, it's MaterializedViewSubstitutionVisitorTest.
[
https://issues.apache.org/jira/browse/CALCITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189050#comment-17189050
]
Julian Hyde commented on CALCITE-4211:
--
Is this test in Calcite or elsewhere?
>
zhishui created CALCITE-4211:
Summary: QueryOnOrderByView could not pass test
Key: CALCITE-4211
URL: https://issues.apache.org/jira/browse/CALCITE-4211
Project: Calcite
Issue Type: Bug
[
https://issues.apache.org/jira/browse/CALCITE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188784#comment-17188784
]
Ruben Q L edited comment on CALCITE-4208 at 9/2/20, 7:44 AM:
-
Thanks for
[
https://issues.apache.org/jira/browse/CALCITE-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189023#comment-17189023
]
Jiatao Tao commented on CALCITE-4131:
-
Hi Haisheng, how do these errors occur? Can you give a
[
https://issues.apache.org/jira/browse/CALCITE-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-4207:
Labels: pull-request-available (was: )
> Validation fails for positional aggregate with
85 matches
Mail list logo
