[jira] [Commented] (CALCITE-5917) Comments in TimeString class are incorrect

2023-08-10 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753048#comment-17753048 ] Benchao Li commented on CALCITE-5917: - We would accept such minor changes, e.g., improving

[jira] [Commented] (CALCITE-5564) Add parsing and validation for PERCENTILE_CONT/PERCENTILE_DISC functions (enabled in BigQuery)

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753029#comment-17753029 ] Ran Tao commented on CALCITE-5564: -- [~tanclary] hi, tanner, what do you think about

[jira] [Commented] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753027#comment-17753027 ] Ran Tao commented on CALCITE-5909: -- [~shenlang] yes. i have noticed this commit either. however i

[jira] [Commented] (CALCITE-5907) Unexpected boolean expression simplification for And expression

2023-08-10 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753026#comment-17753026 ] Yunhong Zheng commented on CALCITE-5907: Hi, [~kgyrtkirk] and [~jhyde]. Sorry for the late

[jira] [Commented] (CALCITE-5880) When the association condition of the association subquery is 'is not distinct from', the join condition becomes '=' after decorrelation.

2023-08-10 Thread LakeShen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753024#comment-17753024 ] LakeShen commented on CALCITE-5880: --- I thought about this earlier when I debug, the null case is a

[jira] [Commented] (CALCITE-5743) Query gives incorrect result when COUNT appears in the correlated subquery select list

2023-08-10 Thread libopeng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753023#comment-17753023 ] libopeng commented on CALCITE-5743: --- [~shenlang]  {code:java} select EMPNO from emp where EMPNO in

[jira] [Updated] (CALCITE-5880) When the association condition of the association subquery is 'is not distinct from', the join condition becomes '=' after decorrelation.

2023-08-10 Thread libopeng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] libopeng updated CALCITE-5880: -- Description: {code:java} select EMPNO from emp where EXISTS (select DEPTNO from dept where

[jira] [Commented] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread LakeShen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753019#comment-17753019 ] LakeShen commented on CALCITE-5909: --- Hi [~taoran] ,thank you so much for going so deep into this

[jira] [Commented] (CALCITE-5880) When the association condition of the association subquery is 'is not distinct from', the join condition becomes '=' after decorrelation.

2023-08-10 Thread libopeng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753014#comment-17753014 ] libopeng commented on CALCITE-5880: --- I think the problem is caused by decorrelation > When the

[jira] [Commented] (CALCITE-5880) When the association condition of the association subquery is 'is not distinct from', the join condition becomes '=' after decorrelation.

2023-08-10 Thread libopeng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753013#comment-17753013 ] libopeng commented on CALCITE-5880: --- [~shenlang] I doubt this fault caused by this filter condition.

[jira] [Resolved] (CALCITE-5885) SqlNode#toSqlString() does not honor dialect's supportsCharSet() flag on nested types

2023-08-10 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-5885. - Fix Version/s: 1.36.0 Resolution: Fixed > SqlNode#toSqlString() does not honor

[jira] [Commented] (CALCITE-5885) SqlNode#toSqlString() does not honor dialect's supportsCharSet() flag on nested types

2023-08-10 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753012#comment-17753012 ] Jiajun Xie commented on CALCITE-5885: - Fixed in

[jira] [Commented] (CALCITE-5906) RelToSqlConverter throw AssertionError when RelNode tree has the Sample RelNode

2023-08-10 Thread LakeShen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753009#comment-17753009 ] LakeShen commented on CALCITE-5906: ---  In CALCITE-5895, we will change the samplePercentage(float) to

[jira] [Created] (CALCITE-5917) Comments in TimeString class are incorrect

2023-08-10 Thread Mihai Budiu (Jira)
Mihai Budiu created CALCITE-5917: Summary: Comments in TimeString class are incorrect Key: CALCITE-5917 URL: https://issues.apache.org/jira/browse/CALCITE-5917 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-5895) TABLESAMPLE(0) should return empty result

2023-08-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752906#comment-17752906 ] Julian Hyde commented on CALCITE-5895: -- I have reviewed again. As I said in the PR, can you change

[jira] [Updated] (CALCITE-5912) Add an implementation of TABLESAMPLE in Enumerable convention

2023-08-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5912: - Summary: Add an implementation of TABLESAMPLE in Enumerable convention (was: Add an

[jira] [Updated] (CALCITE-5895) TABLESAMPLE(0) should return empty result

2023-08-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5895: - Summary: TABLESAMPLE(0) should return empty result (was: The result of table sample rate 0

[jira] [Created] (CALCITE-5916) In RelBuilder, add sample() method (equivalent to SQL TABLESAMPLE clause)

2023-08-10 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5916: Summary: In RelBuilder, add sample() method (equivalent to SQL TABLESAMPLE clause) Key: CALCITE-5916 URL: https://issues.apache.org/jira/browse/CALCITE-5916 Project:

[jira] [Comment Edited] (CALCITE-5910) Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

2023-08-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752889#comment-17752889 ] Julian Hyde edited comment on CALCITE-5910 at 8/10/23 5:39 PM: --- We need

[jira] [Commented] (CALCITE-5910) Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

2023-08-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752889#comment-17752889 ] Julian Hyde commented on CALCITE-5910: -- We need to make a decision whether or not to use re2, and

[jira] [Commented] (CALCITE-5858) Add REGEXP_CONTAINS, REGEXP_EXTRACT, REGEXP_EXTRACT_ALL, REGEXP_INSTR, REGEXP_REPLACE and REGEXP_SUBSTR functions (enabled in BigQuery library)

2023-08-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752888#comment-17752888 ] Julian Hyde commented on CALCITE-5858: -- Depending on how the discussion of re2 vs java regexp

[jira] [Updated] (CALCITE-5914) Cache compiled regular expressions in SQL function runtime

2023-08-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5914: - Description: Cache compiled regular expressions (and other amortized work) in SQL function

[jira] [Updated] (CALCITE-5914) Cache compiled regular expressions in SQL function runtime

2023-08-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5914: - Description: Cache compiled regular expressions (and other amortized work) in SQL function

[jira] [Updated] (CALCITE-5915) Missing SQL hints in not-expanded subqueries.

2023-08-10 Thread Vladimir Steshin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated CALCITE-5915: -- Description: Not sure if it is a bug becuase the query plans in this case might not

[jira] [Updated] (CALCITE-5915) Missing SQL hints in not-expanded subqueries.

2023-08-10 Thread Vladimir Steshin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated CALCITE-5915: -- Description: Not sure if it is a bug becuase the query plans in this case might not

[jira] [Updated] (CALCITE-5915) Missing SQL hints in not-expanded subqueries.

2023-08-10 Thread Vladimir Steshin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated CALCITE-5915: -- Description: Not sure if it is a bug becuase the query plans in this case might not

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao edited comment on CALCITE-5909 at 8/10/23 5:05 PM: --- [~thomas.rebele]

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao edited comment on CALCITE-5909 at 8/10/23 4:47 PM: --- [~thomas.rebele]

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao edited comment on CALCITE-5909 at 8/10/23 4:45 PM: --- [~thomas.rebele]

[jira] [Assigned] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao reassigned CALCITE-5909: Assignee: (was: Ran Tao) > Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao edited comment on CALCITE-5909 at 8/10/23 4:12 PM: --- [~thomas.rebele]

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao edited comment on CALCITE-5909 at 8/10/23 3:59 PM: --- [~thomas.rebele]

[jira] [Assigned] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao reassigned CALCITE-5909: Assignee: Ran Tao > Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao edited comment on CALCITE-5909 at 8/10/23 3:57 PM: --- [~thomas.rebele]

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao edited comment on CALCITE-5909 at 8/10/23 3:55 PM: --- [~thomas.rebele]

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao edited comment on CALCITE-5909 at 8/10/23 3:54 PM: --- [~thomas.rebele]

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao edited comment on CALCITE-5909 at 8/10/23 3:54 PM: --- [~thomas.rebele]

[jira] [Updated] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-5909: Labels: pull-request-available (was: ) > Sometimes

[jira] [Commented] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

2023-08-10 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752849#comment-17752849 ] Ran Tao commented on CALCITE-5909: -- [~thomas.rebele] thanks for suggestions. however, this problem is

[jira] [Updated] (CALCITE-5915) Missing SQL hints in not-expanded subqueries.

2023-08-10 Thread Vladimir Steshin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated CALCITE-5915: -- Attachment: SqlHintsInSubqueriesWithDisabledExpanding.java > Missing SQL hints in

[jira] [Updated] (CALCITE-5915) Missing SQL hints in not-expanded subqueries.

2023-08-10 Thread Vladimir Steshin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated CALCITE-5915: -- Attachment: (was: SqlHintsInSubqueriesWithDisabledExpanding.java) > Missing SQL

[jira] [Created] (CALCITE-5915) Missing SQL hints in not-expanded subqueries.

2023-08-10 Thread Vladimir Steshin (Jira)
Vladimir Steshin created CALCITE-5915: - Summary: Missing SQL hints in not-expanded subqueries. Key: CALCITE-5915 URL: https://issues.apache.org/jira/browse/CALCITE-5915 Project: Calcite

[jira] [Updated] (CALCITE-5915) Missing SQL hints in not-expanded subqueries.

2023-08-10 Thread Vladimir Steshin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated CALCITE-5915: -- Attachment: SqlHintsInSubqueriesWithDisabledExpanding.java > Missing SQL hints in

[jira] [Commented] (CALCITE-5880) When the association condition of the association subquery is 'is not distinct from', the join condition becomes '=' after decorrelation.

2023-08-10 Thread LakeShen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752797#comment-17752797 ] LakeShen commented on CALCITE-5880: --- I use this sql to debug : {code:java} select EMPNO from

[jira] [Commented] (CALCITE-5743) Query gives incorrect result when COUNT appears in the correlated subquery select list

2023-08-10 Thread LakeShen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752779#comment-17752779 ] LakeShen commented on CALCITE-5743: --- Hi [~leepb] ,could you give me a sql to reproduce this case

[jira] [Commented] (CALCITE-5184) In parser, allow "LIMIT start, ALL"

2023-08-10 Thread hongyu guo (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752765#comment-17752765 ] hongyu guo commented on CALCITE-5184: - Hi, [~julianhyde] Can you help me review this code again?