[jira] [Commented] (CALCITE-3310) Approximate and exact aggregate calls are recognized as the same during sql-to-rel conversion

[ https://issues.apache.org/jira/browse/CALCITE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919340#comment-16919340 ] Chris Baynes commented on CALCITE-3310: --- I may be wrong here but I seem to remember that the

[jira] [Commented] (CALCITE-3241) Calcite this is a very strange mistake

[ https://issues.apache.org/jira/browse/CALCITE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905076#comment-16905076 ] Chris Baynes commented on CALCITE-3241: --- It looks like you are trying to sum a column that has a

[jira] [Commented] (CALCITE-2157) ClickHouse dialect implementation

[ https://issues.apache.org/jira/browse/CALCITE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887758#comment-16887758 ] Chris Baynes commented on CALCITE-2157: --- Have just rebased this PR and made a couple of

[jira] [Commented] (CALCITE-2305) Invalid casting for some postgres types

[ https://issues.apache.org/jira/browse/CALCITE-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471698#comment-16471698 ] Chris Baynes commented on CALCITE-2305: --- That's a fair point, I've added some comments. > Invalid

[jira] [Commented] (CALCITE-2305) Invalid casting for some postgres types

[ https://issues.apache.org/jira/browse/CALCITE-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468652#comment-16468652 ] Chris Baynes commented on CALCITE-2305: --- PR for the fix is here: 

[jira] [Created] (CALCITE-2305) Invalid casting for some postgres types

Chris Baynes created CALCITE-2305: - Summary: Invalid casting for some postgres types Key: CALCITE-2305 URL: https://issues.apache.org/jira/browse/CALCITE-2305 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-2157) ClickHouse dialect implementation

[ https://issues.apache.org/jira/browse/CALCITE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368179#comment-16368179 ] Chris Baynes commented on CALCITE-2157: --- I've had a look at getting this into the test dataset,

[jira] [Commented] (CALCITE-2157) ClickHouse dialect implementation

[ https://issues.apache.org/jira/browse/CALCITE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351916#comment-16351916 ] Chris Baynes commented on CALCITE-2157: --- I think it would be great to get it into the test vm, and

[jira] [Assigned] (CALCITE-2157) ClickHouse dialect implementation

[ https://issues.apache.org/jira/browse/CALCITE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Baynes reassigned CALCITE-2157: - Assignee: Julian Hyde (was: Chris Baynes) > ClickHouse dialect implementation >

[jira] [Updated] (CALCITE-2157) ClickHouse dialect implementation

[ https://issues.apache.org/jira/browse/CALCITE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Baynes updated CALCITE-2157: -- External issue URL: (was: https://github.com/apache/calcite/pull/618) > ClickHouse dialect

[jira] [Updated] (CALCITE-2157) ClickHouse dialect implementation

[ https://issues.apache.org/jira/browse/CALCITE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Baynes updated CALCITE-2157: -- External issue URL: https://github.com/apache/calcite/pull/618 I have submitted a PR which

[jira] [Created] (CALCITE-2157) ClickHouse dialect implementation

Chris Baynes created CALCITE-2157: - Summary: ClickHouse dialect implementation Key: CALCITE-2157 URL: https://issues.apache.org/jira/browse/CALCITE-2157 Project: Calcite Issue Type: New

[jira] [Commented] (CALCITE-1798) In JDBC adapter, generate dialect-specific SQL for FLOOR operator

[ https://issues.apache.org/jira/browse/CALCITE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311137#comment-16311137 ] Chris Baynes commented on CALCITE-1798: --- [~julianhyde] This was fixed in

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169306#comment-16169306 ] Chris Baynes commented on CALCITE-1913: --- Yup, totally fine with removing Handler. The new way of

[jira] [Commented] (CALCITE-1328) RelBuilder not pushing down jdbc predicates

[ https://issues.apache.org/jira/browse/CALCITE-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161248#comment-16161248 ] Chris Baynes commented on CALCITE-1328: --- We have found a solution to this. The LogicalTables used

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157225#comment-16157225 ] Chris Baynes commented on CALCITE-1940: --- [~julianhyde] I think you mean

[jira] [Commented] (CALCITE-1866) dateTime FLOOR to HOUR cause MySQL connector throw SQLException

[ https://issues.apache.org/jira/browse/CALCITE-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150382#comment-16150382 ] Chris Baynes commented on CALCITE-1866: --- [~wkang] could you push your tests to the branch? I can

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149174#comment-16149174 ] Chris Baynes commented on CALCITE-1940: --- I tried this out with postgres and noticed a problem -

[jira] [Commented] (CALCITE-1895) Substring operator broken for MSSQL

[ https://issues.apache.org/jira/browse/CALCITE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106543#comment-16106543 ] Chris Baynes commented on CALCITE-1895: --- I've updated the PR with the {{throws_}} and

[jira] [Commented] (CALCITE-1895) Substring operator broken for MSSQL

[ https://issues.apache.org/jira/browse/CALCITE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104682#comment-16104682 ] Chris Baynes commented on CALCITE-1895: --- I've created a PR for this:

[jira] [Commented] (CALCITE-1841) Create handlers for Jdbc dialect specific generated sql

[ https://issues.apache.org/jira/browse/CALCITE-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099858#comment-16099858 ] Chris Baynes commented on CALCITE-1841: --- I've had a look through and those changes make sense to

[jira] [Commented] (CALCITE-1841) Create handlers for Jdbc dialect specific generated sql

[ https://issues.apache.org/jira/browse/CALCITE-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096122#comment-16096122 ] Chris Baynes commented on CALCITE-1841: --- Ok, so I've moved things into an unparse subpackage and

[jira] [Commented] (CALCITE-1841) Create handlers for Jdbc dialect specific generated sql

[ https://issues.apache.org/jira/browse/CALCITE-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093708#comment-16093708 ] Chris Baynes commented on CALCITE-1841: --- I've created a PR for this:

[jira] [Created] (CALCITE-1895) Substring operator broken for MSSQL

Chris Baynes created CALCITE-1895: - Summary: Substring operator broken for MSSQL Key: CALCITE-1895 URL: https://issues.apache.org/jira/browse/CALCITE-1895 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-1826) Jdbc dialect specific FLOOR fails when in GROUP BY

[ https://issues.apache.org/jira/browse/CALCITE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074797#comment-16074797 ] Chris Baynes commented on CALCITE-1826: --- I've created a PR that fixes this:

[jira] [Commented] (CALCITE-1841) Create handlers for Jdbc dialect specific generated sql

[ https://issues.apache.org/jira/browse/CALCITE-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073432#comment-16073432 ] Chris Baynes commented on CALCITE-1841: --- I completely agree that the dialect specific translations

[jira] [Commented] (CALCITE-1866) dateTime FLOOR to HOUR cause MySQL connector throw SQLException

[ https://issues.apache.org/jira/browse/CALCITE-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070053#comment-16070053 ] Chris Baynes commented on CALCITE-1866: --- Can confirm that this fix makes sense. Hoping to get

[jira] [Commented] (CALCITE-1841) Create handlers for Jdbc dialect specific generated sql

[ https://issues.apache.org/jira/browse/CALCITE-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050400#comment-16050400 ] Chris Baynes commented on CALCITE-1841: --- bq. Why not do this before unparsing by transforming the

[jira] [Commented] (CALCITE-1840) Date floor is broken when used with reflective schema

[ https://issues.apache.org/jira/browse/CALCITE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049735#comment-16049735 ] Chris Baynes commented on CALCITE-1840: --- This is with the latest version from master > Date floor

[jira] [Created] (CALCITE-1841) Create handlers for Jdbc dialect specific generated sql

Chris Baynes created CALCITE-1841: - Summary: Create handlers for Jdbc dialect specific generated sql Key: CALCITE-1841 URL: https://issues.apache.org/jira/browse/CALCITE-1841 Project: Calcite

[jira] [Commented] (CALCITE-1840) Date floor is broken when used with reflective schema

[ https://issues.apache.org/jira/browse/CALCITE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049134#comment-16049134 ] Chris Baynes commented on CALCITE-1840: --- It's instructive to see how a more complex query fails

[jira] [Created] (CALCITE-1840) Date floor is broken when used with reflective schema

Chris Baynes created CALCITE-1840: - Summary: Date floor is broken when used with reflective schema Key: CALCITE-1840 URL: https://issues.apache.org/jira/browse/CALCITE-1840 Project: Calcite

[jira] [Commented] (CALCITE-1798) In JDBC adapter, generate dialect-specific SQL for FLOOR operator

[ https://issues.apache.org/jira/browse/CALCITE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032794#comment-16032794 ] Chris Baynes commented on CALCITE-1798: --- I'll log another JIRA case with the proposed mechanism.

[jira] [Commented] (CALCITE-1798) In JDBC adapter, generate dialect-specific SQL for FLOOR operator

[ https://issues.apache.org/jira/browse/CALCITE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028329#comment-16028329 ] Chris Baynes commented on CALCITE-1798: --- I've opened a new pull request here for the rest of the

[jira] [Commented] (CALCITE-1798) Jdbc dialect specific datetime floor operators

[ https://issues.apache.org/jira/browse/CALCITE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018852#comment-16018852 ] Chris Baynes commented on CALCITE-1798: --- I've made a first pass at this:

[jira] [Created] (CALCITE-1798) Jdbc dialect specific datetime floor operators

Chris Baynes created CALCITE-1798: - Summary: Jdbc dialect specific datetime floor operators Key: CALCITE-1798 URL: https://issues.apache.org/jira/browse/CALCITE-1798 Project: Calcite Issue

[jira] [Commented] (CALCITE-1793) Allow RelBuilder to make calls to EXTRACT

[ https://issues.apache.org/jira/browse/CALCITE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014438#comment-16014438 ] Chris Baynes commented on CALCITE-1793: --- After taking another look at this I've realised it could

[jira] [Updated] (CALCITE-1793) Allow RelBuilder to make calls to EXTRACT

[ https://issues.apache.org/jira/browse/CALCITE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Baynes updated CALCITE-1793: -- Description: EXTRACT_DATE was originally intended to be an internal function, always created

[jira] [Updated] (CALCITE-1793) Allow RelBuilder to make calls to EXTRACT

[ https://issues.apache.org/jira/browse/CALCITE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Baynes updated CALCITE-1793: -- Description: EXTRACT_DATE was originally intended to be an internal function, always created

[jira] [Commented] (CALCITE-1328) RelBuilder not pushing down jdbc predicates

[ https://issues.apache.org/jira/browse/CALCITE-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393685#comment-15393685 ] Chris Baynes commented on CALCITE-1328: --- Ah ok, didn't realise the rules had to be manually

[jira] [Commented] (CALCITE-1328) RelBuilder not pushing down jdbc predicates

[ https://issues.apache.org/jira/browse/CALCITE-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391832#comment-15391832 ] Chris Baynes commented on CALCITE-1328: --- Before the schemaType property was available I was using

[jira] [Commented] (CALCITE-1328) RelBuilder not pushing down jdbc predicates

[ https://issues.apache.org/jira/browse/CALCITE-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391678#comment-15391678 ] Chris Baynes commented on CALCITE-1328: --- The connection is created with:

[jira] [Created] (CALCITE-1328) RelBuilder not pushing down jdbc predicates

Chris Baynes created CALCITE-1328: - Summary: RelBuilder not pushing down jdbc predicates Key: CALCITE-1328 URL: https://issues.apache.org/jira/browse/CALCITE-1328 Project: Calcite Issue

[jira] [Commented] (CALCITE-1264) Litmus fail does not interpolate arguments

[ https://issues.apache.org/jira/browse/CALCITE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307413#comment-15307413 ] Chris Baynes commented on CALCITE-1264: --- Here's the PR: https://github.com/apache/calcite/pull/241

[jira] [Created] (CALCITE-1264) Litmus fail does not interpolate arguments

Chris Baynes created CALCITE-1264: - Summary: Litmus fail does not interpolate arguments Key: CALCITE-1264 URL: https://issues.apache.org/jira/browse/CALCITE-1264 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-1245) Allow RelBuilder scan to take multiple arguments

[ https://issues.apache.org/jira/browse/CALCITE-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299695#comment-15299695 ] Chris Baynes commented on CALCITE-1245: --- [~julianhyde] Have pushed again taking into account your