[jira] [Commented] (CALCITE-3913) A formal verification techniques for testing correctness in calcite

2020-04-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081006#comment-17081006 ] Haisheng Yuan commented on CALCITE-3913: Interesting. Looking forward to the contribution. > A

[jira] [Commented] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080615#comment-17080615 ] Haisheng Yuan commented on CALCITE-3896: This will not replace abstract converter, but will

[jira] [Commented] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080614#comment-17080614 ] Haisheng Yuan commented on CALCITE-3896: 1. As described in the issue, the redundancy *can't*

[jira] [Created] (CALCITE-3911) JoinCommuteRule may generate wrong plan for SEMI/ANTI join

2020-04-10 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3911: -- Summary: JoinCommuteRule may generate wrong plan for SEMI/ANTI join Key: CALCITE-3911 URL: https://issues.apache.org/jira/browse/CALCITE-3911 Project: Calcite

[jira] [Commented] (CALCITE-3149) CACHE in RelDataTypeFactoryImpl can't be garbage collected

2020-04-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080204#comment-17080204 ] Haisheng Yuan commented on CALCITE-3149: [~jcamachorodriguez] Yes, it is still valid. > CACHE

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077671#comment-17077671 ] Haisheng Yuan commented on CALCITE-2970: We are off topic too much. I am OK to have a physical

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077504#comment-17077504 ] Haisheng Yuan commented on CALCITE-2970: [~julianhyde]I got what you mean. But if the Foo

[jira] [Comment Edited] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077481#comment-17077481 ] Haisheng Yuan edited comment on CALCITE-2970 at 4/7/20, 6:06 PM: - The

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077481#comment-17077481 ] Haisheng Yuan commented on CALCITE-2970: The creator of Foo convention should have its own

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077451#comment-17077451 ] Haisheng Yuan commented on CALCITE-2970: {quote} But physical rules do more than convert

[jira] [Commented] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077357#comment-17077357 ] Haisheng Yuan commented on CALCITE-3896: The cost looks tiny, but if you consider more

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076938#comment-17076938 ] Haisheng Yuan commented on CALCITE-2970: RelBuilder should be used for logical operators only,

[jira] [Comment Edited] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076786#comment-17076786 ] Haisheng Yuan edited comment on CALCITE-3896 at 4/7/20, 12:44 AM: --

[jira] [Commented] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076786#comment-17076786 ] Haisheng Yuan commented on CALCITE-3896: VolcanoPlanner will call the method, after all the

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076753#comment-17076753 ] Haisheng Yuan commented on CALCITE-2970: The by-product benefit of doing this is keeping

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076751#comment-17076751 ] Haisheng Yuan commented on CALCITE-2970: {{changeTraitsUsingConverters()}} doesn't know what

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076705#comment-17076705 ] Haisheng Yuan commented on CALCITE-2970: Now I don't think it is the good direction, it is

[jira] [Updated] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-05 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3896: --- Description: This is not on-demand trait requests as described in [mailing

[jira] [Updated] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3896: --- Description: This is not on-demand trait requests as described in [mailing

[jira] [Updated] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3896: --- Description: This is not on-demand trait requests as described in [mailing

[jira] [Created] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-04 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3896: -- Summary: Pass through parent trait requests to child operators Key: CALCITE-3896 URL: https://issues.apache.org/jira/browse/CALCITE-3896 Project: Calcite

[jira] [Commented] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

2020-04-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073373#comment-17073373 ] Haisheng Yuan commented on CALCITE-3891: [~fan_li_ya] For the query's performance issue, it is

[jira] [Commented] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

2020-04-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073367#comment-17073367 ] Haisheng Yuan commented on CALCITE-3891: [~fan_li_ya] Yes. It will generate new AbstractList

[jira] [Commented] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

2020-04-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073364#comment-17073364 ] Haisheng Yuan commented on CALCITE-3891: [~neoremind] Flat2List.iterator also takes more than

[jira] [Commented] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

2020-04-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073355#comment-17073355 ] Haisheng Yuan commented on CALCITE-3891: [~neoremind] I used IntelliJ Profiler, and I used a

[jira] [Commented] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

2020-04-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073336#comment-17073336 ] Haisheng Yuan commented on CALCITE-3891: I agree. > Remove use of Pair.zip in

[jira] [Created] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

2020-04-01 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3891: -- Summary: Remove use of Pair.zip in RelTraitSet.satisfies Key: CALCITE-3891 URL: https://issues.apache.org/jira/browse/CALCITE-3891 Project: Calcite

[jira] [Comment Edited] (CALCITE-3889) Add apply(Mappings.Mapping) to RelTrait and RelTraitSet

2020-04-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072808#comment-17072808 ] Haisheng Yuan edited comment on CALCITE-3889 at 4/1/20, 2:16 PM: -

[jira] [Commented] (CALCITE-3889) Add apply(Mappings.Mapping) to RelTrait and RelTraitSet

2020-04-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072808#comment-17072808 ] Haisheng Yuan commented on CALCITE-3889: [~rkondakov] There is a fix for the bug you mentioned:

[jira] [Created] (CALCITE-3889) Add apply(Mappings.Mapping) to RelTrait and RelTraitSet

2020-03-31 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3889: -- Summary: Add apply(Mappings.Mapping) to RelTrait and RelTraitSet Key: CALCITE-3889 URL: https://issues.apache.org/jira/browse/CALCITE-3889 Project: Calcite

[jira] [Resolved] (CALCITE-3885) Reestablish trace logging for rules queue and Volcano planner

2020-03-29 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3885. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3886) Execute substitution rule according to the order they get matched

2020-03-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3886. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Created] (CALCITE-3886) Execute substitution rule according to the order they get matched

2020-03-28 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3886: -- Summary: Execute substitution rule according to the order they get matched Key: CALCITE-3886 URL: https://issues.apache.org/jira/browse/CALCITE-3886 Project:

[jira] [Resolved] (CALCITE-3867) Support RelDistribution json serialization

2020-03-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3867. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3879) Rel Id should be generated per query context instead of globally

2020-03-26 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068154#comment-17068154 ] Haisheng Yuan commented on CALCITE-3879: OK, I haven't seen the risk of generating rel id per

[jira] [Updated] (CALCITE-3879) Rel Id should be generated per query context instead of globally

2020-03-26 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3879: --- Summary: Rel Id should be generated per query context instead of globally (was: Rel Id

[jira] [Updated] (CALCITE-3879) Rel Id should be generated per query context

2020-03-26 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3879: --- Summary: Rel Id should be generated per query context (was: Rel Id generator should not

[jira] [Created] (CALCITE-3879) Rel Id generator should not be static

2020-03-26 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3879: -- Summary: Rel Id generator should not be static Key: CALCITE-3879 URL: https://issues.apache.org/jira/browse/CALCITE-3879 Project: Calcite Issue Type:

[jira] [Created] (CALCITE-3868) Remove redundant ruleSet and ruleNames in VolcanoPlanner

2020-03-23 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3868: -- Summary: Remove redundant ruleSet and ruleNames in VolcanoPlanner Key: CALCITE-3868 URL: https://issues.apache.org/jira/browse/CALCITE-3868 Project: Calcite

[jira] [Commented] (CALCITE-3865) RelCollationTraitDef.canConvert should always return true

2020-03-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062987#comment-17062987 ] Haisheng Yuan commented on CALCITE-3865: If it doesn't have fields to sort, it won't come here.

[jira] [Updated] (CALCITE-3865) RelCollationTraitDef.canConvert should always return true

2020-03-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3865: --- Description: CALCITE-1148 introduced the following change to RelCollationTraitDef to fix

[jira] [Updated] (CALCITE-3865) RelCollationTraitDef.canConvert should always return true

2020-03-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3865: --- Description: CALCITE-1148 introduced the following change to RelCollationTraitDef to fix

[jira] [Created] (CALCITE-3865) RelCollationTraitDef.canConvert should always return true

2020-03-19 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3865: -- Summary: RelCollationTraitDef.canConvert should always return true Key: CALCITE-3865 URL: https://issues.apache.org/jira/browse/CALCITE-3865 Project: Calcite

[jira] [Commented] (CALCITE-3505) Infinite matching of FilterProjectTransposeRule causes stackoverflow

2020-03-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062167#comment-17062167 ] Haisheng Yuan commented on CALCITE-3505: Can't reproduce the issue on current master branch.

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-03-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062143#comment-17062143 ] Haisheng Yuan commented on CALCITE-2970: It turned out after CALCITE-3753 removing rule match

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-03-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062019#comment-17062019 ] Haisheng Yuan commented on CALCITE-2970: There are 3 issues: 1. too many abstract converters 2.

[jira] [Resolved] (CALCITE-3634) Support Intersect and Minus on Calcs for materialized view recognition

2020-03-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3634. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060550#comment-17060550 ] Haisheng Yuan commented on CALCITE-3851: OK, make sense. > Replace the node importance map

[jira] [Comment Edited] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059399#comment-17059399 ] Haisheng Yuan edited comment on CALCITE-3851 at 3/15/20, 4:52 PM: --

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-14 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059400#comment-17059400 ] Haisheng Yuan commented on CALCITE-3851: The method {{replaceInput}} of {{RelNode}} also breaks

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-14 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059399#comment-17059399 ] Haisheng Yuan commented on CALCITE-3851: {{String}} is immutable, but it has mutable field

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059157#comment-17059157 ] Haisheng Yuan commented on CALCITE-3851: I would prefer adding {{setPruned(), isPruned()}} API

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057623#comment-17057623 ] Haisheng Yuan commented on CALCITE-3851: Yeah, make sense. > Replace the node importance map

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057595#comment-17057595 ] Haisheng Yuan commented on CALCITE-3851: In fact, with new interface SubstitutionRule, users

[jira] [Commented] (CALCITE-3851) Store nodes with zero importance with a set

2020-03-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056699#comment-17056699 ] Haisheng Yuan commented on CALCITE-3851: Currently, the sole purpose of {{relImportances}} is

[jira] [Resolved] (CALCITE-3041) Query runs endless when setImportance to 0

2020-03-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3041. Resolution: Invalid Can't reproduce the issue any more as of commit

[jira] [Resolved] (CALCITE-3757) When merging sets, relnodes may be reregistered multiple times

2020-03-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3757. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-3753) Remove rulematch ordering and execute substitution rule first

2020-03-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3753: --- Summary: Remove rulematch ordering and execute substitution rule first (was: Remove

[jira] [Resolved] (CALCITE-3753) Remove rulematch ordering and execute substitution rule first

2020-03-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3753. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3819) Prune parent RelNode when merging child RelSet with parent RelSet

2020-03-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3819. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3821) RelOptUtil::containsMultisetOrWindowedAgg doesn't really check multiset

2020-03-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3821. Fix Version/s: 1.23.0 Resolution: Fixed FIxed in

[jira] [Commented] (CALCITE-3753) Remove rulematch ordering

2020-03-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048677#comment-17048677 ] Haisheng Yuan commented on CALCITE-3753: Hi folks, I have opened a pull request to remove the

[jira] [Updated] (CALCITE-3753) Remove rulematch ordering

2020-02-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3753: --- Summary: Remove rulematch ordering (was: Always try to match and execute substitution

[jira] [Assigned] (CALCITE-3819) Prune parent RelNode when merging child RelSet with parent RelSet

2020-02-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan reassigned CALCITE-3819: -- Assignee: Haisheng Yuan > Prune parent RelNode when merging child RelSet with

[jira] [Created] (CALCITE-3819) Prune parent RelNode when merging child RelSet with parent RelSet

2020-02-24 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3819: -- Summary: Prune parent RelNode when merging child RelSet with parent RelSet Key: CALCITE-3819 URL: https://issues.apache.org/jira/browse/CALCITE-3819 Project:

[jira] [Commented] (CALCITE-3786) Add Digest (HashStrategy?) interface to enable efficient hashCode/equals for RexNode, RelNode

2020-02-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035910#comment-17035910 ] Haisheng Yuan commented on CALCITE-3786: The reason is that in Calcite RexNode doesn't have

[jira] [Commented] (CALCITE-3786) Add Digest (HashStrategy?) interface to enable efficient hashCode/equals for RexNode, RelNode

2020-02-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035833#comment-17035833 ] Haisheng Yuan commented on CALCITE-3786: The Digest itself is nothing different with a normal

[jira] [Resolved] (CALCITE-3785) Performance regression in HepPlanner#belongsToDag() due to expensive hashCode computation

2020-02-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3785. Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3784) RexCall toString digest gives OOM while huge expression is evaluated

2020-02-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034864#comment-17034864 ] Haisheng Yuan commented on CALCITE-3784: Anyway, with current architecture, I don't think there

[jira] [Commented] (CALCITE-3784) RexCall toString digest gives OOM while huge expression is evaluated

2020-02-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034842#comment-17034842 ] Haisheng Yuan commented on CALCITE-3784: A filter condition with 10,000 expressions, would use

[jira] [Commented] (CALCITE-3192) Simplification may weaken OR conditions containing inequalities

2020-02-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034748#comment-17034748 ] Haisheng Yuan commented on CALCITE-3192: If I understand it correctly, [~Chunwei Lei] is

[jira] [Comment Edited] (CALCITE-3784) RexCall toString digest gives OOM while huge expression is evaluated

2020-02-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034717#comment-17034717 ] Haisheng Yuan edited comment on CALCITE-3784 at 2/11/20 6:53 PM: -

[jira] [Commented] (CALCITE-3784) RexCall toString digest gives OOM while huge expression is evaluated

2020-02-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034717#comment-17034717 ] Haisheng Yuan commented on CALCITE-3784: [~julianhyde] It is not surprising large rexcalls

[jira] [Commented] (CALCITE-3784) RexCall toString digest gives OOM while huge expression is evaluated

2020-02-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034689#comment-17034689 ] Haisheng Yuan commented on CALCITE-3784: unfortunately, the current design of Calcite can't

[jira] [Resolved] (CALCITE-3768) VolcanoPlanner.changeTraitsUsingConverters() has parameter that's never used

2020-02-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3768. Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-29 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026387#comment-17026387 ] Haisheng Yuan commented on CALCITE-3753: [~zabetak] {quote} If I am not mistaken, the original

[jira] [Resolved] (CALCITE-3755) Ascending rule match with RelSubset operand doesn't work

2020-01-29 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3755. Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3756) RelSubset should not match operand(RelNode.class)

2020-01-29 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3756. Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3759) class leak

2020-01-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025351#comment-17025351 ] Haisheng Yuan commented on CALCITE-3759: No evidence shows there is a leak. > class leak >

[jira] [Commented] (CALCITE-3738) Missing LogicalSort for INSERT statement

2020-01-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025345#comment-17025345 ] Haisheng Yuan commented on CALCITE-3738: Thanks for reminding, I have updated both JIRA and

[jira] [Updated] (CALCITE-3738) Missing LogicalSort for INSERT statement

2020-01-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3738: --- Summary: Missing LogicalSort for INSERT statement (was: Missing LogicalSort for Insert

[jira] [Resolved] (CALCITE-3738) Missing LogicalSort for Insert statement

2020-01-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3738. Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Created] (CALCITE-3757) When merging sets, relnodes may be reregistered multiple times

2020-01-27 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3757: -- Summary: When merging sets, relnodes may be reregistered multiple times Key: CALCITE-3757 URL: https://issues.apache.org/jira/browse/CALCITE-3757 Project:

[jira] [Comment Edited] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-27 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024828#comment-17024828 ] Haisheng Yuan edited comment on CALCITE-3753 at 1/28/20 2:28 AM: - What

[jira] [Commented] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-27 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024828#comment-17024828 ] Haisheng Yuan commented on CALCITE-3753: What I want to do is to kill the comparator. > Always

[jira] [Commented] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-27 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024825#comment-17024825 ] Haisheng Yuan commented on CALCITE-3753: It has nothing to do with trait propagation. The

[jira] [Resolved] (CALCITE-3676) VolcanoPlanner. dumpGraphviz should handle exception gracefully

2020-01-27 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3676. Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3653) Support TableModify operator expression convert to Logical in ToLogicalConverter

2020-01-27 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3653. Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-3653) Support TableModify operator expression convert to Logical in ToLogicalConverter

2020-01-27 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3653: --- Summary: Support TableModify operator expression convert to Logical in ToLogicalConverter

[jira] [Resolved] (CALCITE-3668) VolcanoPlanner doesn't match all the RelSubSet in matchRecursive

2020-01-27 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3668. Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3744) Duplicate RuleMatches when RelSet gets merged

2020-01-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3744. Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-3756) RelSubset should not match operand(RelNode.class)

2020-01-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3756: --- Description: Even RelSubset is a subclass of RelNode, but they are quite different.

[jira] [Created] (CALCITE-3756) RelSubset should not match operand(RelNode.class)

2020-01-23 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3756: -- Summary: RelSubset should not match operand(RelNode.class) Key: CALCITE-3756 URL: https://issues.apache.org/jira/browse/CALCITE-3756 Project: Calcite

[jira] [Created] (CALCITE-3755) Ascending rule match with RelSubset operand doesn't work

2020-01-23 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3755: -- Summary: Ascending rule match with RelSubset operand doesn't work Key: CALCITE-3755 URL: https://issues.apache.org/jira/browse/CALCITE-3755 Project: Calcite

[jira] [Commented] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022394#comment-17022394 ] Haisheng Yuan commented on CALCITE-3753: > How would you declare that a rule is a "substitution

[jira] [Comment Edited] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021615#comment-17021615 ] Haisheng Yuan edited comment on CALCITE-3753 at 1/22/20 11:23 PM: -- I

[jira] [Commented] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021615#comment-17021615 ] Haisheng Yuan commented on CALCITE-3753: I was not clear. I suggest for substitution rule

[jira] [Comment Edited] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021615#comment-17021615 ] Haisheng Yuan edited comment on CALCITE-3753 at 1/22/20 11:20 PM: -- I

[jira] [Commented] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021597#comment-17021597 ] Haisheng Yuan commented on CALCITE-3753: A substitution rule is a rule that can generate a

[jira] [Commented] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

2020-01-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020881#comment-17020881 ] Haisheng Yuan commented on CALCITE-3753: Yes. > Always try to match and execute substitution

<    1   2   3   4   5   6   7   8   9   10   >