[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432147#comment-16432147 ] Zoltan Haindrich commented on CALCITE-2247: --- I've opened https://github.com/ap

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432189#comment-16432189 ] Jesus Camacho Rodriguez commented on CALCITE-2247: -- [~kgyrtkirk], there

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434014#comment-16434014 ] Julian Hyde commented on CALCITE-2247: -- RexImplicationChecker is a good idea in pri

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434518#comment-16434518 ] Julian Hyde commented on CALCITE-2247: -- I thought about this some more. RexSimplify

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434548#comment-16434548 ] Zoltan Haindrich commented on CALCITE-2247: --- When I've looked into RexImplicat

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453810#comment-16453810 ] Zoltan Haindrich commented on CALCITE-2247: --- After a few loose ends, I think I

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454385#comment-16454385 ] Julian Hyde commented on CALCITE-2247: -- Glad this is working out for you. I like th

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454531#comment-16454531 ] Zoltan Haindrich commented on CALCITE-2247: --- I've made some bad trials which h

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457984#comment-16457984 ] Zoltan Haindrich commented on CALCITE-2247: --- I've went forward and tried to co

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462670#comment-16462670 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde], [~jcamachorodrigue

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464209#comment-16464209 ] Julian Hyde commented on CALCITE-2247: -- Can this change simplify {{a > 5 AND b < 2

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466077#comment-16466077 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde]: yes, cases like th

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467823#comment-16467823 ] Julian Hyde commented on CALCITE-2247: -- [~kgyrtkirk], I reviewed, and pushed a bran

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469157#comment-16469157 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde] I've missed that -

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469219#comment-16469219 ] Julian Hyde commented on CALCITE-2247: -- It helps to use a truth table. For {{b = 1

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469267#comment-16469267 ] Zoltan Haindrich commented on CALCITE-2247: --- sorry...I see now that actually A

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469371#comment-16469371 ] Zoltan Haindrich commented on CALCITE-2247: --- the current changeset incorrectly

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470036#comment-16470036 ] Zoltan Haindrich commented on CALCITE-2247: --- I've fixed that issue; but it loo

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471602#comment-16471602 ] Julian Hyde commented on CALCITE-2247: -- Did the problem with {{x AND NOT x}} exist

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471630#comment-16471630 ] Zoltan Haindrich commented on CALCITE-2247: --- I've checked it separetly; it was

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476041#comment-16476041 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde] Could you please ta

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479871#comment-16479871 ] Julian Hyde commented on CALCITE-2247: -- I've reviewed again, and I still have one p

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480289#comment-16480289 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde]: I've discovered th

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481019#comment-16481019 ] Julian Hyde commented on CALCITE-2247: -- CALCITE-2314 does not affect the behavior o

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481023#comment-16481023 ] Julian Hyde commented on CALCITE-2247: -- One more thing. I would have expected the q

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481147#comment-16481147 ] Zoltan Haindrich commented on CALCITE-2247: --- I think that probably unknownAsFa

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481235#comment-16481235 ] Julian Hyde commented on CALCITE-2247: -- I agree. I am not a huge fan of unknownAsFa

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481312#comment-16481312 ] Jesus Camacho Rodriguez commented on CALCITE-2247: -- When {{unknownAsFal

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482016#comment-16482016 ] Julian Hyde commented on CALCITE-2247: -- Thanks for the background, [~jcamachorodrig

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482026#comment-16482026 ] Julian Hyde commented on CALCITE-2247: -- I think it's found another one: we simplify

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482038#comment-16482038 ] Zoltan Haindrich commented on CALCITE-2247: --- I've also thinked about this; and

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483390#comment-16483390 ] Julian Hyde commented on CALCITE-2247: -- I was thinking along similar lines. We coul