[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517138#comment-16517138
]
Andrei Sereda commented on CALCITE-2345:
[~vvysotskyi] this is a bug indeed. I have tested with
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516775#comment-16516775
]
Volodymyr Vysotskyi commented on CALCITE-2345:
--
[~asereda], I have a question regarding
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508492#comment-16508492
]
Andrei Sereda commented on CALCITE-2345:
I have updated the
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507124#comment-16507124
]
Julian Hyde commented on CALCITE-2345:
--
Apache Drill has plenty of test data sets, e.g.
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507119#comment-16507119
]
Julian Hyde commented on CALCITE-2345:
--
bq. I took the liberty to create zips-mini.json for ES
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506568#comment-16506568
]
Andrei Sereda commented on CALCITE-2345:
I took the liberty to create {{zips-mini.json}} for ES
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502735#comment-16502735
]
Andrei Sereda commented on CALCITE-2345:
Pls take a look at
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500667#comment-16500667
]
Julian Hyde commented on CALCITE-2345:
--
bq. Are you OK if I copy zips.json to both
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500640#comment-16500640
]
Andrei Sereda commented on CALCITE-2345:
{quote}Easiest thing to start with is to copy-paste
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500608#comment-16500608
]
Julian Hyde commented on CALCITE-2345:
--
bq. How can I get zips data in unit test (classpath) ?
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499570#comment-16499570
]
Andrei Sereda commented on CALCITE-2345:
Both issues have similar goals: execute {{AdapterIT}}
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498695#comment-16498695
]
Andrei Sereda commented on CALCITE-2345:
Very good.
How can I get zips data in unit test
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498694#comment-16498694
]
Julian Hyde commented on CALCITE-2345:
--
In my opinion, a test should be as an integration test if
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498685#comment-16498685
]
Julian Hyde commented on CALCITE-2345:
--
Let's not worry too much about performance. Suppose it
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498591#comment-16498591
]
Andrei Sereda commented on CALCITE-2345:
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496854#comment-16496854
]
Michael Mior commented on CALCITE-2345:
---
If they take too long, one option would be to only
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496814#comment-16496814
]
Andrei Sereda commented on CALCITE-2345:
Hmm. My concern is that unit tests have to be fast.
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496775#comment-16496775
]
Michael Mior commented on CALCITE-2345:
---
If we're moving towards unifying the integration tests
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496758#comment-16496758
]
Andrei Sereda commented on CALCITE-2345:
I will work to have a single test for Mongo Adapter.
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496739#comment-16496739
]
Michael Mior commented on CALCITE-2345:
---
Based on discussion on the mailing list, [~asereda] is
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496734#comment-16496734
]
Julian Hyde commented on CALCITE-2345:
--
[~michaelmior] I'm not criticizing you. It's a 45:55
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496718#comment-16496718
]
Julian Hyde commented on CALCITE-2345:
--
{quote}until we manage to unify these tests
{quote}
Who is
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496704#comment-16496704
]
Michael Mior commented on CALCITE-2345:
---
Agreed that it is added complexity, which is far from
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496699#comment-16496699
]
Julian Hyde commented on CALCITE-2345:
--
After this change, we have both MongoAdapterIT and
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496102#comment-16496102
]
Andrei Sereda commented on CALCITE-2345:
If you enable system property
[
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496079#comment-16496079
]
Julian Hyde commented on CALCITE-2345:
--
This would definitely be useful. Would it be possible to
26 matches
Mail list logo
