[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823643#comment-16823643
]
Chunwei Lei commented on CALCITE-2453:
--
Thanks for your review, [~julianhyde]. PR is updated
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823377#comment-16823377
]
Julian Hyde commented on CALCITE-2453:
--
* Need more javadoc in {{SqlParserTest}}. Explain the
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822901#comment-16822901
]
Chunwei Lei commented on CALCITE-2453:
--
Thanks [~pzw2018].
I updated the PR with more test cases
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822840#comment-16822840
]
pengzhiwei commented on CALCITE-2453:
-
Hi [~Chunwei Lei], can you add a test which mixed the
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822502#comment-16822502
]
Chunwei Lei commented on CALCITE-2453:
--
{quote}The first statement is parsed successfully and the
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820220#comment-16820220
]
Chunwei Lei commented on CALCITE-2453:
--
Thanks [~julianhyde].
I reviewed the PR and I believe it
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818307#comment-16818307
]
Julian Hyde commented on CALCITE-2453:
--
I haven't had chance to review. [~Chunwei Lei], If you
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816976#comment-16816976
]
Chunwei Lei commented on CALCITE-2453:
--
Hi, [~julianhyde], [~charbel], any progress on it? I think
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587275#comment-16587275
]
charbel yazbeck commented on CALCITE-2453:
--
Hi Julian, are my last PR changes ok ? Any idea on
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574655#comment-16574655
]
charbel yazbeck commented on CALCITE-2453:
--
Hi Julia, all your comments have been taken into
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573851#comment-16573851
]
Julian Hyde commented on CALCITE-2453:
--
Reviewing [PR
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572960#comment-16572960
]
charbel yazbeck commented on CALCITE-2453:
--
Hi Julian, sorry about the patch and the tests, I
[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571936#comment-16571936
]
Julian Hyde commented on CALCITE-2453:
--
In future please provide a PR not a patch; you must
13 matches
Mail list logo