[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-22 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823643#comment-16823643 ] Chunwei Lei commented on CALCITE-2453: -- Thanks for your review, [~julianhyde]. PR is updated

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-22 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823377#comment-16823377 ] Julian Hyde commented on CALCITE-2453: -- * Need more javadoc in {{SqlParserTest}}. Explain the

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-22 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822901#comment-16822901 ] Chunwei Lei commented on CALCITE-2453: -- Thanks [~pzw2018]. I updated the PR with more test cases 

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-21 Thread pengzhiwei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822840#comment-16822840 ] pengzhiwei commented on CALCITE-2453: - Hi [~Chunwei Lei], can you add a test  which mixed  the

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-20 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822502#comment-16822502 ] Chunwei Lei commented on CALCITE-2453: -- {quote}The first statement is parsed successfully and the

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-17 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820220#comment-16820220 ] Chunwei Lei commented on CALCITE-2453: -- Thanks [~julianhyde]. I reviewed the PR and I believe it 

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-15 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818307#comment-16818307 ] Julian Hyde commented on CALCITE-2453: -- I haven't had chance to review. [~Chunwei Lei], If you

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-13 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816976#comment-16816976 ] Chunwei Lei commented on CALCITE-2453: -- Hi, [~julianhyde], [~charbel], any progress on it? I think

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2018-08-21 Thread charbel yazbeck (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587275#comment-16587275 ] charbel yazbeck commented on CALCITE-2453: -- Hi Julian, are my last PR changes ok ? Any idea on

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2018-08-09 Thread charbel yazbeck (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574655#comment-16574655 ] charbel yazbeck commented on CALCITE-2453: -- Hi Julia, all your comments have been taken into

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2018-08-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573851#comment-16573851 ] Julian Hyde commented on CALCITE-2453: -- Reviewing [PR

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2018-08-08 Thread charbel yazbeck (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572960#comment-16572960 ] charbel yazbeck commented on CALCITE-2453: -- Hi Julian, sorry about the patch and the tests, I

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2018-08-07 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571936#comment-16571936 ] Julian Hyde commented on CALCITE-2453: -- In future please provide a PR not a patch; you must