[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-11-08 Thread Ted Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680757#comment-16680757 ] Ted Xu commented on CALCITE-2619: - [~julianhyde] sorry for the late reply, I was already working on

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-11-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680696#comment-16680696 ] Julian Hyde commented on CALCITE-2619: -- [~tedxu] Can you develop a patch? Can you also please

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-24 Thread Daniel Lemire (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662880#comment-16662880 ] Daniel Lemire commented on CALCITE-2619: Ping me if you need help reviewing the code.  >

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-22 Thread Ted Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659943#comment-16659943 ] Ted Xu commented on CALCITE-2619: - Thanks [~lemire] for the test and blog post. We should move forward

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654385#comment-16654385 ] Julian Hyde commented on CALCITE-2619: -- It's very possible that the "payload" of an NlsString

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-16 Thread Daniel Lemire (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652430#comment-16652430 ] Daniel Lemire commented on CALCITE-2619: The problem that I see in the code right now is that

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-16 Thread Daniel Lemire (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652404#comment-16652404 ] Daniel Lemire commented on CALCITE-2619: As for validating UTF-8 bytes, @julianhyde is probably 

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-15 Thread Daniel Lemire (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650255#comment-16650255 ] Daniel Lemire commented on CALCITE-2619: I'll do some evaluation of the problem (hopefully this

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-15 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649792#comment-16649792 ] Julian Hyde commented on CALCITE-2619: -- Probably good enough for our purposes is Guava’s

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-14 Thread Ted Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649663#comment-16649663 ] Ted Xu commented on CALCITE-2619: - Great! Thanks [~julianhyde] and [~lemire]! [~lemire] I'm assigning

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-13 Thread Daniel Lemire (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649007#comment-16649007 ] Daniel Lemire commented on CALCITE-2619: I am willing to help. I can help test, design,

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648585#comment-16648585 ] Julian Hyde commented on CALCITE-2619: -- I think we should focus on the cost of validating whether

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647565#comment-16647565 ] Haisheng Yuan commented on CALCITE-2619: I am not worried about the memory overhead for caching

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647560#comment-16647560 ] Haisheng Yuan commented on CALCITE-2619: [~julianhyde] Once the CharsetEncoder of the CharSet

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Ted Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647315#comment-16647315 ] Ted Xu commented on CALCITE-2619: - As for the cost distribution, I did a quick test:   ||Name||CPU

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647257#comment-16647257 ] Julian Hyde commented on CALCITE-2619: -- By the way, what is the expensive part in NlsString? Is it

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647247#comment-16647247 ] Julian Hyde commented on CALCITE-2619: -- You've done one of those "let's drill a hole" changes.

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Ted Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646165#comment-16646165 ] Ted Xu commented on CALCITE-2619: - Thanks [~julianhyde], I created a pull request at

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-10 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645996#comment-16645996 ] Julian Hyde commented on CALCITE-2619: -- I think the charset test is useful. Is there any way we