[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-09-02 Thread Jacky Woo (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921112#comment-16921112 ] Jacky Woo commented on CALCITE-3282: Ok, thank you. > Make every SqlDialect unpars

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-30 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919451#comment-16919451 ] Danny Chan commented on CALCITE-3282: - Let's just ignore unparsing the DDL first, C

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-28 Thread Jacky Woo (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918226#comment-16918226 ] Jacky Woo commented on CALCITE-3282: Hi Danny, we realize your consideration. But

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-25 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915407#comment-16915407 ] Danny Chan commented on CALCITE-3282: - The key point is that we don't want the SqlT

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-25 Thread feng huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915397#comment-16915397 ] feng huang commented on CALCITE-3282: - Hi [~danny0405], actually, i didn't get you,

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914095#comment-16914095 ] Danny Chan commented on CALCITE-3282: - Add a new method SqlDialect#unparseDataType

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-22 Thread Jacky Woo (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913888#comment-16913888 ] Jacky Woo commented on CALCITE-3282: Hi,  [~danny0405] At the beginning, we try to

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-22 Thread Jacky Woo (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913881#comment-16913881 ] Jacky Woo commented on CALCITE-3282: Hi, [~danny0405] [~julianhyde] This pr by [~f

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-22 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913878#comment-16913878 ] Danny Chan commented on CALCITE-3282: - The SqlTypeNameSpec is a component of SqlDat

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-22 Thread feng huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913859#comment-16913859 ] feng huang commented on CALCITE-3282: - [~danny0405] Of course, it's not an easy wor

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-22 Thread feng huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913852#comment-16913852 ] feng huang commented on CALCITE-3282: - [~julianhyde]  Sorry , I have modified and a