[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-04-23 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090376#comment-17090376 ] neoremind commented on CALCITE-3878: Thanks Haisheng for moving this forward :) >

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090154#comment-17090154 ] Haisheng Yuan commented on CALCITE-3878: I will commit this patch if there are

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089237#comment-17089237 ] Haisheng Yuan commented on CALCITE-3878: Hi [~julianhyde], how do you like the

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-04-01 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073380#comment-17073380 ] neoremind commented on CALCITE-3878: [~julianhyde] Many thanks for your reply. I un

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-04-01 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073241#comment-17073241 ] Julian Hyde commented on CALCITE-3878: -- bq. So the debate make me think what shall

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069217#comment-17069217 ] neoremind commented on CALCITE-3878: I didn't expect to bring so deep discussion on

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069000#comment-17069000 ] Julian Hyde commented on CALCITE-3878: -- I wish we didn't have to spend time on thi

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068950#comment-17068950 ] Vladimir Sitnikov commented on CALCITE-3878: How about replacing: {noformat

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068939#comment-17068939 ] Julian Hyde commented on CALCITE-3878: -- Some of these cases are for collections th

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068428#comment-17068428 ] neoremind commented on CALCITE-3878: [~donnyzone] For code style, I think that is a

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068416#comment-17068416 ] neoremind commented on CALCITE-3878: [~vladimirsitnikov] The variance does look odd

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068412#comment-17068412 ] Vladimir Sitnikov commented on CALCITE-3878: The variance of the results is

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068401#comment-17068401 ] neoremind commented on CALCITE-3878: [~vladimirsitnikov] I update the code to retur

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068397#comment-17068397 ] Feng Zhu commented on CALCITE-3878: --- Certainly, changes made by this PR can help to i

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068391#comment-17068391 ] Vladimir Sitnikov commented on CALCITE-3878: [~julianhyde], I'm afraid you

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068389#comment-17068389 ] Vladimir Sitnikov commented on CALCITE-3878: [~neoremind], the benchmark mi

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-26 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068270#comment-17068270 ] neoremind commented on CALCITE-3878: To verify, I made a benchmark. {code:java} @St

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-26 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068252#comment-17068252 ] neoremind commented on CALCITE-3878: [~julianhyde] Thanks for looking into the issu

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067987#comment-17067987 ] Julian Hyde commented on CALCITE-3878: -- I might be mistaken about the intrinsics.

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067966#comment-17067966 ] Julian Hyde commented on CALCITE-3878: -- -1 I believe that JVM instrinsics make th