[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091078#comment-17091078 ] Haisheng Yuan commented on CALCITE-3932: Yes, that is feasible. But what if down stream

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091057#comment-17091057 ] Julian Hyde commented on CALCITE-3932: -- I agree, won't-fix is the right remedy here. I wonder

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090927#comment-17090927 ] Haisheng Yuan commented on CALCITE-3932: For thread local, even it is long-lived, as long as

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090839#comment-17090839 ] Julian Hyde commented on CALCITE-3932: -- It's possible that one thread will create a type and

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090165#comment-17090165 ] Haisheng Yuan commented on CALCITE-3932: Thanks for your advice. [~Junzheng Zheng] I opened a

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-22 Thread Junzheng Zheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090161#comment-17090161 ] Junzheng Zheng commented on CALCITE-3932: - I think use a private attribute of 

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089712#comment-17089712 ] Haisheng Yuan commented on CALCITE-3932: If we consider the use of ThreadPool, we probably

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086242#comment-17086242 ] Haisheng Yuan commented on CALCITE-3932: [~julianhyde] What do you think? Are the two caches

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085406#comment-17085406 ] Haisheng Yuan commented on CALCITE-3932: How can it be garbage collected while still being

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085404#comment-17085404 ] neoremind commented on CALCITE-3932: I was thinking if we use ThreadLocal, are there any places to

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085402#comment-17085402 ] Danny Chen commented on CALCITE-3932: - We compare our types in many places with `==` in our code,

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085322#comment-17085322 ] Haisheng Yuan commented on CALCITE-3932: RelDataTypeFactoryImpl KEY2TYPE_CACHE and 

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085317#comment-17085317 ] Julian Hyde commented on CALCITE-3932: -- What data type cache are you referring to? Each query has

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085290#comment-17085290 ] Haisheng Yuan commented on CALCITE-3932: Most of the data type among different queries are not