[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-03-25 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830774#comment-17830774 ] Mihai Budiu commented on CALCITE-6248: -- I thought we were ready to close this one, but the

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-03-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823772#comment-17823772 ] Julian Hyde commented on CALCITE-6248: -- Postel's law applies: "be conservative in what you send,

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-26 Thread Evgeny Stanilovsky (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820972#comment-17820972 ] Evgeny Stanilovsky commented on CALCITE-6248: - honestly i think we need to follow the

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-26 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820932#comment-17820932 ] Mihai Budiu commented on CALCITE-6248: -- Moreover, it looks like Avatica 1.24 will reject some

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-26 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820906#comment-17820906 ] Mihai Budiu commented on CALCITE-6248: -- [~tanclary] git blame claims you have added these two

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-26 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820904#comment-17820904 ] Mihai Budiu commented on CALCITE-6248: -- I see two tests in SqlOperatorTest: {code}

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817552#comment-17817552 ] Julian Hyde commented on CALCITE-6248: -- I understand your chain of reasoning. But it is flawed,

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-14 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817545#comment-17817545 ] Mihai Budiu commented on CALCITE-6248: -- The validation code is in Avatica, so the tests are there.

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817544#comment-17817544 ] Julian Hyde commented on CALCITE-6248: -- I think we should remain reasonably liberal in the format

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-14 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817527#comment-17817527 ] Mihai Budiu commented on CALCITE-6248: -- I have a question about this Quidem test in misc.iq:

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-14 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817525#comment-17817525 ] Mihai Budiu commented on CALCITE-6248: -- I apologize, but it looks like my fix for Calcite was not

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-13 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817159#comment-17817159 ] Mihai Budiu commented on CALCITE-6248: -- I have merged the PR for the Calcite side

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-12 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816810#comment-17816810 ] Mihai Budiu commented on CALCITE-6248: -- This PR will require changes in both Avatica and Calcite

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-11 Thread Evgeny Stanilovsky (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816490#comment-17816490 ] Evgeny Stanilovsky commented on CALCITE-6248: - [~mbudiu] plz check discussion here [1] and

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-09 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816189#comment-17816189 ] Mihai Budiu commented on CALCITE-6248: -- Another possibility is that dates are validated

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-09 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816188#comment-17816188 ] Mihai Budiu commented on CALCITE-6248: -- [~zstan] it looks like the validation code for dates in

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-09 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816180#comment-17816180 ] Mihai Budiu commented on CALCITE-6248: -- Yes, this is related to the Avatica bug which was fixed.

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-06 Thread Evgeny Stanilovsky (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815104#comment-17815104 ] Evgeny Stanilovsky commented on CALCITE-6248: - [~mbudiu] such a problem was fixed in