Sergey Galkin created CAMEL-6473:
------------------------------------
Summary: NULL values are not supported in named parameters
Key: CAMEL-6473
URL: https://issues.apache.org/jira/browse/CAMEL-6473
Project: Camel
Issue Type: Bug
Components: camel-sql
Affects Versions: 2.11.0
Reporter: Sergey Galkin
Due the bug in the DefaultSqlPrepareStatementStrategy there no ability to use
NULL values.
Following query will be failed, if we try to use NULL as a parameter value:
bq. select a, b from foo where (:#param1 IS NOT NULL AND a > 12 ) OR (:#param2
IS NOT NULL AND b > 12)
We'll get an error:
{quote}
Caused by: java.sql.SQLException: Number of parameters mismatch. Expected: 4,
was:2
at
org.apache.camel.component.sql.DefaultSqlPrepareStatementStrategy.populateStatement(DefaultSqlPrepareStatementStrategy.java:132)
~[camel-sql-2.11.0.jar:2.11.0]
at
org.apache.camel.component.sql.SqlProducer$1.doInPreparedStatement(SqlProducer.java:74)
~[camel-sql-2.11.0.jar:2.11.0]
at
org.apache.camel.component.sql.SqlProducer$1.doInPreparedStatement(SqlProducer.java:57)
~[camel-sql-2.11.0.jar:2.11.0]
at
org.springframework.jdbc.core.JdbcTemplate.execute(JdbcTemplate.java:587)
~[spring-jdbc-3.1.4.RELEASE.jar:3.1.4.RELEASE]
{quote}
Fix is quite simple: iterator implementation (returned by
DefaultSqlPrepareStatementStrategy.createPopulateIterator()) should be changed
as follows:
{code:java}
return new Iterator<Object>() {
private NamedQueryParser parser = new
NamedQueryParser(query);
private String nextParam;
private boolean done;
@Override
public boolean hasNext() {
if (done) {
return false;
}
if (nextParam == null) {
nextParam = parser.next();
if (nextParam == null) {
done = true;
}
}
return nextParam != null;
}
@Override
public Object next() {
if(!hasNext()){
throw new NoSuchElementException();
}
boolean contains = bodyMap != null ?
bodyMap.containsKey(nextParam) : false;
contains |= headerMap != null ?
headerMap.containsKey(nextParam) : false;
if (!contains) {
throw new RuntimeExchangeException("Cannot find key
[" + nextParam + "] in message body or headers to use when setting named
parameter in query [" + query + "]", exchange);
}
// get from body before header
Object next = bodyMap != null ? bodyMap.get(nextParam)
: null;
if (next == null) {
next = headerMap != null ? headerMap.get(nextParam)
: null;
}
nextParam = null;
return next;
}
@Override
public void remove() {
// noop
}
};
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
