[GitHub] [carbondata] Zhangshunyu commented on issue #3567: [CARBONDATA-3656] set Default TaskNo To Avoid Conflicts when concurrently write data by SDK

2020-01-11 Thread GitBox
Zhangshunyu commented on issue #3567: [CARBONDATA-3656] set Default TaskNo To Avoid Conflicts when concurrently write data by SDK URL: https://github.com/apache/carbondata/pull/3567#issuecomment-573294141 LGTM This is an auto

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3567: [CARBONDATA-3656] set Default TaskNo To Avoid Conflicts when concurrently write data by SDK

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3567: [CARBONDATA-3656] set Default TaskNo To Avoid Conflicts when concurrently write data by SDK URL: https://github.com/apache/carbondata/pull/3567#issuecomment-573298523 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/Apac

[GitHub] [carbondata] asfgit closed pull request #3511: [CARBONDATA-3620][CARBONDATA-3622]: Update does not load cache in memory, behavior inconsistent with scenario when index server is not running

2020-01-11 Thread GitBox
asfgit closed pull request #3511: [CARBONDATA-3620][CARBONDATA-3622]: Update does not load cache in memory, behavior inconsistent with scenario when index server is not running URL: https://github.com/apache/carbondata/pull/3511 ---

[jira] [Resolved] (CARBONDATA-3620) Update does not load cache in memory, behavior inconsistent with scenario when index server is not running

2020-01-11 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3620. - Resolution: Fixed > Update does not load cache in memory, behavior inconsist

[jira] [Resolved] (CARBONDATA-3622) Error when table is dropped and is being accessed in Index Server afterwards

2020-01-11 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3622. - Resolution: Fixed > Error when table is dropped and is being accessed in Ind

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert.

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert. URL: https://github.com/apache/carbondata/pull/3538#issuecomment-573300811 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1597/ ---

[GitHub] [carbondata] QiangCai opened a new pull request #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-11 Thread GitBox
QiangCai opened a new pull request #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions URL: https://github.com/apache/carbondata/pull/3574 ### Why is this PR needed? 1. not support mv 2. Parser still use CarbonAstBuidler 3. still use carbonsession to run some testcases

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions URL: https://github.com/apache/carbondata/pull/3574#issuecomment-573309170 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1598/ --

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort compaction failure on timestamp column

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort compaction failure on timestamp column URL: https://github.com/apache/carbondata/pull/3515#issuecomment-573310579 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilde

[GitHub] [carbondata] jackylk commented on a change in pull request #3571: [CARBONDATA-3659] Fix issues with alluxio without host and port.

2020-01-11 Thread GitBox
jackylk commented on a change in pull request #3571: [CARBONDATA-3659] Fix issues with alluxio without host and port. URL: https://github.com/apache/carbondata/pull/3571#discussion_r365520617 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/Block

[GitHub] [carbondata] jackylk commented on a change in pull request #3571: [CARBONDATA-3659] Fix issues with alluxio without host and port.

2020-01-11 Thread GitBox
jackylk commented on a change in pull request #3571: [CARBONDATA-3659] Fix issues with alluxio without host and port. URL: https://github.com/apache/carbondata/pull/3571#discussion_r365520720 ## File path: core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java

[GitHub] [carbondata] jackylk commented on a change in pull request #3571: [CARBONDATA-3659] Fix issues with alluxio without host and port.

2020-01-11 Thread GitBox
jackylk commented on a change in pull request #3571: [CARBONDATA-3659] Fix issues with alluxio without host and port. URL: https://github.com/apache/carbondata/pull/3571#discussion_r365520784 ## File path: core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java

[GitHub] [carbondata] jackylk commented on issue #3518: [DOC] add performance-tuning with codegen parameters support

2020-01-11 Thread GitBox
jackylk commented on issue #3518: [DOC] add performance-tuning with codegen parameters support URL: https://github.com/apache/carbondata/pull/3518#issuecomment-573316089 LGTM This is an automated message from the Apache Git S

[GitHub] [carbondata] asfgit closed pull request #3518: [DOC] add performance-tuning with codegen parameters support

2020-01-11 Thread GitBox
asfgit closed pull request #3518: [DOC] add performance-tuning with codegen parameters support URL: https://github.com/apache/carbondata/pull/3518 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [carbondata] jackylk commented on issue #3567: [CARBONDATA-3656] set Default TaskNo To Avoid Conflicts when concurrently write data by SDK

2020-01-11 Thread GitBox
jackylk commented on issue #3567: [CARBONDATA-3656] set Default TaskNo To Avoid Conflicts when concurrently write data by SDK URL: https://github.com/apache/carbondata/pull/3567#issuecomment-573317811 LGTM This is an automate

[GitHub] [carbondata] asfgit closed pull request #3567: [CARBONDATA-3656] set Default TaskNo To Avoid Conflicts when concurrently write data by SDK

2020-01-11 Thread GitBox
asfgit closed pull request #3567: [CARBONDATA-3656] set Default TaskNo To Avoid Conflicts when concurrently write data by SDK URL: https://github.com/apache/carbondata/pull/3567 This is an automated message from the Apache G

[jira] [Resolved] (CARBONDATA-3656) There are some conflicts when concurrently write data to S3

2020-01-11 Thread Jacky Li (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-3656. -- Fix Version/s: 2.0.0 Resolution: Fixed > There are some conflicts when concurrently

[GitHub] [carbondata] jackylk commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table

2020-01-11 Thread GitBox
jackylk commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table URL: https://github.com/apache/carbondata/pull/3568#discussion_r365521952 ## File path: core/src/main/java/org/apache/carbondata/

[GitHub] [carbondata] jackylk commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table

2020-01-11 Thread GitBox
jackylk commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table URL: https://github.com/apache/carbondata/pull/3568#discussion_r365522014 ## File path: core/src/main/java/org/apache/carbondata/

[GitHub] [carbondata] jackylk commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table

2020-01-11 Thread GitBox
jackylk commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table URL: https://github.com/apache/carbondata/pull/3568#discussion_r365522109 ## File path: core/src/main/java/org/apache/carbondata/

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table

2020-01-11 Thread GitBox
Indhumathi27 commented on a change in pull request #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table URL: https://github.com/apache/carbondata/pull/3568#discussion_r365522833 ## File path: core/src/main/java/org/apache/carbo

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert.

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert. URL: https://github.com/apache/carbondata/pull/3538#issuecomment-573320963 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1601/ ---

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert.

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert. URL: https://github.com/apache/carbondata/pull/3538#issuecomment-573322241 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1602/ ---

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort compaction failure on timestamp column

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3515: [CARBONDATA-3623]: Fixed global sort compaction failure on timestamp column URL: https://github.com/apache/carbondata/pull/3515#issuecomment-573323098 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilde

[GitHub] [carbondata] zzcclp opened a new pull request #3575: [HOTFIX] upgrade jdk 1.7 to 1.8 for module spark-carbon-common-test

2020-01-11 Thread GitBox
zzcclp opened a new pull request #3575: [HOTFIX] upgrade jdk 1.7 to 1.8 for module spark-carbon-common-test URL: https://github.com/apache/carbondata/pull/3575 upgrade jdk 1.7 to 1.8 for module spark-carbon-common-test ### Why is this PR needed? ### What changes were p

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3575: [HOTFIX] upgrade jdk 1.7 to 1.8 for module spark-carbon-common-test

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3575: [HOTFIX] upgrade jdk 1.7 to 1.8 for module spark-carbon-common-test URL: https://github.com/apache/carbondata/pull/3575#issuecomment-573330635 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/160

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions URL: https://github.com/apache/carbondata/pull/3574#issuecomment-573331457 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1606/ --

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3568: [CARBONDATA-3658] Prune and Cache only Matched partitioned segments for filter on Partitioned table URL: https://github.com/apache/carbondata/pull/3568#issuecomment-57504 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/

[GitHub] [carbondata] kunal642 opened a new pull request #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment

2020-01-11 Thread GitBox
kunal642 opened a new pull request #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment URL: https://github.com/apache/carbondata/pull/3474 **Problem:** Query on bloom datamap fails when there are multiple data files in one segment. **Solution:** Old

[GitHub] [carbondata] kunal642 closed pull request #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment

2020-01-11 Thread GitBox
kunal642 closed pull request #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment URL: https://github.com/apache/carbondata/pull/3474 This is an automated message from the Apache Git Serv

[GitHub] [carbondata] kunal642 commented on a change in pull request #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment

2020-01-11 Thread GitBox
kunal642 commented on a change in pull request #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment URL: https://github.com/apache/carbondata/pull/3474#discussion_r365541911 ## File path: core/src/main/java/org/apache/carbondata/core/datamap/Dat

[GitHub] [carbondata] kunal642 commented on a change in pull request #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment

2020-01-11 Thread GitBox
kunal642 commented on a change in pull request #3474: [CARBONDATA-3592] Fix query on bloom in case of multiple data files in one segment URL: https://github.com/apache/carbondata/pull/3474#discussion_r365541908 ## File path: core/src/main/java/org/apache/carbondata/core/datamap/Dat

[GitHub] [carbondata] zzcclp closed pull request #3575: [HOTFIX] upgrade jdk 1.7 to 1.8 for module spark-carbon-common-test

2020-01-11 Thread GitBox
zzcclp closed pull request #3575: [HOTFIX] upgrade jdk 1.7 to 1.8 for module spark-carbon-common-test URL: https://github.com/apache/carbondata/pull/3575 This is an automated message from the Apache Git Service. To respond t

[GitHub] [carbondata] zzcclp commented on issue #3575: [HOTFIX] upgrade jdk 1.7 to 1.8 for module spark-carbon-common-test

2020-01-11 Thread GitBox
zzcclp commented on issue #3575: [HOTFIX] upgrade jdk 1.7 to 1.8 for module spark-carbon-common-test URL: https://github.com/apache/carbondata/pull/3575#issuecomment-573366714 Close this pr, spark-carbon-common-test will be removed in pr #3574 .

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert.

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert. URL: https://github.com/apache/carbondata/pull/3538#issuecomment-573371968 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1607/ ---

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions

2020-01-11 Thread GitBox
CarbonDataQA1 commented on issue #3574: [CARBONDATA-3503] Optimize Carbon SparkExtensions URL: https://github.com/apache/carbondata/pull/3574#issuecomment-573377016 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1608/ --

[GitHub] [carbondata] xubo245 commented on issue #3526: [CARBONDATA-3627] C++ SDK support write data withSchemaFile

2020-01-11 Thread GitBox
xubo245 commented on issue #3526: [CARBONDATA-3627] C++ SDK support write data withSchemaFile URL: https://github.com/apache/carbondata/pull/3526#issuecomment-573389824 @jackylk @zzcclp optimized the comments. Please review it again.

[GitHub] [carbondata] xubo245 commented on a change in pull request #3526: [CARBONDATA-3627] C++ SDK support write data withSchemaFile

2020-01-11 Thread GitBox
xubo245 commented on a change in pull request #3526: [CARBONDATA-3627] C++ SDK support write data withSchemaFile URL: https://github.com/apache/carbondata/pull/3526#discussion_r365562824 ## File path: store/CSDK/test/main.cpp ## @@ -740,6 +740,130 @@ bool testWriteData(JNI

[GitHub] [carbondata] xubo245 commented on a change in pull request #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-11 Thread GitBox
xubo245 commented on a change in pull request #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow URL: https://github.com/apache/carbondata/pull/3479#discussion_r365562983 ## File path: python/pycarbon/README.md ## @@ -0,0 +1,53 @@ +# PyCarbon + +Optim

[GitHub] [carbondata] xubo245 commented on a change in pull request #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-11 Thread GitBox
xubo245 commented on a change in pull request #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow URL: https://github.com/apache/carbondata/pull/3479#discussion_r365563240 ## File path: python/pycarbon/reader.py ## @@ -0,0 +1,202 @@ +# Licensed to the

[GitHub] [carbondata] xubo245 commented on a change in pull request #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-11 Thread GitBox
xubo245 commented on a change in pull request #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow URL: https://github.com/apache/carbondata/pull/3479#discussion_r365564219 ## File path: python/pycarbon/integration/tensorflow.py ## @@ -0,0 +1,358 @@ +#

[GitHub] [carbondata] xubo245 commented on a change in pull request #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-11 Thread GitBox
xubo245 commented on a change in pull request #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow URL: https://github.com/apache/carbondata/pull/3479#discussion_r365564279 ## File path: python/pycarbon/etl/carbon_dataset_metadata.py ## @@ -0,0 +1,235 @

[GitHub] [carbondata] xubo245 commented on issue #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-11 Thread GitBox
xubo245 commented on issue #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow URL: https://github.com/apache/carbondata/pull/3479#issuecomment-573391580 optimized, please review it again. This is an auto

[GitHub] [carbondata] xubo245 edited a comment on issue #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-11 Thread GitBox
xubo245 edited a comment on issue #3479: [ CARBONDATA-3271] Integrating deep learning framework TensorFlow URL: https://github.com/apache/carbondata/pull/3479#issuecomment-573391580 optimized, please review it again. @jackylk --