[GitHub] [carbondata] CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert.

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert. URL: https://github.com/apache/carbondata/pull/3538#issuecomment-580603426 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1815/ ---

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

2020-01-30 Thread GitBox
Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries URL: https://github.com/apache/carbondata/pull/3495#discussion_r373327070 ## File path: datamap/mv/core/src/test/scala/org/apache/carbondata/mv/timeseries/Test

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

2020-01-30 Thread GitBox
Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries URL: https://github.com/apache/carbondata/pull/3495#discussion_r373326774 ## File path: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/M

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

2020-01-30 Thread GitBox
Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries URL: https://github.com/apache/carbondata/pull/3495#discussion_r373326873 ## File path: datamap/mv/core/src/test/scala/org/apache/carbondata/mv/timeseries/Test

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

2020-01-30 Thread GitBox
Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries URL: https://github.com/apache/carbondata/pull/3495#discussion_r373326730 ## File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/Navigat

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

2020-01-30 Thread GitBox
Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries URL: https://github.com/apache/carbondata/pull/3495#discussion_r373326636 ## File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelpe

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

2020-01-30 Thread GitBox
Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries URL: https://github.com/apache/carbondata/pull/3495#discussion_r373326593 ## File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelpe

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

2020-01-30 Thread GitBox
Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries URL: https://github.com/apache/carbondata/pull/3495#discussion_r373326534 ## File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelpe

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

2020-01-30 Thread GitBox
Indhumathi27 commented on a change in pull request #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries URL: https://github.com/apache/carbondata/pull/3495#discussion_r373326664 ## File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/Navigat

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive

2020-01-30 Thread GitBox
akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive URL: https://github.com/apache/carbondata/pull/3541#discussion_r373320221 ## File path: datamap/mv/core/src/test/scala/o

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive

2020-01-30 Thread GitBox
akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive URL: https://github.com/apache/carbondata/pull/3541#discussion_r373319016 ## File path: datamap/mv/core/src/main/scala/o

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive

2020-01-30 Thread GitBox
akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive URL: https://github.com/apache/carbondata/pull/3541#discussion_r373319541 ## File path: datamap/mv/core/src/main/scala/o

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive

2020-01-30 Thread GitBox
akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive URL: https://github.com/apache/carbondata/pull/3541#discussion_r373319253 ## File path: datamap/mv/core/src/main/scala/o

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive

2020-01-30 Thread GitBox
akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive URL: https://github.com/apache/carbondata/pull/3541#discussion_r373319949 ## File path: datamap/mv/core/src/main/scala/o

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive

2020-01-30 Thread GitBox
akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive URL: https://github.com/apache/carbondata/pull/3541#discussion_r373319428 ## File path: datamap/mv/core/src/main/scala/o

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive

2020-01-30 Thread GitBox
akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive URL: https://github.com/apache/carbondata/pull/3541#discussion_r373317237 ## File path: datamap/mv/core/src/main/scala/o

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive

2020-01-30 Thread GitBox
akashrn5 commented on a change in pull request #3541: [CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in query is given case insensitive URL: https://github.com/apache/carbondata/pull/3541#discussion_r373316719 ## File path: datamap/mv/core/src/main/scala/o

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3598: [WIP] Remove MDK and cardinality in write path

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3598: [WIP] Remove MDK and cardinality in write path URL: https://github.com/apache/carbondata/pull/3598#issuecomment-580584017 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1814/ -

[GitHub] [carbondata] jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r373309450 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/conv

[GitHub] [carbondata] ajantha-bhat commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-30 Thread GitBox
ajantha-bhat commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-580571302 LGTM Need to have one good doc

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And a

2020-01-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373307776 ## File pat

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And a

2020-01-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373298768 ## File pat

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And a

2020-01-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373296382 ## File pat

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3598: [WIP] Remove MDK and cardinality in write path

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3598: [WIP] Remove MDK and cardinality in write path URL: https://github.com/apache/carbondata/pull/3598#issuecomment-580452081 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1813/ -

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-580422600 Build Success with Spark 2.3.4, Plea

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3598: [WIP] Remove MDK and cardinality in write path

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3598: [WIP] Remove MDK and cardinality in write path URL: https://github.com/apache/carbondata/pull/3598#issuecomment-580412489 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1812/ -

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-580367981 Build Failed with Spark 2.3.4, Plea

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373046713 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373044373 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373042570 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373042454 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373041437 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373038067 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373040378 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373038264 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373039872 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373037031 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373033839 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373033034 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373032254 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373030952 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373030361 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373028753 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373028577 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373027979 ## File pa

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And

2020-01-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#discussion_r373027929 ## File pa

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3598: [WIP] Remove MDK and cardinality in write path

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3598: [WIP] Remove MDK and cardinality in write path URL: https://github.com/apache/carbondata/pull/3598#issuecomment-580303559 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1808/ -

[GitHub] [carbondata] jackylk opened a new pull request #3598: [WIP] Remove MDK and cardinality in write path

2020-01-30 Thread GitBox
jackylk opened a new pull request #3598: [WIP] Remove MDK and cardinality in write path URL: https://github.com/apache/carbondata/pull/3598 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface chan

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-580281804 Build Success with Spark 2.3.4, Plea

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-580245497 Build Failed with Spark 2.3.4, Plea

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3495: [CARBONDATA-3532] Support Query Rollup for MV TimeSeries Queries URL: https://github.com/apache/carbondata/pull/3495#issuecomment-580238036 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1805/

[GitHub] [carbondata] jackylk commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws

2020-01-30 Thread GitBox
jackylk commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws URL: https://github.com/apache/carbondata/pull/3597#issuecomment-580209672 @ajantha-bhat I do not think checkstyle can check this, since it is needs to understand the API semantic ---

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#issuecomment-580196993 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPR

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3596: [CARBONDATA-3673] Remove unused declarations

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3596: [CARBONDATA-3673] Remove unused declarations URL: https://github.com/apache/carbondata/pull/3596#issuecomment-580187468 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1803/ ---

[GitHub] [carbondata] jackylk commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws

2020-01-30 Thread GitBox
jackylk commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws URL: https://github.com/apache/carbondata/pull/3597#issuecomment-580164635 I checked it using IntelliJ's Analyzer This is an automated mess

[GitHub] [carbondata] jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372838310 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/Tab

[GitHub] [carbondata] jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372836145 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/sche

[GitHub] [carbondata] jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372836461 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/Tab

[GitHub] [carbondata] jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372836461 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/Tab

[GitHub] [carbondata] jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372836145 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/sche

[GitHub] [carbondata] ajantha-bhat commented on issue #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
ajantha-bhat commented on issue #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#issuecomment-580155563 Also I hope Encoding.Dictionary is not used for local dictionary, I will cross check. May be n

[GitHub] [carbondata] ajantha-bhat commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws

2020-01-30 Thread GitBox
ajantha-bhat commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws URL: https://github.com/apache/carbondata/pull/3597#issuecomment-580153938 @jackylk : how to make sure this PR has removed all the redundant exception throwing ? and make sure new PR don't add an

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372827270 ## File path: core/src/main/java/org/apache/carbondata/core/datastor

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372825697 ## File path: core/src/main/java/org/apache/carbondata/core/metadata

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372825333 ## File path: core/src/main/java/org/apache/carbondata/core/metadata

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372821631 ## File path: core/src/main/java/org/apache/carbondata/core/datastor

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372822576 ## File path: core/src/main/java/org/apache/carbondata/core/metadata

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage

2020-01-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674] remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage URL: https://github.com/apache/carbondata/pull/3595#discussion_r372821631 ## File path: core/src/main/java/org/apache/carbondata/core/datastor

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3597: [CARBONDATA-3575] Remove redundant exception throws URL: https://github.com/apache/carbondata/pull/3597#issuecomment-580139640 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1801/

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3596: [CARBONDATA-3673] Remove unused declarations

2020-01-30 Thread GitBox
CarbonDataQA1 commented on issue #3596: [CARBONDATA-3673] Remove unused declarations URL: https://github.com/apache/carbondata/pull/3596#issuecomment-580138078 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1802/ ---