[GitHub] [carbondata] ajantha-bhat commented on pull request #3787: [CARBONDATA-3923] support global sort for SI

ajantha-bhat commented on pull request #3787: URL: https://github.com/apache/carbondata/pull/3787#issuecomment-689992523 @QiangCai , @akashrn5 @kunal642 : please start review. Complex type testcase and some more testcases can be added. I will add in 2 hours

[jira] [Created] (CARBONDATA-3978) Adding support for trash folder, where all the carbondata files will go after deletion of a segment. and clean files refactoring

Vikram Ahuja created CARBONDATA-3978: Summary: Adding support for trash folder, where all the carbondata files will go after deletion of a segment. and clean files refactoring Key: CARBONDATA-3978 URL:

[GitHub] [carbondata] vikramahuja1001 commented on pull request #3917: [WIP] clean files refactor

vikramahuja1001 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689983615 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] kunal642 commented on a change in pull request #3908: [CARBONDATA-3967] cache partition on select to enable faster pruning

kunal642 commented on a change in pull request #3908: URL: https://github.com/apache/carbondata/pull/3908#discussion_r486057999 ## File path: integration/spark/src/main/scala/org/apache/spark/util/PartitionCacheManger.scala ## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r486048413 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java ## @@ -117,6 +122,16 @@ public

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r486048290 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java ## @@ -117,6 +122,16 @@ public

[GitHub] [carbondata] QiangCai commented on a change in pull request #3908: [CARBONDATA-3967] cache partition on select to enable faster pruning

QiangCai commented on a change in pull request #3908: URL: https://github.com/apache/carbondata/pull/3908#discussion_r486038703 ## File path: integration/spark/src/main/scala/org/apache/spark/util/PartitionCacheManger.scala ## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] QiangCai commented on pull request #3902: [CARBONDATA-3961] reorder filter expression based on storage ordinal

QiangCai commented on pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#issuecomment-689947452 please rebase code This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] QiangCai commented on pull request #3917: [WIP] clean files refactor

QiangCai commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689946875 please describe the detail of the strategy. This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [WIP] clean files refactor

CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689858430 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2289/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [WIP] clean files refactor

CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689856094 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4028/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-689784831 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4026/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-689784286 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2287/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3914: [WIP] Added Hive test for read and local dictionary support.

CarbonDataQA1 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-689767522 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4025/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3914: [WIP] Added Hive test for read and local dictionary support.

CarbonDataQA1 commented on pull request #3914: URL: https://github.com/apache/carbondata/pull/3914#issuecomment-689764177 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2286/

[GitHub] [carbondata] Karan-c980 commented on pull request #3876: TestingCI

Karan-c980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-689721230 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3787: [WIP][CARBONDATA-3923] support global sort for SI

CarbonDataQA1 commented on pull request #3787: URL: https://github.com/apache/carbondata/pull/3787#issuecomment-689696689 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2285/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3787: [WIP][CARBONDATA-3923] support global sort for SI

CarbonDataQA1 commented on pull request #3787: URL: https://github.com/apache/carbondata/pull/3787#issuecomment-689693694 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4023/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [WIP] clean files refactor

CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689683149 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4022/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [WIP] clean files refactor

CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689682451 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2284/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #1351: Add maven-antrun-plugin into build profiles so that class files of different profiles do not clash when genrating coverage report

CarbonDataQA1 commented on pull request #1351: URL: https://github.com/apache/carbondata/pull/1351#issuecomment-689669748 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4024/

[jira] [Resolved] (CARBONDATA-3865) Implement delete and update feature in carbondata SDK.

[ https://issues.apache.org/jira/browse/CARBONDATA-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-3865. -- Fix Version/s: 2.1.0 Resolution: Fixed > Implement delete and update

[GitHub] [carbondata] asfgit closed pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

asfgit closed pull request #3834: URL: https://github.com/apache/carbondata/pull/3834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] kunal642 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

kunal642 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689663325 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (CARBONDATA-3855) Support Carbondata SDK to load data from parquet, ORC, CSV, Avro and JSON.

[ https://issues.apache.org/jira/browse/CARBONDATA-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat updated CARBONDATA-3855: - Fix Version/s: 2.1.0 > Support Carbondata SDK to load data from parquet, ORC, CSV,

[GitHub] [carbondata] asfgit closed pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

asfgit closed pull request #3819: URL: https://github.com/apache/carbondata/pull/3819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] ajantha-bhat commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

ajantha-bhat commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-689648572 Merging on behalf of @xubo245 I didn't get time to fully review. If any refactor required can handle in new PR.

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-689623335 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4020/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-689623460 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2282/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689616290 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2281/

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3917: [WIP] clean files refactor

Indhumathi27 commented on a change in pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#discussion_r485655081 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -1106,19 +1107,39 @@ public static void

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689609867 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4019/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3787: [WIP][CARBONDATA-3923] support global sort for SI

CarbonDataQA1 commented on pull request #3787: URL: https://github.com/apache/carbondata/pull/3787#issuecomment-689598895 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2279/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3787: [WIP][CARBONDATA-3923] support global sort for SI

CarbonDataQA1 commented on pull request #3787: URL: https://github.com/apache/carbondata/pull/3787#issuecomment-689598077 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4018/

[GitHub] [carbondata] kunal642 commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

kunal642 commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485651703 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataModule.java ## @@ -21,6 +21,8 @@ import static

[GitHub] [carbondata] kunal642 commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

kunal642 commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485651041 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java ## @@ -0,0 +1,196 @@ +/* + *

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485642687 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java ## @@ -0,0 +1,196 @@ +/* +

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485642687 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java ## @@ -0,0 +1,196 @@ +/* +

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485640004 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java ## @@ -117,6 +122,16 @@ public

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485640004 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java ## @@ -117,6 +122,16 @@ public

[GitHub] [carbondata] kunal642 commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

kunal642 commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485638458 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java ## @@ -0,0 +1,196 @@ +/* + *

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485636502 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java ## @@ -0,0 +1,196 @@ +/* +

[GitHub] [carbondata] kunal642 commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

kunal642 commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485636199 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java ## @@ -117,6 +122,16 @@ public

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485635431 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java ## @@ -117,6 +122,16 @@ public

[GitHub] [carbondata] kunal642 commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

kunal642 commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485634681 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java ## @@ -0,0 +1,196 @@ +/* + *

[GitHub] [carbondata] kunal642 commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

kunal642 commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485630147 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java ## @@ -117,6 +122,16 @@ public

[GitHub] [carbondata] akashrn5 commented on pull request #3911: [CARBONDATA-3793]Fix update and delete issue when multiple partition columns are present and clean files issue

akashrn5 commented on pull request #3911: URL: https://github.com/apache/carbondata/pull/3911#issuecomment-689577551 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485628731 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataModule.java ## @@ -21,6 +21,8 @@ import static

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

ajantha-bhat commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485628731 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataModule.java ## @@ -21,6 +21,8 @@ import static

[GitHub] [carbondata] kunal642 commented on a change in pull request #3913: [CARBONDATA-3974] Improve partition purning performance in presto carbon integration

kunal642 commented on a change in pull request #3913: URL: https://github.com/apache/carbondata/pull/3913#discussion_r485626615 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataModule.java ## @@ -21,6 +21,8 @@ import static

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [WIP] clean files refactor

CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689552007 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2277/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [WIP] clean files refactor

CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689551682 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4016/

[GitHub] [carbondata] Karan-c980 commented on pull request #3876: TestingCI

Karan-c980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-689550512 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Karan-c980 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

Karan-c980 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r485548941 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonIUD.java ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] Karan-c980 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

Karan-c980 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r485548849 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonIUD.java ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689507898 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4017/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689507261 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2278/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [WIP] clean files refactor

CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689476907 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4015/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [WIP] clean files refactor

CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-689476467 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2276/

[GitHub] [carbondata] vikramahuja1001 opened a new pull request #3917: [WIP] clean files refactor

vikramahuja1001 opened a new pull request #3917: URL: https://github.com/apache/carbondata/pull/3917 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689408106 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4014/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689403708 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2275/

[GitHub] [carbondata] ShreelekhyaG closed pull request #3909: [CARBONDATA-3972] Date/timestamp compatability between hive and carbon

ShreelekhyaG closed pull request #3909: URL: https://github.com/apache/carbondata/pull/3909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] kunal642 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

kunal642 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r485382685 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonIUD.java ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] kunal642 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

kunal642 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r48538 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonIUD.java ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] kunal642 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

kunal642 commented on a change in pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#discussion_r485374393 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonIUD.java ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] kunal642 removed a comment on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

kunal642 removed a comment on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689111283 LGTM This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [carbondata] Karan-c980 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

Karan-c980 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689330741 > @Karan-c980 Please rebase, dont use merge to pull the new code. > Merge commit should not be there Done

[GitHub] [carbondata] Karan-c980 removed a comment on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

Karan-c980 removed a comment on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689330508 done This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [carbondata] Karan-c980 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

Karan-c980 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-689330508 done This is an automated message from the Apache Git Service. To respond to the message, please log on