[
https://issues.apache.org/jira/browse/CARBONDATA-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225875#comment-17225875
]
Ajantha Bhat commented on CARBONDATA-2827:
--
CarbonDataQA1 commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-721392387
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3015/
CarbonDataQA1 commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-721392003
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4773/
CarbonDataQA1 commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-721344165
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4772/
CarbonDataQA1 commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-721343938
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3014/
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516851234
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/TrashUtil.java
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516850514
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/TrashUtil.java
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516841463
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/TrashUtil.java
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516840202
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/TrashUtil.java
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
dependabot[bot] commented on pull request #3447:
URL: https://github.com/apache/carbondata/pull/3447#issuecomment-721270655
Dependabot tried to update this pull request, but something went wrong.
We're looking into it, but in the meantime you can retry the update by
commenting
dependabot[bot] commented on pull request #3456:
URL: https://github.com/apache/carbondata/pull/3456#issuecomment-721270443
Dependabot tried to update this pull request, but something went wrong.
We're looking into it, but in the meantime you can retry the update by
commenting
CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-721266363
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3012/
CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-721263694
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4770/
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516828124
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/TrashUtil.java
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516807830
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala
##
@@ -48,13
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516806745
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala
##
@@ -80,40
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516803097
##
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##
@@ -3441,4 +3443,33 @@ public static void
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516802654
##
File path:
processing/src/main/java/org/apache/carbondata/processing/loading/TableProcessingOperations.java
##
@@ -149,9 +132,167 @@
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516803267
##
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##
@@ -3441,4 +3443,33 @@ public static void
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516802032
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala
##
@@ -80,40
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516802253
##
File path:
processing/src/main/java/org/apache/carbondata/processing/loading/TableProcessingOperations.java
##
@@ -149,9 +132,167 @@
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516800475
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala
##
@@ -80,40
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516799647
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala
##
@@ -48,13
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516798767
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/cleanfiles/CleanFilesUtil.scala
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516798306
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/cleanfiles/CleanFilesUtil.scala
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516797523
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/cleanfiles/CleanFilesUtil.scala
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516796678
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/cleanfiles/CleanFilesUtil.scala
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516795339
##
File path: core/src/main/java/org/apache/carbondata/core/util/CleanUtil.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516793794
##
File path: docs/dml-of-carbondata.md
##
@@ -560,5 +561,4 @@ CarbonData DML statements are documented here,which
includes:
Clean the
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516793523
##
File path: docs/dml-of-carbondata.md
##
@@ -27,6 +27,7 @@ CarbonData DML statements are documented here,which includes:
* [UPDATE AND
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516792757
##
File path: docs/cleanfiles.md
##
@@ -0,0 +1,78 @@
+
+
+
+## CLEAN FILES
+
+Clean files command is used to remove the Compacted, Marked For
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516793022
##
File path: docs/cleanfiles.md
##
@@ -0,0 +1,78 @@
+
+
+
+## CLEAN FILES
+
+Clean files command is used to remove the Compacted, Marked For
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516792560
##
File path: docs/cleanfiles.md
##
@@ -0,0 +1,78 @@
+
+
+
+## CLEAN FILES
+
+Clean files command is used to remove the Compacted, Marked For
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516791220
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/TrashUtil.java
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516790181
##
File path: core/src/main/java/org/apache/carbondata/core/util/CleanUtil.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516789854
##
File path:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
##
@@ -2116,6 +2087,28 @@ public int
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516789762
##
File path:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##
@@ -1427,6 +1427,23 @@ private
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516789476
##
File path: core/src/main/java/org/apache/carbondata/core/util/CleanUtil.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516789597
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/TrashUtil.java
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516788672
##
File path: core/src/main/java/org/apache/carbondata/core/util/CleanUtil.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r516787255
##
File path:
core/src/main/java/org/apache/carbondata/core/util/path/TrashUtil.java
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-721147068
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4769/
CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-721146477
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3011/
asfgit closed pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kunal642 commented on pull request #3952:
URL: https://github.com/apache/carbondata/pull/3952#issuecomment-720455512
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
asfgit closed pull request #3995:
URL: https://github.com/apache/carbondata/pull/3995
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
CarbonDataQA1 commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-720280224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
QiangCai commented on a change in pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#discussion_r515768710
##
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
##
@@ -101,8 +101,8 @@ public
ajantha-bhat commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-720242738
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
vikramahuja1001 commented on a change in pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#discussion_r515789003
##
File path: docs/cleanfiles.md
##
@@ -0,0 +1,78 @@
+
+
+
+## CLEAN FILES
+
+Clean files command is used to remove the Compacted, Marked For
kunal642 commented on pull request #3995:
URL: https://github.com/apache/carbondata/pull/3995#issuecomment-720252675
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
marchpure commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-720270269
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nihal0107 opened a new pull request #4002:
URL: https://github.com/apache/carbondata/pull/4002
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the
akashrn5 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-720916001
@ShreelekhyaG please add SI and update, delete behavior also in the PR
description
This is an automated
ajantha-bhat commented on a change in pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#discussion_r515759986
##
File path:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##
@@ -808,19 +808,6 @@ private
CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-720330566
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
QiangCai commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-720927959
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
akashrn5 commented on a change in pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#discussion_r515746959
##
File path:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##
@@ -361,6 +361,11 @@ private
ajantha-bhat commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-720258234
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
akkio-97 opened a new pull request #4001:
URL: https://github.com/apache/carbondata/pull/4001
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the
CarbonDataQA1 commented on pull request #3995:
URL: https://github.com/apache/carbondata/pull/3995#issuecomment-720292622
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
QiangCai commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-720948859
about dry_run part, this pr write new code to implement it. better to reuse
code.
This is an automated
CarbonDataQA1 commented on pull request #4002:
URL: https://github.com/apache/carbondata/pull/4002#issuecomment-720944470
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kunal642 commented on a change in pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#discussion_r516152662
##
File path:
core/src/main/java/org/apache/carbondata/core/readcommitter/TableStatusReadCommittedScope.java
##
@@ -79,13 +83,24 @@ public
ShreelekhyaG commented on a change in pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#discussion_r515750468
##
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
##
@@ -368,12 +373,21 @@ public
CarbonDataQA1 commented on pull request #4001:
URL: https://github.com/apache/carbondata/pull/4001#issuecomment-720622523
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
asfgit closed pull request #3952:
URL: https://github.com/apache/carbondata/pull/3952
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vikramahuja1001 commented on pull request #3917:
URL: https://github.com/apache/carbondata/pull/3917#issuecomment-720367406
retest this please
This is an automated message from the Apache Git Service.
To respond to the
marchpure commented on a change in pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#discussion_r515819017
##
File path:
processing/src/main/java/org/apache/carbondata/processing/merger/CompactionType.java
##
@@ -26,7 +26,6 @@
public enum CompactionType
CarbonDataQA1 commented on pull request #3952:
URL: https://github.com/apache/carbondata/pull/3952#issuecomment-720511467
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-720655263
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ajantha-bhat edited a comment on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-720258234
@shenjiayu17 & @marchpure @QiangCai : **Have you analyzed which exact
change is responsible for performance improvement?** I don't think it is
because of
[
https://issues.apache.org/jira/browse/CARBONDATA-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225320#comment-17225320
]
Karan commented on CARBONDATA-4029:
---
SDK written data present at above location have invalid
73 matches
Mail list logo