Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246317595
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -575,19 +575,23 @@ public static Dictionary
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246299802
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -1164,4 +1156,35 @@ private static void
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246299700
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -609,6 +597,10 @@ public static Dictionary
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/3059
[HOTFIX][DataLoad]fix task assignment issue using NODE_MIN_SIZE_FIRST block
assignment strategy
fix task assignment issue using NODE_MIN_SIZE_FIRST block assignment
strategy
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2864
retest this please
---
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228792020
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -1171,21 +1171,25 @@ object
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228791974
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -833,4 +833,32 @@ object CommonUtil
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228791841
--- Diff: docs/ddl-of-carbondata.md ---
@@ -474,7 +475,19 @@ CarbonData DDL statements are documented here,which
includes:
be later viewed
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228708281
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -1171,12 +1171,27 @@ object
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228708277
--- Diff: docs/ddl-of-carbondata.md ---
@@ -474,7 +475,22 @@ CarbonData DDL statements are documented here,which
includes:
be later viewed
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228708250
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala
---
@@ -123,6 +123,12
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228708257
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -833,4 +833,26 @@ object CommonUtil
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228708260
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala ---
@@ -748,4 +752,18 @@ object AlterTableUtil
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228708269
--- Diff: docs/ddl-of-carbondata.md ---
@@ -474,7 +475,22 @@ CarbonData DDL statements are documented here,which
includes:
be later viewed
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228708254
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -833,4 +833,26 @@ object CommonUtil
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228708258
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -1171,12 +1171,27 @@ object
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2864#discussion_r228708265
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
---
@@ -186,8 +186,7 @@
optionsFinal.put
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2864
[CARBONDATA-3041] Optimize load minimum size strategy for data loading
this PR modifies the following points:
1. Delete system property carbon.load.min.size.enabledï¼modified this
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2843#discussion_r227626868
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -23,86 +23,26 @@
import
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2843
[CARBONDATA-3034] Carding parameters,Organized by parameter category.
This PR is mainly combing parameters, organized by parameter category.
Be sure to do all of the following
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2627
retest sdv please
---
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2627#discussion_r210787370
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
@@ -237,6 +237,21 @@ object CarbonEnv {
getCarbonTable
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2627
retest sdv please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2627
retest sdv please
---
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2627#discussion_r210241324
--- Diff:
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala
---
@@ -80,6 +81,16 @@ object MVHelper
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2627#discussion_r210241115
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
---
@@ -73,13 +73,8
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2627#discussion_r210239499
--- Diff:
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala
---
@@ -80,6 +81,16 @@ object MVHelper
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2627#discussion_r210239381
--- Diff:
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala
---
@@ -80,6 +81,16 @@ object MVHelper
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2627
retest this please
---
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2627
[CARBONDATA-2835] [MVDataMap] Block MV datamap on streaming table
This PR block creating MV datamap on streaming table and also block
setting streaming property for table which has MV
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2601
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2601
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2601
retest this please
---
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2601#discussion_r207430989
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3212,28 +3213,27 @@ public static ColumnarFormatVersion
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2601#discussion_r207430964
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3212,28 +3213,27 @@ public static ColumnarFormatVersion
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2601#discussion_r207430996
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3212,28 +3213,27 @@ public static ColumnarFormatVersion
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2601
retest this please
---
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2601
[CARBONDATA-2804][DataMap] fix the bug when bloom filter or preaggregate
datamap tried to be created on older V1-V2 version stores
[CARBONDATA-2804] fix the bug when bloom filter or
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2520#discussion_r204973033
--- Diff: docs/data-management-on-carbondata.md ---
@@ -122,6 +122,45 @@ This tutorial is going to introduce all commands and
data operations on
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest sdv please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest this please
---
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2488#discussion_r202878487
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3231,4 +3231,42 @@ private static int
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2452
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest sdv please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest sdv please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2483
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2483
modified according to comments
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest sdv please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2488
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2452
retest this please
---
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2488
[CARBONDATA-2724][DataMap]Unsupported create datamap on table with V1 or V2
format data
[CARBONDATA-2724]Unsupported create datamap on table with V1 or V2 format
data
Be sure to do
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2483
[CARBONDATA-2719]Table update/delete is needed block on table having
datamaps
[CARBONDATA-2719]Table update/delete is needed block on table having
datamaps
Be sure to do all
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2452#discussion_r200910733
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
---
@@ -172,6 +174,48 @@ public void dropDataMapSchema
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2452#discussion_r200910555
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -2814,6 +2817,22 @@ public static boolean
hasAggregationDataMap
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2452#discussion_r200910090
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -2814,6 +2817,22 @@ public static boolean
hasAggregationDataMap
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2452
retest this please
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2452
retest this please
---
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2452
[CARBONDATA-2693][BloomDataMap]Fix bug for alter rename is renameing the
existing table on which bloomfilter datamp exists
Fix bug for alter rename is renameing the existing table on which
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2397
@chenliang613 This parameter controls how large sort temp file merge in
memory
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2397
retest this case please
---
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2414#discussion_r199112802
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java
---
@@ -88,13 +88,25
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2414
[CARBONDATA-2658][DataLoad]No difference in memory spilled to disk for any
value of carbon.load.sortMemory.spill.percentage
the parameter carbon.load.sortMemory.spill.percentage configured
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2407
[CARBONDATA-2646][DataLoad]change the log level while loading data into a
table with 'sort_column_bounds' property,'ERROR' flag change to 'WARN' flag for
some expec
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2397#discussion_r197688967
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithUnsafeMemory.scala
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2397#discussion_r197688936
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonLoadOptionConstants.java
---
@@ -144,8 +144,8 @@
* If the sort
GitHub user ndwangsen reopened a pull request:
https://github.com/apache/carbondata/pull/2397
[CARBONDATA-2644][Dataload]ADD carbon.load.sortMemory.spill.percentage
parameter invalid value check
Be sure to do all of the following checklist to help us incorporate
your
Github user ndwangsen closed the pull request at:
https://github.com/apache/carbondata/pull/2397
---
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2397
[HOTFIX]ADD carbon.load.sortMemory.spill.percentage parameter invalid
value check
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2371
I just prepared to modify and found that you have modified ^-^.
---
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2314#discussion_r190776632
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -575,11 +577,12 @@ public static Dictionary
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2314
@kumarvishal09 If the user specifies or default that the minimum data load
of the node is less than the average data amount of each node, the existing
strategy is used to handle
---
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/2314
@kumarvishal09 Yeah, I Has been modified in accordance with xuchuanyin's
proposal, adding a strategy,this strategy targets to loading small amount of
input data, Avoid generating a
Github user ndwangsen closed the pull request at:
https://github.com/apache/carbondata/pull/2314
---
GitHub user ndwangsen reopened a pull request:
https://github.com/apache/carbondata/pull/2314
[CARBONDATA-2309][DataLoad] Add strategy to generate bigger carbondata
files in case of small amoâ¦
In some scenario, the input amount of loading data is small, but carbondata
still
GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2314
[CarbonData-2309][DataLoad] Add strategy to generate bigger carbondata
files in case of small amoâ¦
In some scenario, the input amount of loading data is small, but carbondata
still
Github user ndwangsen commented on the issue:
https://github.com/apache/carbondata/pull/1559
nice jobï¼loading performance is improved obviouslyã
---
80 matches
Mail list logo
