Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2726
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2726
retest this please
---
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2740
[HOTFIX] Fix partition filter slow issue
Problem: In `FileSourceScanExec` it lists all the files of partitions from
`CatalogFileIndex` , it causes another job creation to list files per
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2737
[HOTFIX] Correct metrics and avoid twice read when prefetch is disabled
When prefetch is disabled in full scan queries read twice the data. This PR
removes extra read.
Be sure to
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218790962
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -61,7 +61,7 @@
protected static final
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2706
LGTM I am merging this PR. @ajantha-bhat Please start another discussion in
the forum to support big column data up to 2GB for complex, varchar and string
columns. And also make the page
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2720
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r218415262
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
---
@@ -239,6 +239,7 @@ public void
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2706
@xuchuanyin This 2MB limit causing many issues in varchar and complex
columns. We cannot let user to configure this internal limits. We should have a
growable stream. Besides, we better
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2717
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2720
@jackylk Please rebase it.
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2725
LGTM
---
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2730
[WIP] Performance improvements for Fileformat and Presto
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218110451
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/PrimitivePageStatsCollector.java
---
@@ -140,6 +149,10 @@ private
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218109409
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java
---
@@ -139,15 +139,15
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218108240
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoderMeta.java
---
@@ -132,6 +132,10 @@ private void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218104702
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java
---
@@ -93,7 +93,22 @@ public double getDouble(int rowId
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218066737
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonMetadataUtil.java ---
@@ -250,6 +275,42 @@ public static BlockletIndex
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218062043
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
---
@@ -194,9 +198,12
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218062180
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
---
@@ -122,11 +122,11 @@ public boolean
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218061484
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -108,10 +108,13 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218060271
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/index/BlockletIndex.java
---
@@ -75,4 +80,12 @@ public void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218059894
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataRefNode.java
---
@@ -133,6 +134,21 @@
return
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218048262
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/DataRefNode.java ---
@@ -125,4 +125,12 @@ DimensionRawColumnChunk
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2719
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2708
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r218038298
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/ReUsableByteArrayDataOutputStream.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r218038401
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/ReUsableByteArrayDataOutputStream.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2714#discussion_r217737112
--- Diff:
core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ---
@@ -708,7 +708,7 @@ public static boolean isBlockInvalid
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2715
@xuchuanyin It is better if the compressor is name taken from
tableproperties.
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2717
@xubo245 Please fix the finbugs
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2702
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2720
@jackylk Please fix the test , i will merge it
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2683
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2716
retest this please
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2716
retest this please
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2683#discussion_r217323443
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/TestUtil.java ---
@@ -36,38 +36,34 @@
import
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2683#discussion_r217322845
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -168,6 +168,65 @@ public static Object
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2716
[WIP] Removed warn log level as CI console becomes very big.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2703
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2705
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r217049111
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeSortDataRows.java
---
@@ -94,21 +94,30
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r217048602
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeCarbonRowPage.java
---
@@ -59,12 +60,11 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r217048144
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/SortStepRowHandler.java
---
@@ -570,23 +589,31 @@ public int
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2704#discussion_r217021511
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
---
@@ -165,14 +165,15 @@ private static boolean
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2704#discussion_r217021636
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
---
@@ -165,14 +165,15 @@ private static boolean
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2704#discussion_r217020324
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/CarbonMetadata.java ---
@@ -143,7 +143,7 @@ public CarbonDimension
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2704#discussion_r217019741
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -476,7 +476,11 @@ private
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
@xuchuanyin yes, we cannot get rid of enum. But add another optional field
in `ChunkCompressionMeta` to take interface name. Just ignore the enum and read
only interface name.
@jackylk
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2678
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
@xuchuanyin I feel it is very necessary to save compressor name in thrift
instead of enum. It will not be a good idea to change thrift for every
compression support and also it limits the
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2705#discussion_r216620144
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java ---
@@ -36,6 +37,14 @@
private DimensionSpec[] dimensionSpec
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2709
[HOTFIX] Removed scala dependency from carbon core module
Removed scala dependencies from carbon-core and sdk modules.
Be sure to do all of the following checklist to help us
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2695#discussion_r216598273
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/StreamSQLExample.scala
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2704
retest this please
---
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2704
[HOTFIX] Old stores cannot read with new table infered through sdk.
Problem: Old stores column schema is written in the different case then
fileformat cannot read data because of sdk infer
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2698
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2690
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216208302
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java
---
@@ -290,7 +290,7 @@ private int
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216208118
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/CarbonAlterTableDropHivePartitionCommand.scala
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216207701
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java
---
@@ -135,16 +138,17 @@ private static BitSet
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216207416
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -93,26 +101,19 @@ public static long
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216207294
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -93,26 +101,19 @@ public static long
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2663
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2698
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2692
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2663
retest this please
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2663
retest this please
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
@xuchuanyin Please provide table property also for compressor name while
creating table
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2628
@xuchuanyin It is better to save compressor interface name in thrift
instead of enum. We should not change thrift for each type of compressor. We
can't let user/developer to give compr
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215859359
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
---
@@ -59,7 +59,6 @@
optionsFinal.put
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215859284
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java
---
@@ -62,6 +62,7 @@
/* Number of
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2698
@manishgupta88 Can you make the default unsafe memory manager to java
available memory in case of onheap. In this way we no need to force user about
the unsafe memory in case of onheap
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2685
@xuchuanyin This fix is not considered for otherdatamaps as we target only
for non transactional table.
And also we dctionary_include cannot be done on non transactional table
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2685#discussion_r215857396
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
---
@@ -630,6 +638,24 @@ private boolean
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2685#discussion_r215855721
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
---
@@ -631,6 +638,24 @@ private boolean
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2683
@jackylk Better print local_dictionary enabled or not in schema.
And also if possible please print the local dictionary size of each column
in column details.
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2683
```
## Summary
1 blocks, 1 shards, 1 blocklets, 9 pages, 259,304 rows, 9.95MB
## Column Statistics (column 'L_DISCOUNT')
Shard #1 (72636812283890_batch
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2683
@jackylk Better create another folder under tools
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215612715
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -311,15 +326,15 @@ public CarbonWriterBuilder
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215609931
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
---
@@ -183,7 +184,6
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215609784
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
---
@@ -59,7 +59,8 @@
optionsFinal.put
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2642
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2692
@jackylk I feel it is better to add sortscope to carbondata file. In future
if we want to do compaction it will be easy to do merge sort for batch sorted
and local sorted files. For no sort
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2690
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2645
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2642
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2644#discussion_r214883334
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
@@ -339,63 +338,62 @@ public void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2644#discussion_r214882605
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/StreamFile.java ---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2644#discussion_r214881265
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/StreamDataMap.java ---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2644#discussion_r214877591
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
---
@@ -360,6 +360,10 @@ private String
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2644#discussion_r214877452
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/StreamDataMap.java ---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2644#discussion_r214877247
--- Diff:
streaming/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordWriter.java
---
@@ -212,9 +213,13 @@ private void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2661#discussion_r214738731
--- Diff:
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonFileIndexReplaceRule.scala
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2661#discussion_r214738056
--- Diff:
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonFileIndexReplaceRule.scala
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2661#discussion_r214737987
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -268,6 +257,18 @@ public boolean accept
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2661#discussion_r214737914
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -338,6 +338,24 @@ private
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2682
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2674
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2642
@sujith71955 Please check MV module is failing with compilation issues.
http://136.243.101.176:8080/job/ManualApacheCarbonPRBuilder2.1/179/
---
401 - 500 of 9167 matches
Mail list logo
