[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-18 Thread ravipesala
Github user ravipesala closed the pull request at: https://github.com/apache/carbondata/pull/1471 ---

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151831837 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/BlockletSerializer.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151831374 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -75,7 +79,12 @@ public TableDataMap(AbsoluteTableIdentifier

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151830196 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -463,20 +426,24 @@ protected

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151830168 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -463,20 +426,24 @@ protected

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151830137 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/FGDataMapTestCase.scala --- @@ -0,0 +1,434 @@

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151828034 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/BlockletSerializer.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151827453 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -687,16 +689,17 @@ protected Expression

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151827371 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -463,20 +426,24 @@ protected void

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151827362 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -463,20 +426,24 @@ protected void

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151827225 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -463,20 +426,24 @@ protected void

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151827164 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/FGDataMapTestCase.scala --- @@ -0,0 +1,434 @@

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151639114 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/AbstractDataMapWriter.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151638182 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -755,7 +758,8 @@ private CarbonInputSplit

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151637852 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -574,7 +482,9 @@ private

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151637482 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/AbstractDataMapWriter.java --- @@ -0,0 +1,110 @@ +/* --- End diff --

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151636955 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapMeta.java --- @@ -19,15 +19,15 @@ import java.util.List;

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-16 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151615805 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/AbstractDataMapWriter.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151598459 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/AbstractDataMapWriter.java --- @@ -0,0 +1,110 @@ +/* --- End diff --

[GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...

2017-11-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1471#discussion_r151595971 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapMeta.java --- @@ -19,15 +19,15 @@ import java.util.List;