[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154962499 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala --- @@ -133,25 +133,25 @@ case class AlterTableRe

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154962772 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala --- @@ -133,25 +133,25 @@ case class AlterTableRe

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154962941 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala --- @@ -133,25 +133,25 @@ case class AlterTableRe

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154963700 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/LoadEvents.scala --- @@ -42,6 +42,14 @@ case class LoadTablePostExecutio

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154964861 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/Compactor.scala --- @@ -69,11 +69,7 @@ object Compactor { //

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154965194 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -492,6 +492,10 @@ object CarbonDataRDDFac

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154965672 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -159,7 +16

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154966099 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -159,7 +16

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154968981 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -212,4 +22

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154970020 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -212,4 +22

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154970799 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -212,4 +22

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154971443 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -212,4 +22

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154972638 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala --- @@ -130,6 +131,9 @@ case

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154972340 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -212,4 +22

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154974553 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala --- @@ -78,6 +89,57 @@ obj

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154974612 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala --- @@ -78,6 +89,57 @@ obj

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154974766 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala --- @@ -78,6 +89,57 @@ obj

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154975193 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -493,4 +493,20 @@ object

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154975703 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -172,6 +173,16 @@ private bo

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154978691 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala --- @@ -133,25 +133,25 @@ case class AlterTableR

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154978738 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala --- @@ -133,25 +133,25 @@ case class AlterTableR

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154979756 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/Compactor.scala --- @@ -69,11 +69,7 @@ object Compactor { /

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154979724 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/LoadEvents.scala --- @@ -42,6 +42,14 @@ case class LoadTablePostExecuti

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154980148 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -159,7 +1

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154980064 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -492,6 +492,10 @@ object CarbonDataRDDFa

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154980110 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -159,7 +1

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154980576 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -212,4 +2

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154980619 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -212,4 +2

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154982378 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -212,4 +2

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154982418 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -212,4 +2

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154983698 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala --- @@ -130,6 +131,9 @@ case

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154983970 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala --- @@ -78,6 +89,57 @@ ob

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154984035 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala --- @@ -78,6 +89,57 @@ ob

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154986219 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -172,6 +173,16 @@ private b

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154990350 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -172,6 +173,16 @@ private b

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154990944 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -493,4 +493,20 @@ objec

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154997789 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -172,6 +173,16 @@ private bo

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r154998197 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -493,4 +493,20 @@ object

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155244586 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala --- @@ -156,10

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155245618 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -172,6 +173,16 @@ private

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155247755 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java --- @@ -274,8 +291,11 @@ public static boolean recor

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155436882 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/Compactor.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apa

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155437020 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala --- @@ -0,0 +1,129 @@ +/* + * License

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155441909 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala --- @@ -0,0 +1,129 @@ +/* + * Licensed

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155444843 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/Compactor.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apach

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155448335 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateCompaction.scala ---

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155440643 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -541,4 +541,20 @@ objec

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155440875 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/AggregateDataMapCompactor.scala --- @@ -0,0 +1,118 @@ +/* + * Lice

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-06 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1605#discussion_r155439799 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -541,4 +541,20 @@ objec

[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

2017-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1605 ---