[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2244 ---

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-05-03 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r185807371 --- Diff: core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache So

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-05-03 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r185804764 --- Diff: core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache So

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-05-03 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r185804179 --- Diff: core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache So

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-05-03 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r185796999 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -124,32 +132,41 @@ public DataMa

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-05-03 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r185794118 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -159,16 +159,18 @@ FileFactory.mkdirs(writePath,

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-05-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r185484269 --- Diff: core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java --- @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-05-02 Thread dhatchayani
Github user dhatchayani commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r185435135 --- Diff: core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java --- @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache S

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-04-29 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r184915943 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CacheClient.java --- @@ -16,21 +16,40 @@ */ package org.apache.carbondata.h

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-04-29 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r184911430 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/expr/DataMapExprWrapperImpl.java --- @@ -86,4 +87,8 @@ public DataMapExprWrap

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-04-29 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r184915870 --- Diff: core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java --- @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-04-29 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r184914643 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -277,4 +298,30 @@ public Data

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-04-29 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2244#discussion_r184914866 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/blocklet/DataFileFooter.java --- @@ -52,7 +52,7 @@ /** * Informat

[GitHub] carbondata pull request #2244: [CARBONDATA-2310] Refactored code to improve ...

2018-04-27 Thread dhatchayani
GitHub user dhatchayani opened a pull request: https://github.com/apache/carbondata/pull/2244 [CARBONDATA-2310] Refactored code to improve Distributable interface [CARBONDATA-2362] Changing the Cacheable object from DataMap to Wrapper Be sure to do all of the following check