Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2279
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2279#discussion_r186750689
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -65,9 +65,18 @@
* and a
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2279#discussion_r186749900
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -65,9 +65,18 @@
* and a
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2279#discussion_r186724686
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -65,9 +65,18 @@
* and all
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2279#discussion_r186723961
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -65,9 +65,18 @@
* and all
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2279#discussion_r186697865
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -65,9 +65,18 @@
* and a
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2279#discussion_r186692388
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -65,9 +65,18 @@
* and all
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2279
[CARBONDATA-2454][DataMap] Add fpp property for bloom datamap
add fpp(false positive probability) property to configure bloom filter
that used by bloom datamap.
Be sure to do all
