Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2379
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196654276
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -71,7 +72,7 @@ public ColumnPageDecod
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196637400
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/LVLongStringStatsCollector.java
---
@@ -0,0 +1,50 @@
+/*
+
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196636059
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -289,6 +289,12 @@ public void putDouble(i
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196635615
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1601,6 +1602,8 @@
// As Short data type
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196635418
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -279,7 +279,7 @@ abstract class Carb
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196634986
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java
---
@@ -268,7 +268,7 @@ private DataChunk deserializeDat
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196634976
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java
---
@@ -205,7 +205,7 @@ public void setNumberOfPages(int
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196634573
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -64,7 +64,7 @@ public Colum
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196634217
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -71,7 +72,7 @@ public ColumnPageDecoder
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196633906
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java
---
@@ -103,6 +103,7 @@ private ColumnPa
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196633177
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RawColumnChunkUtil.java
---
@@ -0,0 +1,65 @@
+/*
--- End diff -
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196460046
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -279,7 +279,7 @@ abstract class C
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196458488
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java
---
@@ -268,7 +268,7 @@ private DataChunk deserialize
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196458442
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java
---
@@ -205,7 +205,7 @@ public void setNumberOfPages(
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196456536
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/LVLongStringStatsCollector.java
---
@@ -0,0 +1,50 @@
+/*
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196455373
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -64,7 +64,7 @@ public Co
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196455199
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -71,7 +72,7 @@ public ColumnPageDecod
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196454746
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java
---
@@ -103,6 +103,7 @@ private Colum
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196451306
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RawColumnChunkUtil.java
---
@@ -0,0 +1,65 @@
+/*
--- End dif
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196440793
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -289,6 +289,12 @@ public void putDoubl
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196437393
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1601,6 +1602,8 @@
// As Short data ty
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2379
[CARBONDATA-2420][32K] Support string longer than 32000 characters
Add a property in creating table 'long_string_columns' to support string
columns that will contains more than 32000 charact
23 matches
Mail list logo
