Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2678
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216208302
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java
---
@@ -290,7 +290,7 @@ private int va
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216208118
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/CarbonAlterTableDropHivePartitionCommand.scala
---
@@ -
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216207701
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java
---
@@ -135,16 +138,17 @@ private static BitSet ge
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216207416
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -93,26 +101,19 @@ public static long
getTabl
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216207294
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -93,26 +101,19 @@ public static long
getTabl
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198737
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -99,20 +100,21 @@ public static long
getTableS
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198723
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/ThriftReader.java ---
@@ -87,6 +88,15 @@ public void open() throws IOException {
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198714
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/CarbonIndexFileReader.java
---
@@ -79,6 +80,17 @@ public void openThriftReader(String f
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198700
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -354,6 +364,22 @@ private MergedBlo
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198687
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -35,7 +37,8 @@
/**
* It is called to load the da
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198665
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -76,20 +77,29 @@
*/
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216130682
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -76,20 +77,29 @@
*/
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214617612
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -99,20 +100,21 @@ public static long
getTabl
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214617416
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/ThriftReader.java ---
@@ -87,6 +88,15 @@ public void open() throws IOException {
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214617306
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/CarbonIndexFileReader.java
---
@@ -79,6 +80,17 @@ public void openThriftReader(String
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214616899
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -354,6 +364,22 @@ private MergedB
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214616107
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -35,7 +37,8 @@
/**
* It is called to load the
18 matches
Mail list logo
