[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229298501 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1737,4 +1738,89 @@ public void

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229288967 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java --- @@ -169,7

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229289006 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java --- @@ -178,6 +178,25 @@ public boolean delete() {

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229284011 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java --- @@ -0,0 +1,194 @@ +/* + * Licensed

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229254647 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java --- @@ -0,0 +1,194 @@ +/* + * Licensed

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229248603 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java --- @@ -180,6 +235,11 @@ public CarbonTable

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229246953 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java --- @@ -145,9 +158,33 @@ public CarbonTable

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229243919 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputSplit.java --- @@ -138,6 +138,19 @@ public CarbonInputSplit(String

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229247445 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java --- @@ -145,9 +158,33 @@ public CarbonTable

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229218201 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java --- @@ -305,7 +301,7 @@ public void

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229193317 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java --- @@