GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/532
Move package in carbon-core module
As a step to refactor code to make it more modular, this PR move following
package in carbon-core module
1. move org.apache.carbondata.core.carbo
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/532
Build Failed with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/585/
---
If your project is set up for it, you can reply to this email and h
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/517
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/517
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95956671
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonOptimizer.scala
---
@@ -237,9 +237,15 @@ class ResolveCarbonFun
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95956802
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class CarbonRelation(
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95956880
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class CarbonRelation(
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95956920
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class CarbonRelation(
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/529
@ravipesala Is this PR only fix some of the test case? I used mvn verify
-Pno-kettle, but IUD test case is failing. Fix in another PR?
---
If your project is set up for it, you can rep
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/527
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/527
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/533
[WIP]Fixed offheap Query Crash issue
**Problem**
Query is failing sometime when number of 1 block contains more than one
blocklet
**Reason**
Offheap memory is gettin
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/423
Please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/533
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/586/
---
If your project is set up for it, you can reply to this email and h
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/264#discussion_r95140944
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -188,13 +194,26 @@ public static void setSegmentsToAc
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/264#discussion_r95959773
--- Diff:
hadoop/src/test/java/org/apache/carbondata/hadoop/CarbonInputFormatTest.java ---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apa
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/534
[CARBONDATA-632] Fix wrong comments of load data in
CarbonDataRDDFactory.scala
Fix wrong comments of load data in CarbonDataRDDFactory.scala:
1.Currently, not use NewHadoopRDD
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/507
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/587/
---
If your project is set up for it, you can reply to this email and h
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/534
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/588/
---
If your project is set up for it, you can reply to this email and h
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/533
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/589/
---
If your project is set up for it, you can reply to this email and h
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95973885
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonOptimizer.scala
---
@@ -237,9 +237,15 @@ class ResolveCarbonFu
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95973907
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class CarbonRelation
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95973866
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInput.java
---
@@ -193,28 +195,26 @@ public boolean proce
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95973928
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class CarbonRelation
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95976060
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class CarbonRelation
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/528
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/590/
---
If your project is set up for it, you can reply to this email and h
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/528
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/591/
---
If your project is set up for it, you can reply to this email and h
GitHub user anuragknoldus opened a pull request:
https://github.com/apache/incubator-carbondata/pull/535
[CARBONDATA-542] Abnormal behaviour of Int datatype
**Analysis:** Currently Short and Int datatypes are treated as long and at
the time of storing in carbon data files delta comp
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/535
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/592/
---
If your project is set up for it, you can reply to this email and h
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/531
Oh, I thought it is supported. Why bucket table is not supported in
spark1.6?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/534#discussion_r96002854
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -559,11 +560,7 @@ object CarbonDat
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/533#discussion_r96003271
--- Diff:
core/src/main/java/org/apache/carbondata/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -470,6 +477,7 @@ private AggregatorInfo
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/533#discussion_r96003724
--- Diff:
core/src/main/java/org/apache/carbondata/scan/executor/impl/DetailQueryExecutor.java
---
@@ -39,11 +39,12 @@
public CarbonIter
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96005860
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creatabl
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96005973
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creatabl
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96006080
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creatabl
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96006298
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creatabl
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/521
@phalodi can you some testcases(with and with out filter on float datatype)
on spark-common-test module
---
If your project is set up for it, you can reply to this email and have yo
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/531
@anubhav100 bucket is supported in all spark versions, but we will not get
the benefit of join optimization in 1.6 and 1.5.
---
If your project is set up for it, you can reply to t
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/529
@jackylk IUD testcase are fixed in
https://github.com/apache/incubator-carbondata/pull/523.
Please merge https://github.com/apache/incubator-carbondata/pull/523 as
well.
---
I
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/507
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user anubhav100 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/531
@ravipesala but it does not validate anycheck if it is supported even if
we will not get the benefit of join optimization all carbondata checks must be
validated
---
If your proj
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/529
I will merge this PR now and will wait for @ravikiran23 to fix comment for
#523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96021180
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creat
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96021165
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creat
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/529
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96022013
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creatabl
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96021932
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creat
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96022199
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creatabl
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/512
LGTM
@ravipesala please check also
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/511
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/593/
---
If your project is set up for it, you can reply to this email and h
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/511
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/594/
---
If your project is set up for it, you can reply to this email and h
Github user anubhav100 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/511
@jackylk all issues are resolved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/511
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/595/
---
If your project is set up for it, you can reply to this email and h
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/533#discussion_r96071986
--- Diff:
core/src/main/java/org/apache/carbondata/scan/executor/impl/DetailQueryExecutor.java
---
@@ -39,11 +39,12 @@
public Carb
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/533#discussion_r96072237
--- Diff:
core/src/main/java/org/apache/carbondata/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -470,6 +477,7 @@ private Aggregat
Github user kumarvishal09 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/532
move org.apache.carbondata.locks to
org.apache.carbondata.core.updatestatus.locks, please change it
org.apache.carbondata.core.locks.updatestatus
---
If your project is set up
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/533
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/596/
---
If your project is set up for it, you can reply to this email and h
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/532
@kumarvishal09
I feel this lock package can be reused in other scenario also, how about
move it to org.apache.carbondata.core.lock?
---
If your project is set up for it, you can r
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/528
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/597/
---
If your project is set up for it, you can reply to this email and h
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/534
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/598/
---
If your project is set up for it, you can reply to this email and h
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r96108486
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInput.java
---
@@ -194,28 +196,25 @@ public boolean proces
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r96108503
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +782,47 @@ case class CarbonRelation(
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r96108506
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +782,47 @@ case class CarbonRelation(
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/533
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/533
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96108575
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends Creatabl
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96108584
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -104,14 +106,17 @@ class CarbonSource extends Creatab
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96110103
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -104,14 +106,17 @@ class CarbonSource extends Crea
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/511
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/599/
---
If your project is set up for it, you can reply to this email and h
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96110523
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -104,14 +106,17 @@ class CarbonSource extends Crea
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/511
LGTM
Thanks for working on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/534
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/600/
---
If your project is set up for it, you can reply to this email and h
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/532
Build Failed with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/601/
---
If your project is set up for it, you can reply to this email and h
76 matches
Mail list logo
