[GitHub] incubator-carbondata issue #635: [WIP]support SORT_COLUMNS

2017-03-08 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 @ravipesala Is it neccessary to limit that the sort_columns should come from dimensions? If the table need be sorted by a measure, we should use dictionary_include to add it t

[GitHub] incubator-carbondata issue #635: [WIP]support SORT_COLUMNS

2017-03-08 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 @ravipesala I have listed the tasks. Better to implement another direct-dictionary encoding for numeric datatype column. We can remove the dimension and measure concept, and only

[GitHub] incubator-carbondata issue #636: [CARBONDATA-741] Remove useless classes

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/636 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1051/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #636: [CARBONDATA-741] Remove useless clas...

2017-03-08 Thread lionelcao
GitHub user lionelcao opened a pull request: https://github.com/apache/incubator-carbondata/pull/636 [CARBONDATA-741] Remove useless classes Remove useless classes VectorChunkRowIterator CarbonColumnVectorImpl You can merge this pull request into a Git repository by run

[GitHub] incubator-carbondata issue #630: [CARBONDATA-730]added decimal type in carbo...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/630 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1050/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #630: [CARBONDATA-730]added decimal type in carbo...

2017-03-08 Thread anubhav100
Github user anubhav100 commented on the issue: https://github.com/apache/incubator-carbondata/pull/630 @jackylk i added a example in CaseClassDataFrameAPIExample,i think its working correct case class Employee(name: String, salary: BigDecimal) val employee = List(Em

[GitHub] incubator-carbondata issue #633: [CARBONDATA-739] Avoid creating multipul in...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/633 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1049/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #633: [CARBONDATA-739] Avoid creating mult...

2017-03-08 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/633#discussion_r105079650 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java --- @@ -103,6 +101,12 @@ p

[GitHub] incubator-carbondata issue #635: [WIP]support SORT_COLUMNS

2017-03-08 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 @QiangCai Please mention what are the tasks you are doing in this PR. It is better to stick only supporting sort_columns in this PR. Other tasks can be pushed to other PRs. --- If

[jira] [Resolved] (CARBONDATA-743) Remove the abundant class CarbonFilters.scala

2017-03-08 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala resolved CARBONDATA-743. Resolution: Fixed Fix Version/s: 1.0.1-incubating > Remove the abundant c

[GitHub] incubator-carbondata pull request #628: [CARBONDATA-743] Remove redundant Ca...

2017-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] incubator-carbondata issue #628: [CARBONDATA-743] Remove redundant CarbonFil...

2017-03-08 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/628 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-carbondata issue #633: [CARBONDATA-739] Avoid creating multipul in...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/633 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1048/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #633: [CARBONDATA-739] Avoid creating mult...

2017-03-08 Thread lionelcao
Github user lionelcao commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/633#discussion_r105068561 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java --- @@ -37,6 +34,8 @@

[GitHub] incubator-carbondata issue #629: [CARBONDATA-740] add logger for total rows ...

2017-03-08 Thread lionelcao
Github user lionelcao commented on the issue: https://github.com/apache/incubator-carbondata/pull/629 @ravipesala this PR is closed but not merged yet. I can't reopen it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-carbondata issue #635: [WIP]support SORT_COLUMNS

2017-03-08 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 @ravipesala good suggestion. Direct dicitonary is better than no dictioanry. I will add it. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r105051400 --- Diff: format/src/main/thrift/carbondata_index.thrift --- @@ -41,6 +41,6 @@ struct IndexHeader{ struct BlockIndex{ 1: required i

[GitHub] incubator-carbondata issue #635: [WIP]support SORT_COLUMNS

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1047/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #631: [CARBONDATA-751]Adding Header And Making Fo...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/631 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1046/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104971719 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for i

[GitHub] incubator-carbondata issue #628: [CARBONDATA-743] Remove redundant CarbonFil...

2017-03-08 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/628 There is a difference in method `selectFilters` it takes one extra boolean in deleted file. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] incubator-carbondata issue #620: [CARBONDATA-742]Added batch sort to improve...

2017-03-08 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/620 Data size -> 100 million records **DDL and Queries for test** CREATE TABLE perftesta (c1 string,c2 string,c3 string,c4 string,c5 string,c6 bigint,c7 double,c8 int,c9 double,c1

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104963859 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for i

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104963590 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for i

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104963505 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java --- @@ -319,11 +322

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104963110 --- Diff: format/src/main/thrift/carbondata_index.thrift --- @@ -41,6 +41,6 @@ struct IndexHeader{ struct BlockIndex{ 1: requ

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104962645 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for i

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104962541 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for i

[GitHub] incubator-carbondata issue #635: [WIP]support SORT_COLUMNS

2017-03-08 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 @QiangCai I have few doubts. Why primitive data types are supported as no-dictionary columns in this PR? It supposed to be direct dictionary. Why date and timestamp are suppor

[GitHub] incubator-carbondata issue #630: [CARBONDATA-730]added decimal type in carbo...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/630 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1045/ --- If your project is set up for it, you can reply to this email and

[jira] [Resolved] (CARBONDATA-714) DOCUMENTATION - How to handle the bad records

2017-03-08 Thread Liang Chen (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Chen resolved CARBONDATA-714. --- Resolution: Fixed Fix Version/s: 1.0.1-incubating > DOCUMENTATION - How to handle t

[jira] [Updated] (CARBONDATA-714) DOCUMENTATION - How to handle the bad records

2017-03-08 Thread Liang Chen (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Chen updated CARBONDATA-714: -- Summary: DOCUMENTATION - How to handle the bad records (was: DOCUMENTATION - How to handle

[GitHub] incubator-carbondata issue #614: [CARBONDATA-714]Documented how to handle ba...

2017-03-08 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/614 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] incubator-carbondata pull request #614: [CARBONDATA-714]Documented how to ha...

2017-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/614 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] incubator-carbondata issue #332: [CARBONDATA-424] Data Load will fail for ba...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/332 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1044/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #332: [CARBONDATA-424] Data Load will fail for ba...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/332 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1043/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #634: [CARBONDATA-753] Fix Date and Timestamp for...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/634 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1042/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #635: [WIP]support SORT_COLUMNS

2017-03-08 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/635 [WIP]support SORT_COLUMNS 1. create table with sort_columns e.g. tblproperties('sort_columns' = 'col7,col3') The columns of sort_columsn will be at the begin of all colu

[GitHub] incubator-carbondata pull request #634: [CARBONDATA-753] Fix Date and Timest...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/634#discussion_r104926113 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -383,7 +383,7 @@ */ public

[GitHub] incubator-carbondata pull request #634: [CARBONDATA-753] Fix Date and Timest...

2017-03-08 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/634#discussion_r104925662 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -383,7 +383,7 @@ */ p

[GitHub] incubator-carbondata issue #635: [WIP]support SORT_COLUMNS

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1041/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #630: [CARBONDATA-730]added decimal type in carbo...

2017-03-08 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/incubator-carbondata/pull/630 Can you add a testcase to write datafame containing a decimal column and query it? I think it needs more implementation for load and read --- If your project is set up for it, you can

[GitHub] incubator-carbondata pull request #634: [CARBONDATA-753] Fix Date and Timest...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/634#discussion_r104919325 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -392,7 +392,7 @@ */ public

[GitHub] incubator-carbondata pull request #634: [CARBONDATA-753] Fix Date and Timest...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/634#discussion_r104919217 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -383,7 +383,7 @@ */ public

[GitHub] incubator-carbondata issue #634: [CARBONDATA-753] Fix Date and Timestamp for...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/634 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1040/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #633: [CARBONDATA-739] Avoid creating mult...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/633#discussion_r104916295 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java --- @@ -37,6 +34,8 @@ im

[GitHub] incubator-carbondata pull request #634: [CARBONDATA-753] Fix Date and Timest...

2017-03-08 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/634 [CARBONDATA-753] Fix Date and Timestamp format issues Fix Date and Timestamp format issues: 1.Optimize the description of CARBON_TIMESTAMP_FORMAT&CARBON_DATE_FORMAT in Carbon

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104915516 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for indexed

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104915366 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for indexed

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104915387 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for indexed

[jira] [Updated] (CARBONDATA-753) Fix Date and Timestamp format issues

2017-03-08 Thread Liang Chen (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Chen updated CARBONDATA-753: -- Description: Fix Date and Timestamp format issues: 1.Optimize the description of CARBON_TIME

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104914699 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for indexed

[jira] [Updated] (CARBONDATA-753) Fix Date and Timestamp format issues

2017-03-08 Thread Liang Chen (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Chen updated CARBONDATA-753: -- Description: Fix Date and Timestamp format issues: 1.Optimize the description of CARBON_TIME

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104914302 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for indexed

[jira] [Created] (CARBONDATA-753) Fix Date and Timestamp format issues

2017-03-08 Thread Liang Chen (JIRA)
Liang Chen created CARBONDATA-753: - Summary: Fix Date and Timestamp format issues Key: CARBONDATA-753 URL: https://issues.apache.org/jira/browse/CARBONDATA-753 Project: CarbonData Issue Type:

[GitHub] incubator-carbondata issue #631: [CARBONDATA-751]Adding Header And Making Fo...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/631 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1039/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #631: [CARBONDATA-751]Adding Header And Making Fo...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/631 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1038/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104910765 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java --- @@ -319,11 +322,12 @@

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104910137 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for indexed

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104910022 --- Diff: format/src/main/thrift/carbondata_index.thrift --- @@ -41,6 +41,6 @@ struct IndexHeader{ struct BlockIndex{ 1: required i

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104909522 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for indexed

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104908630 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for indexed

[GitHub] incubator-carbondata pull request #569: [WIP]Fixed GC issue and re-factor di...

2017-03-08 Thread kumarvishal09
Github user kumarvishal09 closed the pull request at: https://github.com/apache/incubator-carbondata/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104907969 --- Diff: core/src/main/java/org/apache/carbondata/core/reader/CarbonHeaderReader.java --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Ap

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104907859 --- Diff: core/src/main/java/org/apache/carbondata/core/reader/CarbonHeaderReader.java --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Ap

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104907778 --- Diff: core/src/main/java/org/apache/carbondata/core/reader/CarbonHeaderReader.java --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Ap

[GitHub] incubator-carbondata issue #624: [CARBONDATA-747][WIP] Add simple performanc...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/624 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1037/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104905629 --- Diff: core/src/main/java/org/apache/carbondata/core/reader/CarbonFooterReaderV3.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to the

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104905047 --- Diff: core/src/main/java/org/apache/carbondata/core/reader/CarbonFooterReaderV3.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to the

[GitHub] incubator-carbondata pull request #618: [CARBONDATA-734] Support the syntax ...

2017-03-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/618#discussion_r104903081 --- Diff: integration/spark2/src/test/scala/org/apache/spark/SparkCommandSuite.scala --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apac

[jira] [Resolved] (CARBONDATA-740) Add logger for rows processed while closing in AbstractDataLoadProcessorStep

2017-03-08 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala resolved CARBONDATA-740. Resolution: Fixed Fix Version/s: 1.0.1-incubating > Add logger for rows p

[GitHub] incubator-carbondata pull request #629: [CARBONDATA-740] add logger for tota...

2017-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] incubator-carbondata issue #631: [CARBONDATA-751]Adding Header And Making Fo...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/631 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1036/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #629: [CARBONDATA-740] add logger for total rows ...

2017-03-08 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/629 LGTM Thanks for working on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[jira] [Resolved] (CARBONDATA-746) Support spark-sql CLI for spark2.1 carbon integration

2017-03-08 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala resolved CARBONDATA-746. Resolution: Fixed > Support spark-sql CLI for spark2.1 carbon integration >

[GitHub] incubator-carbondata pull request #623: [CARBONDATA-746] Add spark-sql CLI s...

2017-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] incubator-carbondata issue #623: [CARBONDATA-746] Add spark-sql CLI support ...

2017-03-08 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/623 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Created] (CARBONDATA-752) creating complex type gives exception

2017-03-08 Thread anubhav tarar (JIRA)
anubhav tarar created CARBONDATA-752: Summary: creating complex type gives exception Key: CARBONDATA-752 URL: https://issues.apache.org/jira/browse/CARBONDATA-752 Project: CarbonData Issu

[GitHub] incubator-carbondata issue #631: [CARBONDATA-751]Adding Header And Making Fo...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/631 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1035/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-08 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104888546 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for i

[GitHub] incubator-carbondata issue #622: [CARBONDATA-744] The property "spark.carbon...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/622 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1034/ --- If your project is set up for it, you can reply to this email and

[jira] [Assigned] (CARBONDATA-739) Avoid creating multiple instances of DirectDictionary in DictionaryBasedResultCollector

2017-03-08 Thread Cao, Lionel (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cao, Lionel reassigned CARBONDATA-739: -- Assignee: Cao, Lionel (was: Liang Chen) > Avoid creating multiple instances of Dir

[GitHub] incubator-carbondata issue #633: [CARBONDATA-739] Avoid creating multipul in...

2017-03-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/633 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1033/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #633: [CARBONDATA-739] Avoid creating mult...

2017-03-08 Thread lionelcao
GitHub user lionelcao opened a pull request: https://github.com/apache/incubator-carbondata/pull/633 [CARBONDATA-739] Avoid creating multipul instance of directDictionaryGenerator Avoid creating multipul instance of directDictionaryGenerator You can merge this pull request into a G