[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r108028962 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonOutputFormat.java --- @@ -0,0 +1,49 @@ +/* + * Licen

[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1331/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #697: [CARBONDATA-708] Fixed Between and Logical ...

2017-03-24 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/697 LGTM, except few style issues raised by david, please fix them --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...

2017-03-24 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r108026227 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonOutputFormat.java --- @@ -0,0 +1,49 @@ +/* + * Licen

[GitHub] incubator-carbondata issue #691: [CARBONDATA-783] Fixed message fails with o...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/691 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1330/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #691: [CARBONDATA-783] Fixed message fails with o...

2017-03-24 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/691 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] incubator-carbondata issue #691: [CARBONDATA-783] Fixed message fails with o...

2017-03-24 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/691 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] incubator-carbondata issue #694: [CARBONDATA-814] bad record log file writin...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/694 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1329/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #694: [CARBONDATA-814] bad record log file writin...

2017-03-24 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/694 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] incubator-carbondata pull request #697: [CARBONDATA-708] Fixed Between and L...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/697#discussion_r107919139 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala --- @@ -111,16 +111,24 @@ object CarbonFil

[GitHub] incubator-carbondata pull request #697: [CARBONDATA-708] Fixed Between and L...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/697#discussion_r107918771 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala --- @@ -111,16 +111,24 @@ object CarbonFil

[GitHub] incubator-carbondata pull request #697: [CARBONDATA-708] Fixed Between and L...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/697#discussion_r107920260 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala --- @@ -111,16 +111,24 @@ object CarbonFil

[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...

2017-03-24 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 @watermen It is unnecessary to store carbondata file path in carbonindex file. During btree building, just use carbondata file name to sort tableblockinfos. please check Ca

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107893281 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java --- @@ -0,0 +1,99 @@ +/* + * Licens

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107862312 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191 @@ +/* + * Licensed

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107886267 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveSerDe.java --- @@ -0,0 +1,232 @@ +/* + * Licensed to t

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107872055 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java --- @@ -0,0 +1,249 @@ +/* + * Licens

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107875522 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java --- @@ -0,0 +1,249 @@ +/* + * Licens

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863523 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191 @@ +/* + * Licensed

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107894484 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java --- @@ -0,0 +1,99 @@ +/* + * Licens

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107881262 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java --- @@ -0,0 +1,249 @@ +/* + * Licens

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107862824 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191 @@ +/* + * Licensed

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863410 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191 @@ +/* + * Licensed

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107873741 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java --- @@ -0,0 +1,99 @@ +/* + * Licens

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107890848 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonOutputFormat.java --- @@ -0,0 +1,49 @@ +/* + * Licen

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863922 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveInputSplit.java --- @@ -0,0 +1,290 @@ +/* + * Licensed

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863484 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191 @@ +/* + * Licensed

[GitHub] incubator-carbondata issue #695: [CARBONDATA-696] Fixed Null Pointer Excepti...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/695 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1328/ --- If your project is set up for it, you can reply to this email and

[jira] [Created] (CARBONDATA-819) Getting error while create table with long data type

2017-03-24 Thread Vinod Rohilla (JIRA)
Vinod Rohilla created CARBONDATA-819: Summary: Getting error while create table with long data type Key: CARBONDATA-819 URL: https://issues.apache.org/jira/browse/CARBONDATA-819 Project: CarbonData

[GitHub] incubator-carbondata issue #697: [CARBONDATA-708] Fixed Between and Logical ...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/697 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1327/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...

2017-03-24 Thread bhavya411
Github user bhavya411 commented on the issue: https://github.com/apache/incubator-carbondata/pull/616 @ravipesala Created a New PR #697 for the fixes that were suggested , added a Unit test class to make sure it runs everytime with the build and removed the example --- If your proje

[GitHub] incubator-carbondata pull request #697: [CARBONDATA-708] Fixed Between and L...

2017-03-24 Thread bhavya411
GitHub user bhavya411 opened a pull request: https://github.com/apache/incubator-carbondata/pull/697 [CARBONDATA-708] Fixed Between and Logical AND issue - Change CarbonFilters.scala to fix BETWEEN and Logical AND operator - Add Unit Test Cases - Tested on Spark 1.6 and 2.1

[jira] [Resolved] (CARBONDATA-813) Fix pom issues and add the correct dependency jar to build success for integration/presto

2017-03-24 Thread Liang Chen (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Chen resolved CARBONDATA-813. --- Resolution: Fixed Fix Version/s: 1.2.0 > Fix pom issues and add the correct depende

[GitHub] incubator-carbondata pull request #693: [CARBONDATA-813] Fix all issues to b...

2017-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] incubator-carbondata issue #693: [CARBONDATA-813] Fix all issues to build su...

2017-03-24 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/693 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-carbondata issue #695: [CARBONDATA-696] Fixed Null Pointer Excepti...

2017-03-24 Thread kumarvishal09
Github user kumarvishal09 commented on the issue: https://github.com/apache/incubator-carbondata/pull/695 Please add test case for failure scenario --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-carbondata issue #652: [CARBONDATA-768] unit-testcase for org.apac...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/652 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1326/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #652: [CARBONDATA-768] unit-testcase for org.apac...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/652 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1325/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #652: [CARBONDATA-768] unit-testcase for org.apac...

2017-03-24 Thread rahulforallp
Github user rahulforallp commented on the issue: https://github.com/apache/incubator-carbondata/pull/652 Retest this Please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] incubator-carbondata issue #652: [CARBONDATA-768] unit-testcase for org.apac...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/652 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1324/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1323/ --- If your project is set up for it, you can reply to this email and

[jira] [Updated] (CARBONDATA-818) The file_name stored in carbonindex is wrong

2017-03-24 Thread Yadong Qi (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yadong Qi updated CARBONDATA-818: - Description: The file_name stored in carbonindex is a local path which used on executor as te

[GitHub] incubator-carbondata issue #689: [CARBONDATA-812] make vectorized reader as ...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/689 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1322/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #696: [CARBONDATA-818] Make the file_name ...

2017-03-24 Thread watermen
GitHub user watermen opened a pull request: https://github.com/apache/incubator-carbondata/pull/696 [CARBONDATA-818] Make the file_name in carbonindex exactly The file_name stored in carbonindex is a local path which used on executor as temp dir ``` /tmp/6937581525189542/0

[GitHub] incubator-carbondata issue #689: [CARBONDATA-812] make vectorized reader as ...

2017-03-24 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/689 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Updated] (CARBONDATA-818) The file_name stored in carbonindex is wrong

2017-03-24 Thread Yadong Qi (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yadong Qi updated CARBONDATA-818: - Description: The file_name stored in carbonindex is a local path which used on executor as tem

[jira] [Updated] (CARBONDATA-818) The file_name stored in carbonindex is wrong

2017-03-24 Thread Yadong Qi (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yadong Qi updated CARBONDATA-818: - Summary: The file_name stored in carbonindex is wrong (was: The file) > The file_name stored

[jira] [Created] (CARBONDATA-818) The file

2017-03-24 Thread Yadong Qi (JIRA)
Yadong Qi created CARBONDATA-818: Summary: The file Key: CARBONDATA-818 URL: https://issues.apache.org/jira/browse/CARBONDATA-818 Project: CarbonData Issue Type: Bug Reporter: Yad

[GitHub] incubator-carbondata issue #694: [CARBONDATA-814] bad record log file writin...

2017-03-24 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/694 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1321/ --- If your project is set up for it, you can reply to this email and