[GitHub] [commons-codec] behrangsa commented on issue #31: Added non-blocking File digest methods

2019-11-29 Thread GitBox
behrangsa commented on issue #31: Added non-blocking File digest methods URL: https://github.com/apache/commons-codec/pull/31#issuecomment-559917290 Not sure why the coveralls is reporting that the new methods are not tested. Tests have been added for both of them.

[GitHub] [commons-codec] coveralls commented on issue #31: Added non-blocking File digest methods

2019-11-29 Thread GitBox
coveralls commented on issue #31: Added non-blocking File digest methods URL: https://github.com/apache/commons-codec/pull/31#issuecomment-559906891 [![Coverage Status](https://coveralls.io/builds/27331031/badge)](https://coveralls.io/builds/27331031) Coverage decreased (-0.1%)

[GitHub] [commons-codec] behrangsa opened a new pull request #31: Added non-blocking File digest methods

2019-11-29 Thread GitBox
behrangsa opened a new pull request #31: Added non-blocking File digest methods URL: https://github.com/apache/commons-codec/pull/31 Added two methods: * `nonblockingDigest(final MessageDigest messageDigest, final File data)` * `nonblockingDigest(final MessageDigest messageDigest,

[jira] [Comment Edited] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2019-11-29 Thread Chen Guoping (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985227#comment-16985227 ] Chen Guoping edited comment on COLLECTIONS-738 at 11/30/19 1:52 AM:

[jira] [Commented] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2019-11-29 Thread Chen Guoping (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985227#comment-16985227 ] Chen Guoping commented on COLLECTIONS-738: -- Hi Pengyu Nie:    I recommend updating the

[GitHub] [commons-imaging] kinow commented on issue #62: Add disposal method to GIF metadata

2019-11-29 Thread GitBox
kinow commented on issue #62: Add disposal method to GIF metadata URL: https://github.com/apache/commons-imaging/pull/62#issuecomment-559889940 Thanks for the PR. Travis seems to be failing, and we will need a JIRA for that too. I am with limited internet until Sun/Mon, but can take

[GitHub] [commons-imaging] christoffer-rydberg opened a new pull request #62: Add disposal method to GIF metadata

2019-11-29 Thread GitBox
christoffer-rydberg opened a new pull request #62: Add disposal method to GIF metadata URL: https://github.com/apache/commons-imaging/pull/62 Add disposal method to GIF metadata in order to know how to render GIF frames with transparent pixels. See

[jira] [Updated] (COLLECTIONS-737) The test FluentIterableTest.size should be split

2019-11-29 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated COLLECTIONS-737: Summary: The test FluentIterableTest.size should be split (was: The test

[jira] [Commented] (COLLECTIONS-728) BloomFilter contribution

2019-11-29 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985141#comment-16985141 ] Gilles Sadowski commented on COLLECTIONS-728: - I don't think that it is Commons practice

[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2019-11-29 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-559850739 Will someone please comment on this pull request or approve it? This

[jira] [Work logged] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2019-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-738?focusedWorklogId=351422=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351422 ] ASF GitHub Bot logged work on COLLECTIONS-738: -- Author: ASF

[GitHub] [commons-collections] Prodigysov opened a new pull request #121: [COLLECTIONS-738] Remove the redundant assertNull in IterableUtilsTest.find

2019-11-29 Thread GitBox
Prodigysov opened a new pull request #121: [COLLECTIONS-738] Remove the redundant assertNull in IterableUtilsTest.find URL: https://github.com/apache/commons-collections/pull/121 As described in the JIRA issue [COLLECTIONS-738](https://issues.apache.org/jira/browse/COLLECTIONS-738)

[jira] [Created] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2019-11-29 Thread Pengyu Nie (Jira)
Pengyu Nie created COLLECTIONS-738: -- Summary: The last assertNull in IterableUtilsTest.find is redundant Key: COLLECTIONS-738 URL: https://issues.apache.org/jira/browse/COLLECTIONS-738 Project:

[jira] [Created] (GEOMETRY-66) Unused argument in "QuaternionRotation"

2019-11-29 Thread Gilles Sadowski (Jira)
Gilles Sadowski created GEOMETRY-66: --- Summary: Unused argument in "QuaternionRotation" Key: GEOMETRY-66 URL: https://issues.apache.org/jira/browse/GEOMETRY-66 Project: Apache Commons Geometry

[jira] [Commented] (COLLECTIONS-737) The test FluentIterableTest.size should be splitted

2019-11-29 Thread Pengyu Nie (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985116#comment-16985116 ] Pengyu Nie commented on COLLECTIONS-737: True. I made a new commit to include the faster

[jira] [Commented] (JEXL-307) Variable redeclaration option

2019-11-29 Thread Dmitri Blinov (Jira)
[ https://issues.apache.org/jira/browse/JEXL-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985015#comment-16985015 ] Dmitri Blinov commented on JEXL-307: The following test fails with *undefined variable x* in most inner