lukaszlenart merged pull request #44:
URL: https://github.com/apache/commons-ognl/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
arturobernalg commented on pull request #44:
URL: https://github.com/apache/commons-ognl/pull/44#issuecomment-864742299
> This won't work, some of these `static`s are used to keep state
>
> ```
> Error:
/home/runner/work/commons-ognl/commons-ognl/src/main/java/org/apache/commons/
arturobernalg opened a new pull request #45:
URL: https://github.com/apache/commons-ognl/pull/45
Remove redundant calls of java.lang.Class methods. Replaced with object
instanceof
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
lukaszlenart commented on pull request #44:
URL: https://github.com/apache/commons-ognl/pull/44#issuecomment-864739293
This won't work, some of these `static`s are used to keep state
```
Error:
/home/runner/work/commons-ognl/commons-ognl/src/main/java/org/apache/commons/ognl/OgnlCont
arturobernalg opened a new pull request #44:
URL: https://github.com/apache/commons-ognl/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
coveralls commented on pull request #207:
URL: https://github.com/apache/commons-compress/pull/207#issuecomment-864709651
[](https://coveralls.io/builds/40730660)
Coverage remained the same at 86.812% when pulling
**9
dependabot[bot] opened a new pull request #115:
URL: https://github.com/apache/commons-dbcp/pull/115
Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.30 to 1.7.31.
Commits
See full diff in https://github.com/qos-ch/slf4j/commits";>compare view
dependabot[bot] opened a new pull request #207:
URL: https://github.com/apache/commons-compress/pull/207
Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.30 to 1.7.31.
Commits
See full diff in https://github.com/qos-ch/slf4j/commits";>compare view
coveralls commented on pull request #241:
URL:
https://github.com/apache/commons-collections/pull/241#issuecomment-864630379
[](https://coveralls.io/builds/40727444)
Coverage decreased (-0.002%) to 90.11% when pulling
[
https://issues.apache.org/jira/browse/NUMBERS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366317#comment-17366317
]
Gilles Sadowski commented on NUMBERS-163:
-
{quote}[...] can of worms.
{quote}
Go
[
https://issues.apache.org/jira/browse/NUMBERS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366316#comment-17366316
]
Gilles Sadowski commented on NUMBERS-165:
-
Yes, if such a statement is assumed t
[
https://issues.apache.org/jira/browse/GEOMETRY-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366277#comment-17366277
]
Gilles Sadowski commented on GEOMETRY-125:
--
{quote}not all options would apply
garydgregory commented on pull request #770:
URL: https://github.com/apache/commons-lang/pull/770#issuecomment-864618455
FYI, var is a Java 10 feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
coveralls edited a comment on pull request #98:
URL: https://github.com/apache/commons-numbers/pull/98#issuecomment-864560200
[](https://coveralls.io/builds/40726504)
Coverage remained the same at 99.657% when pulling
[
https://issues.apache.org/jira/browse/POOL-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366264#comment-17366264
]
Phil Steitz commented on POOL-396:
--
Sorry for the slow response. Really nice work on this
[
https://issues.apache.org/jira/browse/POOL-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366259#comment-17366259
]
Gary D. Gregory commented on POOL-396:
--
Unless [~psteitz] chimes back in with more sug
[
https://issues.apache.org/jira/browse/CONFIGURATION-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366244#comment-17366244
]
Gary D. Gregory commented on CONFIGURATION-808:
---
Waiting on PR GitHu
[
https://issues.apache.org/jira/browse/NUMBERS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366243#comment-17366243
]
Matt Juntunen commented on NUMBERS-163:
---
One effect of this is that downstream API
lukaszlenart merged pull request #43:
URL: https://github.com/apache/commons-ognl/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/GEOMETRY-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366240#comment-17366240
]
Matt Juntunen commented on GEOMETRY-125:
So many enums... :-)
I'd like to use
lukaszlenart merged pull request #42:
URL: https://github.com/apache/commons-ognl/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
lukaszlenart merged pull request #41:
URL: https://github.com/apache/commons-ognl/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
lukaszlenart merged pull request #40:
URL: https://github.com/apache/commons-ognl/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/NUMBERS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366239#comment-17366239
]
Matt Juntunen commented on NUMBERS-165:
---
I'm assuming this applies to {{L2}}, and
[
https://issues.apache.org/jira/browse/NUMBERS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366238#comment-17366238
]
Matt Juntunen commented on NUMBERS-163:
---
Looks good to me. Thanks.
I thought abou
arturobernalg opened a new pull request #43:
URL: https://github.com/apache/commons-ognl/pull/43
Avoid String concatenation in loops. Replace with StringBuilder.append().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
garydgregory commented on a change in pull request #773:
URL: https://github.com/apache/commons-lang/pull/773#discussion_r654951361
##
File path: src/main/java/org/apache/commons/lang3/ObjectUtils.java
##
@@ -228,6 +227,18 @@ public static boolean anyNull(final Object... values
garydgregory commented on pull request #773:
URL: https://github.com/apache/commons-lang/pull/773#issuecomment-864571151
There is a mismatch here between the code, the Javadoc, and the PR
description. Where is the actual intent expressed? Specifically, the
description and Javadoc do not st
arturobernalg opened a new pull request #42:
URL: https://github.com/apache/commons-ognl/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
arturobernalg opened a new pull request #41:
URL: https://github.com/apache/commons-ognl/pull/41
Identical catch sections in a single try statement. Collapse into a
multi-catch section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
arturobernalg opened a new pull request #40:
URL: https://github.com/apache/commons-ognl/pull/40
* Use Comparator combinator
* Replace Lambda with method reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
coveralls commented on pull request #98:
URL: https://github.com/apache/commons-numbers/pull/98#issuecomment-864560200
[](https://coveralls.io/builds/40724853)
Coverage remained the same at 99.657% when pulling
**c53e
[
https://issues.apache.org/jira/browse/BCEL-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory deleted BCEL-344:
-
> Commons BCEL (BCEL)
> ---
>
> Key: BCEL-344
> URL: h
aherbert commented on pull request #99:
URL: https://github.com/apache/commons-numbers/pull/99#issuecomment-864525537
If the array is null it is not the same result. Check the logic a few lines
above. Please run the default maven goal before opening PRs so you can fix
the build errors.
arturobernalg commented on a change in pull request #99:
URL: https://github.com/apache/commons-numbers/pull/99#discussion_r654905163
##
File path:
commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/FactorialDouble.java
##
@@ -64,8 +64,8 @@ pr
aherbert commented on a change in pull request #99:
URL: https://github.com/apache/commons-numbers/pull/99#discussion_r654896924
##
File path:
commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/FactorialDouble.java
##
@@ -64,8 +64,8 @@ private
aherbert commented on a change in pull request #98:
URL: https://github.com/apache/commons-numbers/pull/98#discussion_r654896139
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
##
@@ -463,10 +463,10 @@ void testSubtrac
Gamel Alomaisi created BCEL-344:
---
Summary: Commons BCEL (BCEL)
Key: BCEL-344
URL: https://issues.apache.org/jira/browse/BCEL-344
Project: Commons BCEL
Issue Type: Bug
Reporter: Game
arturobernalg commented on a change in pull request #99:
URL: https://github.com/apache/commons-numbers/pull/99#discussion_r654891918
##
File path:
commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogFactorial.java
##
@@ -62,9 +62,7 @@ priva
arturobernalg commented on pull request #98:
URL: https://github.com/apache/commons-numbers/pull/98#issuecomment-864512185
> When using `assertNotEquals` the `null` argument must be second so that
the assertion calls the equals method on the class being tested with the `null`
as the argume
aherbert commented on a change in pull request #98:
URL: https://github.com/apache/commons-numbers/pull/98#discussion_r654888225
##
File path:
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
##
@@ -463,10 +463,10 @@ void testSubtrac
41 matches
Mail list logo
