[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633968
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
PeterAlfredLee commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-893209493
This current implemention looks good to me now.
For the "no copy buffer" version, it looks more efficient. But I'm not quite
sure about this. I will try to m
[
https://issues.apache.org/jira/browse/VFS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393510#comment-17393510
]
Gary D. Gregory commented on VFS-807:
-
Hi [~klv_m72]
Please provide your diff as a PR o
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=633890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633890
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
coveralls commented on pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#issuecomment-893057654
[](https://coveralls.io/builds/41915872)
Coverage increased (+0.009%) to 95.003% when pulling
**ed6
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=633874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633874
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=633875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633875
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017853
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -4307,13 +4481,48 @@ public static String join(final int[] array, fina
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017648
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -4818,13 +5052,48 @@ public static String join(final short[] array, fi
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=633873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633873
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017414
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -4858,6 +5127,38 @@ public static String join(final short[] array, fin
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017191
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -4858,6 +5127,38 @@ public static String join(final short[] array, fin
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=633872&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633872
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/VFS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393448#comment-17393448
]
Gary D. Gregory commented on VFS-807:
-
Hi [~klv_m72]
Please don't delete comments ("//
garydgregory merged pull request #255:
URL: https://github.com/apache/commons-io/pull/255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-u
[
https://issues.apache.org/jira/browse/LANG-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393438#comment-17393438
]
Hubert Wojciechowski commented on LANG-1593:
Draft PR created: https://github.
[
https://issues.apache.org/jira/browse/EMAIL-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393343#comment-17393343
]
Gary D. Gregory commented on EMAIL-197:
---
This is a topic for the mailing list, not j
Cott Lang created EMAIL-197:
---
Summary: How about a release? :)
Key: EMAIL-197
URL: https://issues.apache.org/jira/browse/EMAIL-197
Project: Commons Email
Issue Type: Wish
Affects Versions: 1.5
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633511
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
coveralls edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-891708225
[](https://coveralls.io/builds/41898328)
Coverage increased (+0.0005%) to 86.355% when pu
[
https://issues.apache.org/jira/browse/DBCP-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393121#comment-17393121
]
Gary D. Gregory commented on DBCP-509:
--
Hi [~kinow]
Is this still an issue? Do you wa
[
https://issues.apache.org/jira/browse/DBCP-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated DBCP-509:
-
Fix Version/s: (was: 2.9.0)
2.9.1
> Not all methods are consistent in PerUse
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633452
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892573540
The "no copy buffer" version can be more efficient by only calling
`Arrays.copyOf()` when hitting EOF. This avoids copying the byte array when it
is completely
Sebb created NET-703:
Summary: Include example sources in binary bundle
Key: NET-703
URL: https://issues.apache.org/jira/browse/NET-703
Project: Commons Net
Issue Type: Improvement
Reporter:
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633446
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892573540
Wrapping a byte array in a `ByteBuffer` is the most efficient. In the
following implementation an array copy is only needed when hitting EOF:
```
public s
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633400
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
PeterAlfredLee commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892526508
I prefer the one with a copy buffer.
I'm not professional in IO but the implemention with buffer is pretty common
in IO implementions.
--
This is an autom
[
https://issues.apache.org/jira/browse/COMPRESS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392942#comment-17392942
]
Matthijs Laan edited comment on COMPRESS-585 at 8/4/21, 9:53 AM:
[
https://issues.apache.org/jira/browse/COMPRESS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392942#comment-17392942
]
Matthijs Laan edited comment on COMPRESS-585 at 8/4/21, 9:52 AM:
[
https://issues.apache.org/jira/browse/COMPRESS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392942#comment-17392942
]
Matthijs Laan edited comment on COMPRESS-585 at 8/4/21, 9:50 AM:
[
https://issues.apache.org/jira/browse/COMPRESS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392942#comment-17392942
]
Matthijs Laan edited comment on COMPRESS-585 at 8/4/21, 9:49 AM:
[
https://issues.apache.org/jira/browse/COMPRESS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392942#comment-17392942
]
Matthijs Laan commented on COMPRESS-585:
Yes, see the following test case:
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633393
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892504852
This would work without a copy buffer:
```
public static byte[] readRange(final ReadableByteChannel input, final
int len) throws IOException {
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633390
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892504852
This would work without a copy buffer:
```
public static byte[] readRange(final ReadableByteChannel input, final
int len) throws IOException {
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633388
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892504852
This would work without a copy buffer:
```
public static byte[] readRange(final ReadableByteChannel input, final
int len) throws IOException {
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633386
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892504852
This would work without a copy buffer:
```
public static byte[] readRange(final ReadableByteChannel input, final
int len) throws IOException {
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633385
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892504852
This would work without a copy buffer:
```
public static byte[] readRange(final ReadableByteChannel input, final
int len) throws IOException {
fina
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633365
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892485686
> > Note that for
[COMPRESS-585](https://issues.apache.org/jira/browse/COMPRESS-585) I propose
removing the limit to the max bytes read to COPY_BUF_SIZE altogether (th
[
https://issues.apache.org/jira/browse/COMPRESS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392876#comment-17392876
]
Peter Lee commented on COMPRESS-585:
_> The cause is that {{ZipFile.readCentralDire
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633364
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
PeterAlfredLee commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892478291
> Note that for
[COMPRESS-585](https://issues.apache.org/jira/browse/COMPRESS-585) I propose
removing the limit to the max bytes read to COPY_BUF_SIZE altogether (
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633363
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892469732
> Hi @matthijsln
> Please have a look at my reply :-)
>
> > When the len of bytes to read is bigger than COPY_BUF_SIZE, there are
some problems. You ca
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633361
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892469732
> Hi @matthijsln
> Please have a look at my reply :-)
>
> > When the len of bytes to read is bigger than COPY_BUF_SIZE, there are
some problems. You ca
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633360
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892469732
> Hi @matthijsln
> Please have a look at my reply :-)
>
> > When the len of bytes to read is bigger than COPY_BUF_SIZE, there are
some problems. You ca
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633358
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633357
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892469732
> Hi @matthijsln
> Please have a look at my reply :-)
>
> > When the len of bytes to read is bigger than COPY_BUF_SIZE, there are
some problems. You ca
matthijsln commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892469732
> Hi @matthijsln
> Please have a look at my reply :-)
>
> > When the len of bytes to read is bigger than COPY_BUF_SIZE, there are
some problems. You can repro
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633355
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
PeterAlfredLee commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892466407
Hi @matthijsln
Please have a look at my reply :-)
> When the len of bytes to read is bigger than COPY_BUF_SIZE, there are some
problems. You can reproduce
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633347
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633345&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633345
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892460047
> Unfortunately my original fix had a bug when looping more than 2 times.
Revisiting this method I came up with a much simpler implementation that should
be better. I
PeterAlfredLee commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892459986
The new implemention also has some problems :
1. The test `readRangeFromChannelStopsIfThereIsNothingToReadAnymore` is
failed
2. When the `len` of bytes to rea
[
https://issues.apache.org/jira/browse/COMPRESS-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
swxEmily updated COMPRESS-586:
--
Attachment: image-2021-08-04-16-08-42-786.png
Component/s: Documentation
Affects
[
https://issues.apache.org/jira/browse/COMPRESS-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
swxEmily updated COMPRESS-586:
--
Description:
Just the other day, I saw the 1.21 fix information:CVE-2021-35515,
CVE-2021-35516, CVE-
swxEmily created COMPRESS-586:
-
Summary: commons-compress/security-reports.html lost 1.21 fix
information
Key: COMPRESS-586
URL: https://issues.apache.org/jira/browse/COMPRESS-586
Project: Commons Compres
[
https://issues.apache.org/jira/browse/COMPRESS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392831#comment-17392831
]
Matthijs Laan commented on COMPRESS-585:
We could just allocate {{len}} bytes i
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=65&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-65
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
matthijsln commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892450747
Unfortunately my original fix had a bug when looping more than 2 times.
Revisiting this method I came up with a much simpler implementation that should
be better. I ca
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633326
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub B
PeterAlfredLee commented on a change in pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#discussion_r682349198
##
File path: src/test/java/org/apache/commons/compress/utils/IOUtilsTest.java
##
@@ -148,6 +148,25 @@ public void
readRangeFromChannelDoes
dependabot[bot] opened a new pull request #75:
URL: https://github.com/apache/commons-jcs/pull/75
Bumps commons-dbcp2 from 2.8.0 to 2.9.0.
[