[
https://issues.apache.org/jira/browse/CLI-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502092#comment-17502092
]
HUNG LU commented on CLI-313:
-
PR below is to fix per Jan 12, 22 comment. Your merge would be much
[
https://issues.apache.org/jira/browse/CLI-313?focusedWorklogId=737381=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737381
]
ASF GitHub Bot logged work on CLI-313:
--
Author: ASF GitHub Bot
hungklu opened a new pull request #95:
URL: https://github.com/apache/commons-cli/pull/95
…d argument input
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737344=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737344
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF
garydgregory commented on pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#issuecomment-1060152289
@nhojpatrick can we drop junit-vintage-engine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737341=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737341
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF
garydgregory commented on pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#issuecomment-1060151070
TY @nhojpatrick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/GEOMETRY-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502028#comment-17502028
]
Matt Juntunen commented on GEOMETRY-142:
I've made some performance improvements and added the
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated COLLECTIONS-777:
Summary: Fully migrate to JUnit 5 (was: Fully migrate Commons Collection
to
garydgregory commented on pull request #159:
URL:
https://github.com/apache/commons-collections/pull/159#issuecomment-1060050601
I think JUnit 5 work might be done in master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737296
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF
garydgregory merged pull request #287:
URL: https://github.com/apache/commons-collections/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737280=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737280
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF
nhojpatrick commented on pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#issuecomment-1060031437
@garydgregory i think i've done all request changes regarding code review
and style.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/DBCP-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502007#comment-17502007
]
Gary D. Gregory commented on DBCP-584:
--
I not sure how to help here unless you can provide a
[
https://issues.apache.org/jira/browse/LANG-1462?focusedWorklogId=737277=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737277
]
ASF GitHub Bot logged work on LANG-1462:
Author: ASF GitHub Bot
garydgregory commented on pull request #863:
URL: https://github.com/apache/commons-lang/pull/863#issuecomment-1060025355
@mbuiakova
You'll need to update the Javadoc to reflect the change in behavior.
For the error, I'd start with Google ;-)
--
This is an automated message from
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737276=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737276
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF
garydgregory commented on a change in pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#discussion_r820275806
##
File path:
src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
##
@@ -501,26 +499,29 @@ public void exists() {
garydgregory commented on a change in pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#discussion_r820273330
##
File path: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
##
@@ -378,7 +378,7 @@ public void test_getEnumMap_keyFunction() {
garydgregory commented on a change in pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#discussion_r820273294
##
File path: src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
##
@@ -414,7 +415,7 @@ public StringBuffer format(final Object
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737274=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737274
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF
nhojpatrick edited a comment on pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#issuecomment-1060018294
So I added some debug and tests now pass, iI then reverted and they still
pass, I then squashed the change and revert so back to the previous failing
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737273=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737273
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF
nhojpatrick commented on pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#issuecomment-1060018294
So I added some debug and tests now pass, iI then reverted and they still
pass, I then squashed the change and revert so back to the previous failing
commit and
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737269=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737269
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF
codecov-commenter edited a comment on pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#issuecomment-1059548290
#
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737264
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF
codecov-commenter edited a comment on pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#issuecomment-1059548290
#
arturobernalg commented on a change in pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#discussion_r820271209
##
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##
@@ -3566,7 +3566,7 @@ public static boolean isSameType(final Object
nhojpatrick closed pull request #288:
URL: https://github.com/apache/commons-collections/pull/288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codecov-commenter commented on pull request #288:
URL:
https://github.com/apache/commons-collections/pull/288#issuecomment-1060008591
#
garydgregory commented on a change in pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#discussion_r820261598
##
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##
@@ -3566,7 +3566,7 @@ public static boolean isSameType(final Object
garydgregory commented on a change in pull request #758:
URL: https://github.com/apache/commons-lang/pull/758#discussion_r820261275
##
File path: src/main/java/org/apache/commons/lang3/EnumUtils.java
##
@@ -67,7 +67,7 @@
private static > Class checkBitVectorable(final
[
https://issues.apache.org/jira/browse/LANG-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated LANG-1462:
--
Summary: After version 3.4 DateFormatUtils has a bug (was: After version
Commons-lang3.4
[
https://issues.apache.org/jira/browse/LANG-1462?focusedWorklogId=737258=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737258
]
ASF GitHub Bot logged work on LANG-1462:
Author: ASF GitHub Bot
mbuiakova commented on pull request #863:
URL: https://github.com/apache/commons-lang/pull/863#issuecomment-1059996750
> Would you please explain why this is needed?
>
> Also:
>
> * there are no tests
> * the code has superfluous parentheses
I added a test and
[
https://issues.apache.org/jira/browse/LANG-1668?focusedWorklogId=737253=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737253
]
ASF GitHub Bot logged work on LANG-1668:
Author: ASF GitHub Bot
garydgregory merged pull request #862:
URL: https://github.com/apache/commons-lang/pull/862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LANG-1661?focusedWorklogId=737252=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737252
]
ASF GitHub Bot logged work on LANG-1661:
Author: ASF GitHub Bot
arturobernalg commented on pull request #762:
URL: https://github.com/apache/commons-lang/pull/762#issuecomment-1059988723
> Can this be used within Commons Lang?
Why not. There are commons class utils operations.
> Also, would you rebase on master, please?
Rebased.
--
arturobernalg commented on pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#issuecomment-1059988143
> @arturobernalg Would you rebase on master, please?
Done
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please
arturobernalg commented on pull request #758:
URL: https://github.com/apache/commons-lang/pull/758#issuecomment-1059987975
> @arturobernalg Would you rebase on master, please?
done
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/LANG-1462?focusedWorklogId=737251=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737251
]
ASF GitHub Bot logged work on LANG-1462:
Author: ASF GitHub Bot
garydgregory commented on pull request #863:
URL: https://github.com/apache/commons-lang/pull/863#issuecomment-1059981909
Would you please explain why this is needed?
Also:
- there are no tests
- the code has superfluous parentheses
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/LANG-1668?focusedWorklogId=737244=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737244
]
ASF GitHub Bot logged work on LANG-1668:
Author: ASF GitHub Bot
mbuiakova commented on pull request #862:
URL: https://github.com/apache/commons-lang/pull/862#issuecomment-1059973400
> @mbuiakova This change does not appear to be accurate: see the case
"candidates.isEmpty()" compared to the message of the exception. Or, am I
missing something?
[
https://issues.apache.org/jira/browse/LANG-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501971#comment-17501971
]
Maria Buiakova commented on LANG-1462:
--
I added usage of timezone from the calendar
[
https://issues.apache.org/jira/browse/LANG-1462?focusedWorklogId=737242=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737242
]
ASF GitHub Bot logged work on LANG-1462:
Author: ASF GitHub Bot
mbuiakova opened a new pull request #863:
URL: https://github.com/apache/commons-lang/pull/863
Uses timezone from the calendar object when no timezone is specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/LANG-1668?focusedWorklogId=737241=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737241
]
ASF GitHub Bot logged work on LANG-1668:
Author: ASF GitHub Bot
garydgregory commented on pull request #862:
URL: https://github.com/apache/commons-lang/pull/862#issuecomment-1059969335
@mbuiakova
This change does not appear to be accurate: see the case
"candidates.isEmpty()" compared to the message of the exception. Or, am I
missing something?
garydgregory commented on a change in pull request #733:
URL: https://github.com/apache/commons-lang/pull/733#discussion_r820237567
##
File path: src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
##
@@ -359,14 +359,16 @@ public static String
[
https://issues.apache.org/jira/browse/LANG-1661?focusedWorklogId=737238=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737238
]
ASF GitHub Bot logged work on LANG-1661:
Author: ASF GitHub Bot
garydgregory commented on pull request #762:
URL: https://github.com/apache/commons-lang/pull/762#issuecomment-1059965864
Can this be used within Commons Lang?
Also, would you rebase on master, please?
--
This is an automated message from the Apache Git Service.
To respond to the
garydgregory commented on pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#issuecomment-1059965712
@arturobernalg Would you rebase on master, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
garydgregory edited a comment on pull request #758:
URL: https://github.com/apache/commons-lang/pull/758#issuecomment-1059965658
@arturobernalg Would you rebase on master, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
garydgregory commented on pull request #758:
URL: https://github.com/apache/commons-lang/pull/758#issuecomment-1059965658
@arturobernalg Would you rebase on master please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
garydgregory closed pull request #845:
URL: https://github.com/apache/commons-lang/pull/845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on pull request #845:
URL: https://github.com/apache/commons-lang/pull/845#issuecomment-1059965580
Closing, no feedback from OP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LANG-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501960#comment-17501960
]
Maria commented on LANG-1668:
-
I added a mention of the exception in the documentation.
[
https://issues.apache.org/jira/browse/LANG-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501960#comment-17501960
]
Maria edited comment on LANG-1668 at 3/6/22, 1:44 PM:
--
I added a mention of the
garydgregory closed pull request #760:
URL: https://github.com/apache/commons-lang/pull/760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on pull request #760:
URL: https://github.com/apache/commons-lang/pull/760#issuecomment-1059965210
Closing, no more feedback from OP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/LANG-1668?focusedWorklogId=737237=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737237
]
ASF GitHub Bot logged work on LANG-1668:
Author: ASF GitHub Bot
mbuiakova opened a new pull request #862:
URL: https://github.com/apache/commons-lang/pull/862
Adds a mention of IllegalStateException in case no unique method is found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
66 matches
Mail list logo
